From: Jakub Kicinski <kuba@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
"Kalle Valo" <kvalo@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath9k: Remove unused variable mismatch
Date: Fri, 4 Nov 2022 11:17:50 -0700 [thread overview]
Message-ID: <20221104111750.2b323850@kernel.org> (raw)
In-Reply-To: <20221104140723.226857-1-colin.i.king@gmail.com>
On Fri, 4 Nov 2022 14:07:23 +0000 Colin Ian King wrote:
> Variable mismatch is just being incremented and it's never used anywhere
> else. The variable and the increment are redundant so remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Good sir, you don't have to CC netdev on wireless patches.
Especially trivial ones. I'm saying this because you're a
major contributor and I presume you send patches based on
some scripted integration with get_maintainer so I hope
this could nudge you to improve get_maintainer itself? :)
Perhaps any entry which has a tree specified should mask
off entries higher up?
next prev parent reply other threads:[~2022-11-04 18:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 14:07 [PATCH] ath9k: Remove unused variable mismatch Colin Ian King
2022-11-04 18:17 ` Jakub Kicinski [this message]
2022-11-06 13:41 ` Toke Høiland-Jørgensen
2022-11-09 7:04 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104111750.2b323850@kernel.org \
--to=kuba@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.