All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Graute <oliver.graute@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: sbabic@denx.de, peng.fan@nxp.com, uboot-imx@nxp.com,
	"Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
	"Ye Li" <ye.li@nxp.com>, "Gaurav Jain" <gaurav.jain@nxp.com>,
	"Denys Drozdov" <denys.drozdov@toradex.com>,
	"Horia Geantă" <horia.geanta@nxp.com>,
	u-boot@lists.denx.de
Subject: Re: [PATCH v1] imx: imx8: apalis: switch to binman
Date: Fri, 4 Nov 2022 14:07:34 +0100	[thread overview]
Message-ID: <20221104130734.GD9571@optiplex> (raw)
In-Reply-To: <CAOMZO5B99Wq+7TqGNcJ=pXW9gAa0g=GvZZvWK1N8+oshx1Gmfg@mail.gmail.com>

On 04/11/22, Fabio Estevam wrote:
> Hi Oliver,
> 
> On Fri, Nov 4, 2022 at 9:39 AM Oliver Graute <oliver.graute@gmail.com> wrote:
> 
> > > Can't all boards use the common the binman nodes from
> > > arch/arm/dts/imx8qm-u-boot.dtsi instead?
> >
> > I'am about to try that but I run into the following error:
> >
> > binman: Filename 'spl/u-boot-spl.bin' not found in input path (.,.,./board/toradex/apalis-imx8,arch/arm/dts) (cwd='/home/graute/u-boot-upstream')
> > Makefile:1109: recipe for target 'all' failed
> > make: *** [all] Error 1
> >
> > The error disappear if I remove binman/u-boot-spl-ddr and binman/spl
> > node in the common file.
> >
> > So some of these boards needs the binman/u-boot-spl-ddr and binman/spl
> > node and others not. What is the proper solution to deal with this
> > difference here?
> 
> Looking inside configs/apalis-imx8_defconfig, I see it does not use
> SPL. That's why 'spl/u-boot-spl.bin' is not present.
> 
> I think you should protect the  binman/u-boot-spl-ddr and binman/spl
> nodes by adding #ifdef CONFIG_SPL.

ok thx

Best Regards,

Oliver

  reply	other threads:[~2022-11-04 13:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 15:56 [PATCH 0/8] imx8: switch missing boards to binman Oliver Graute
2022-11-02 15:56 ` [PATCH v5] imx: imx8qm-rom7720: switch " Oliver Graute
2022-11-02 15:56 ` [PATCH v6] imx: imx8qm: cgtqmx8: " Oliver Graute
2022-11-02 15:56 ` [PATCH v1] imx: imx8qxp: imx8qxp_mek " Oliver Graute
2022-11-02 15:56 ` [PATCH v2] imx: imx8qm: imx8qm_mek " Oliver Graute
2022-11-02 15:56 ` [PATCH v1] imx: imx8qxp: giedi " Oliver Graute
2022-11-02 15:56 ` [PATCH v1] imx: imx8qxp: deneb " Oliver Graute
2022-11-02 15:56 ` [PATCH v1] imx: imx8x: colibri: " Oliver Graute
2022-11-02 15:56 ` [PATCH v1] imx: imx8: apalis: " Oliver Graute
2022-11-02 16:16   ` Fabio Estevam
2022-11-04 12:38     ` Oliver Graute
2022-11-04 12:58       ` Fabio Estevam
2022-11-04 13:07         ` Oliver Graute [this message]
2022-11-04 13:03       ` Oliver Graute
2022-11-02 16:07 ` [PATCH 0/8] imx8: switch missing boards " Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221104130734.GD9571@optiplex \
    --to=oliver.graute@gmail.com \
    --cc=denys.drozdov@toradex.com \
    --cc=festevam@gmail.com \
    --cc=gaurav.jain@nxp.com \
    --cc=horia.geanta@nxp.com \
    --cc=marcel.ziswiler@toradex.com \
    --cc=peng.fan@nxp.com \
    --cc=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    --cc=ye.li@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.