From: Jakub Kicinski <kuba@kernel.org>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
netdev@vger.kernel.org, davem@davemloft.net,
linux-can@vger.kernel.org, kernel@pengutronix.de,
Dariusz Stojaczyk <Dariusz.Stojaczyk@opensynergy.com>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Max Staudt <max@enpas.org>,
stable@vger.kernel.org
Subject: Re: [PATCH net 4/5] can: dev: fix skb drop check
Date: Fri, 4 Nov 2022 15:36:11 -0700 [thread overview]
Message-ID: <20221104153611.53758e3a@kernel.org> (raw)
In-Reply-To: <68896ba9-68c6-1f7a-3c6c-c3ee3c98e32f@hartkopp.net>
On Fri, 4 Nov 2022 21:33:16 +0100 Oliver Hartkopp wrote:
> On 04.11.22 19:50, Jakub Kicinski wrote:
> > On Fri, 4 Nov 2022 14:05:34 +0100 Marc Kleine-Budde wrote:
> >> - if (can_dropped_invalid_skb(ndev, skb))
> >> + if (can_dev_dropped_skb(dev, skb))
> >
> > Compiler says "Did you mean ndev"?
>
> Your compiler is a smart buddy! Sorry!
>
> Marc added that single change to my patch for the pch_can.c driver
> (which is removed in net-next but not in 6.1-rc).
>
> And in pch_can.c the netdev is named ndev.
>
> Would you like to fix this up on your own or should we send an updated
> PR for the series?
Updated PR would be better, if possible.
We don't edit patches locally much (at all?) when applying to netdev.
next prev parent reply other threads:[~2022-11-04 22:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 13:05 [PATCH net 0/5] pull-request: can 2022-11-04 Marc Kleine-Budde
2022-11-04 13:05 ` [PATCH net 1/5] can: af_can: can_exit(): add missing dev_remove_pack() of canxl_packet Marc Kleine-Budde
2022-11-04 13:05 ` [PATCH net 2/5] can: af_can: fix NULL pointer dereference in can_rx_register() Marc Kleine-Budde
2022-11-04 13:05 ` [PATCH net 3/5] can: j1939: j1939_send_one(): fix missing CAN header initialization Marc Kleine-Budde
2022-11-04 13:05 ` [PATCH net 4/5] can: dev: fix skb drop check Marc Kleine-Budde
2022-11-04 18:50 ` Jakub Kicinski
2022-11-04 20:33 ` Oliver Hartkopp
2022-11-04 22:36 ` Jakub Kicinski [this message]
2022-11-05 9:01 ` Oliver Hartkopp
2022-11-07 13:01 ` Marc Kleine-Budde
2022-11-04 13:05 ` [PATCH net 5/5] can: rcar_canfd: Add missing ECC error checks for channels 2-7 Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104153611.53758e3a@kernel.org \
--to=kuba@kernel.org \
--cc=Dariusz.Stojaczyk@opensynergy.com \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=max@enpas.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.