From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CCA2C433FE for ; Sun, 6 Nov 2022 01:54:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1CFC985247; Sun, 6 Nov 2022 02:53:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=volkov.fr Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=volkov.fr header.i=@volkov.fr header.b="UO2wY+73"; dkim=pass (2048-bit key) header.d=volkov.fr header.i=@volkov.fr header.b="aaJz+Oi5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A071E85248; Sun, 6 Nov 2022 02:53:57 +0100 (CET) Received: from mail.volkov.fr (sapphire.volkov.fr [3.18.100.122]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C5CD885215 for ; Sun, 6 Nov 2022 02:53:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=volkov.fr Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andrey@volkov.fr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=volkov.fr; s=mail; t=1667699633; bh=u5ZzQxpZmB/y9UmUNJ+beXCeE9Qw9ISi9/I494OFHSk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UO2wY+73bLvYsArXlE3QHbJA5IiXqzCQk90G98Rn5wF2Z8DT/Xk1GZyrZux+JA7pb wor8bdECycziuY+/JJOIHFVN68BtteAepshLipQ7JaugMJCcswoRmpnGO1WEM913x/ uwSI0WIEUKm7y65t1Ag5bYuw2pgp3N6sv5S0xIrmPaJ+k2UhWfOGu+cbgn7vow05+J LbSVBDeWCD2RKiUEPyejPG0LzSCZFlW4YJLtWoRECTz/QUgOXM6dZPJtx3QKUWNv7R yrQByBtEguX/rQzagtkgkITBLx2jfrq8rmoRFliVFLeSfHz4PGVjKDDPlHLd0V5MW8 cW6lDnx8x0KmQ== Authentication-Results: mail.volkov.fr; dmarc=none (p=none dis=none) header.from=volkov.fr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=volkov.fr; s=mail; t=1667699632; bh=u5ZzQxpZmB/y9UmUNJ+beXCeE9Qw9ISi9/I494OFHSk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aaJz+Oi57Jb7w4XZwk7xmnRr6bDzgj8Cq3VZuiMgZ67hgslFrWbo+d6Pt9A+5HqPb 1jYrOwQi8ejLCya/DNgDMs4bKwpwKbFv1WUgTWQVX4u4qi+jtPSAnuVu9YJ78y8hY5 nm8vN6FVLls95HvD10owk/UCB/W/ionHLlza4lheyIKmxeJOu9Vj6QWeHhy2YqHVKp +diu1RMdT0vD/QNH0D6sOsYDCFryurhST8p98wiJ9Ghee5TDuCWtz9a2znFpsEp14H fF70m95i1z9vwcEpeY4Nl35BmywbzCtbfKNOv5jEsz1pr9t4G7JTkDLPV0+CMC1+QR JYbuKyjrxR9Qg== From: Andrey VOLKOV To: Tom Rini , Robert Marko Cc: Ramon Fried , u-boot@lists.denx.de, Andrey VOLKOV Subject: Re: [PATCH 1/2] mach-snapdragon/mach-ipq40xx: fix, merge and refactoring Date: Sun, 6 Nov 2022 02:52:56 +0100 Message-Id: <20221106015258.217868-1-andrey@volkov.fr> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: <4203bd12-2adb-96ca-3623-b92e7d752eae@volkov.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Robert, Tom, Updated patches are following, could you review/accept them? Le 04/11/2022 à 12:05, Robert Marko a écrit : > On Tue, Oct 25, 2022 at 3:31 AM Andrey Volkov wrote: >> SoC: qcom: Add missing Qualcomm's SOCs definitions to the arch KConfig >> >> From: Andrey VOLKOV >> >> Add APQ8016/APQ8096/QCS40X decls to the KConfig, convert SDM845 declaration to the hidden one (selected by target), >> and update mach-snapdragon/Makefile accordingly. >> >> Also move 'CONFIG_ARM64' choice to the new declarations, since 'Snapdragon' contains Cortex A7A members too. >> >> Signed-off-by: Andrey VOLKOV > I like this cleanup effort, however, can you rebase this to apply on the master? > I would like to use this as a base of moving IPQ40xx to use Linux DTS > and keep it in sync. It's nice idea, except that full blown DTS is huge enough (+some KiB at least), and i'm afraid it's an old, old story about failing to make it :(. Probably will be better if we will have some option that allowed to import and reuse DTS files directly from the kernel. Something like CONFIG_DTS_FILE_PATH/CONFIG_DTS_INCLUDES/... @Tom, any additional comments/objections? Btw As far as I remember, this topic (reuse kernel's DTS) has been discussed repeatedly since the mid-2000s, but I don't remember why it was not implemented yet. > > Regards, > Robert Regards Andrey --- Andrey VOLKOV (2): SoC: qcom: Add missing Qualcomm's SOCs definitions to the arch KConfig ipq40xx/snapdragon: Merge the two, more than 90% overlapping Qualcomm's Snapdrgon based arches, into one: "mach-snapdragon". arch/arm/Kconfig | 20 +-- arch/arm/Makefile | 1 - arch/arm/mach-ipq40xx/Kconfig | 15 -- arch/arm/mach-ipq40xx/Makefile | 9 - arch/arm/mach-ipq40xx/include/mach/gpio.h | 10 -- arch/arm/mach-ipq40xx/pinctrl-snapdragon.c | 166 ------------------ arch/arm/mach-ipq40xx/pinctrl-snapdragon.h | 30 ---- arch/arm/mach-snapdragon/Kconfig | 62 ++++++- arch/arm/mach-snapdragon/Makefile | 34 ++-- .../clock-ipq4019.c | 0 .../pinctrl-ipq4019.c | 0 arch/arm/mach-snapdragon/pinctrl-snapdragon.c | 48 +++-- arch/arm/mach-snapdragon/pinctrl-snapdragon.h | 1 + drivers/phy/qcom/Kconfig | 2 +- drivers/reset/Kconfig | 2 +- drivers/reset/reset-qcom.c | 4 +- drivers/smem/Kconfig | 2 +- drivers/spi/Kconfig | 2 +- 18 files changed, 123 insertions(+), 285 deletions(-) delete mode 100644 arch/arm/mach-ipq40xx/Kconfig delete mode 100644 arch/arm/mach-ipq40xx/Makefile delete mode 100644 arch/arm/mach-ipq40xx/include/mach/gpio.h delete mode 100644 arch/arm/mach-ipq40xx/pinctrl-snapdragon.c delete mode 100644 arch/arm/mach-ipq40xx/pinctrl-snapdragon.h rename arch/arm/{mach-ipq40xx => mach-snapdragon}/clock-ipq4019.c (100%) rename arch/arm/{mach-ipq40xx => mach-snapdragon}/pinctrl-ipq4019.c (100%) -- 2.34.1