From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95042C4332F for ; Sun, 6 Nov 2022 23:14:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230089AbiKFXO0 convert rfc822-to-8bit (ORCPT ); Sun, 6 Nov 2022 18:14:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230080AbiKFXO0 (ORCPT ); Sun, 6 Nov 2022 18:14:26 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 03D806555; Sun, 6 Nov 2022 15:14:22 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5B0091FB; Sun, 6 Nov 2022 15:14:28 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8C5103F534; Sun, 6 Nov 2022 15:14:20 -0800 (PST) Date: Sun, 6 Nov 2022 23:12:50 +0000 From: Andre Przywara To: Jernej =?UTF-8?B?xaBrcmFiZWM=?= Cc: Samuel Holland , Chen-Yu Tsai , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Icenowy Zheng , Gregory CLEMENT , linux-i2c@vger.kernel.org Subject: Re: [PATCH 4/9] ARM: dts: suniv: f1c100s: add I2C DT nodes Message-ID: <20221106231214.7d2d8505@slackpad.lan> In-Reply-To: <4223066.ejJDZkT8p0@jernej-laptop> References: <20221101141658.3631342-1-andre.przywara@arm.com> <20221101141658.3631342-5-andre.przywara@arm.com> <4223066.ejJDZkT8p0@jernej-laptop> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Sun, 06 Nov 2022 09:09:17 +0100 Jernej Škrabec wrote: > Dne torek, 01. november 2022 ob 15:16:53 CET je Andre Przywara napisal(a): > > The Allwinner F1C100s series of SoCs contain three I2C controllers > > compatible to the ones used in other Allwinner SoCs. > > > > Add the DT nodes describing the resources of the controllers. > > I2C1 has only one possible pinmux, so add the pinctrl properties for > > that already. > > At least one board connects an on-board I2C chip to PD0/PD12 (I2C0), so > > include those pins already, to simplify referencing them later. > > > > Signed-off-by: Andre Przywara > > --- > > arch/arm/boot/dts/suniv-f1c100s.dtsi | 50 ++++++++++++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > > > diff --git a/arch/arm/boot/dts/suniv-f1c100s.dtsi > > b/arch/arm/boot/dts/suniv-f1c100s.dtsi index d5a6324e76465..2901c586971b4 > > 100644 > > --- a/arch/arm/boot/dts/suniv-f1c100s.dtsi > > +++ b/arch/arm/boot/dts/suniv-f1c100s.dtsi > > @@ -166,6 +166,18 @@ mmc0_pins: mmc0-pins { > > drive-strength = <30>; > > }; > > > > + /omit-if-no-ref/ > > + i2c0_pd_pins: i2c0-pd-pins { > > + pins = "PD0", "PD12"; > > + function = "i2c0"; > > + }; > > + > > + /omit-if-no-ref/ > > Above flag is meaningless if i2c1_pins is always referenced by i2c1. Indeed, good point. > Anyway, I > see in pinctrl driver that there are actually two possible pin assignments for > i2c1. One on port D and another on port B. Ah, those are the pins that are not documented in the manual (which is where I looked at). I will drop that node. Cheers, Andre > > Best regards, > Jernej > > > + i2c1_pins: i2c1-pins { > > + pins = "PD5", "PD6"; > > + function = "i2c1"; > > + }; > > + > > spi0_pc_pins: spi0-pc-pins { > > pins = "PC0", "PC1", "PC2", > "PC3"; > > function = "spi0"; > > @@ -177,6 +189,44 @@ uart0_pe_pins: uart0-pe-pins { > > }; > > }; > > > > + i2c0: i2c@1c27000 { > > + compatible = "allwinner,suniv-f1c100s-i2c", > > + "allwinner,sun6i-a31-i2c"; > > + reg = <0x01c27000 0x400>; > > + interrupts = <7>; > > + clocks = <&ccu CLK_BUS_I2C0>; > > + resets = <&ccu RST_BUS_I2C0>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "disabled"; > > + }; > > + > > + i2c1: i2c@1c27400 { > > + compatible = "allwinner,suniv-f1c100s-i2c", > > + "allwinner,sun6i-a31-i2c"; > > + reg = <0x01c27400 0x400>; > > + interrupts = <8>; > > + clocks = <&ccu CLK_BUS_I2C1>; > > + resets = <&ccu RST_BUS_I2C1>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&i2c1_pins>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "disabled"; > > + }; > > + > > + i2c2: i2c@1c27800 { > > + compatible = "allwinner,suniv-f1c100s-i2c", > > + "allwinner,sun6i-a31-i2c"; > > + reg = <0x01c27800 0x400>; > > + interrupts = <9>; > > + clocks = <&ccu CLK_BUS_I2C2>; > > + resets = <&ccu RST_BUS_I2C2>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "disabled"; > > + }; > > + > > timer@1c20c00 { > > compatible = "allwinner,suniv-f1c100s- > timer"; > > reg = <0x01c20c00 0x90>; > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 173E2C433FE for ; Sun, 6 Nov 2022 23:15:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sNLaD/mP4aWKUKCs22/4WRoxyAedQ/JujDfRodcMzSE=; b=RQ/BfMt+W0uKsV bl6pL8T+ZvplJGixeJncNpdZLo56/QBDnw1UiRGP8e2OWCRkqLpWyWpAs7LgTKXu5QAeFEuTQMu3b qmA8zUuQD7k2D87W5VHfCMyvkGDL75uArNSHRVPsPEGK2hbwXGnZT4EqG2tpCzHtOYciIR23MEgo8 fR2AT2ZBYORGNAGRydyozRCAhzsXt9VNLdhUwIMOvgFuOky4stB9sSgXeatC04nbkG8egdtFVRXCm WcbTQLL7bvZzjeYiwh0qGLaaw5DD4BOEBHvjxex2XW1cz5HRytlTLtPvpqKcsLBDq5GvrCl4daa6S JlKnT7TrDJwipqx+lgTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oroqU-00AMF5-Kc; Sun, 06 Nov 2022 23:14:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oroqR-00AMCo-6A for linux-arm-kernel@lists.infradead.org; Sun, 06 Nov 2022 23:14:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5B0091FB; Sun, 6 Nov 2022 15:14:28 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8C5103F534; Sun, 6 Nov 2022 15:14:20 -0800 (PST) Date: Sun, 6 Nov 2022 23:12:50 +0000 From: Andre Przywara To: Jernej =?UTF-8?B?xaBrcmFiZWM=?= Cc: Samuel Holland , Chen-Yu Tsai , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Icenowy Zheng , Gregory CLEMENT , linux-i2c@vger.kernel.org Subject: Re: [PATCH 4/9] ARM: dts: suniv: f1c100s: add I2C DT nodes Message-ID: <20221106231214.7d2d8505@slackpad.lan> In-Reply-To: <4223066.ejJDZkT8p0@jernej-laptop> References: <20221101141658.3631342-1-andre.przywara@arm.com> <20221101141658.3631342-5-andre.przywara@arm.com> <4223066.ejJDZkT8p0@jernej-laptop> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221106_151427_337022_A1DA2F65 X-CRM114-Status: GOOD ( 18.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCAwNiBOb3YgMjAyMiAwOTowOToxNyArMDEwMApKZXJuZWogxaBrcmFiZWMgPGplcm5l ai5za3JhYmVjQGdtYWlsLmNvbT4gd3JvdGU6Cgo+IERuZSB0b3JlaywgMDEuIG5vdmVtYmVyIDIw MjIgb2IgMTU6MTY6NTMgQ0VUIGplIEFuZHJlIFByenl3YXJhIG5hcGlzYWwoYSk6Cj4gPiBUaGUg QWxsd2lubmVyIEYxQzEwMHMgc2VyaWVzIG9mIFNvQ3MgY29udGFpbiB0aHJlZSBJMkMgY29udHJv bGxlcnMKPiA+IGNvbXBhdGlibGUgdG8gdGhlIG9uZXMgdXNlZCBpbiBvdGhlciBBbGx3aW5uZXIg U29Dcy4KPiA+IAo+ID4gQWRkIHRoZSBEVCBub2RlcyBkZXNjcmliaW5nIHRoZSByZXNvdXJjZXMg b2YgdGhlIGNvbnRyb2xsZXJzLgo+ID4gSTJDMSBoYXMgb25seSBvbmUgcG9zc2libGUgcGlubXV4 LCBzbyBhZGQgdGhlIHBpbmN0cmwgcHJvcGVydGllcyBmb3IKPiA+IHRoYXQgYWxyZWFkeS4KPiA+ IEF0IGxlYXN0IG9uZSBib2FyZCBjb25uZWN0cyBhbiBvbi1ib2FyZCBJMkMgY2hpcCB0byBQRDAv UEQxMiAoSTJDMCksIHNvCj4gPiBpbmNsdWRlIHRob3NlIHBpbnMgYWxyZWFkeSwgdG8gc2ltcGxp ZnkgcmVmZXJlbmNpbmcgdGhlbSBsYXRlci4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogQW5kcmUg UHJ6eXdhcmEgPGFuZHJlLnByenl3YXJhQGFybS5jb20+Cj4gPiAtLS0KPiA+ICBhcmNoL2FybS9i b290L2R0cy9zdW5pdi1mMWMxMDBzLmR0c2kgfCA1MCArKysrKysrKysrKysrKysrKysrKysrKysr KysrCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDUwIGluc2VydGlvbnMoKykKPiA+IAo+ID4gZGlmZiAt LWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL3N1bml2LWYxYzEwMHMuZHRzaQo+ID4gYi9hcmNoL2Fy bS9ib290L2R0cy9zdW5pdi1mMWMxMDBzLmR0c2kgaW5kZXggZDVhNjMyNGU3NjQ2NS4uMjkwMWM1 ODY5NzFiNAo+ID4gMTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy9zdW5pdi1mMWMx MDBzLmR0c2kKPiA+ICsrKyBiL2FyY2gvYXJtL2Jvb3QvZHRzL3N1bml2LWYxYzEwMHMuZHRzaQo+ ID4gQEAgLTE2Niw2ICsxNjYsMTggQEAgbW1jMF9waW5zOiBtbWMwLXBpbnMgewo+ID4gIAkJCQlk cml2ZS1zdHJlbmd0aCA9IDwzMD47Cj4gPiAgCQkJfTsKPiA+IAo+ID4gKwkJCS9vbWl0LWlmLW5v LXJlZi8KPiA+ICsJCQlpMmMwX3BkX3BpbnM6IGkyYzAtcGQtcGlucyB7Cj4gPiArCQkJCXBpbnMg PSAiUEQwIiwgIlBEMTIiOwo+ID4gKwkJCQlmdW5jdGlvbiA9ICJpMmMwIjsKPiA+ICsJCQl9Owo+ ID4gKwo+ID4gKwkJCS9vbWl0LWlmLW5vLXJlZi8gIAo+IAo+IEFib3ZlIGZsYWcgaXMgbWVhbmlu Z2xlc3MgaWYgaTJjMV9waW5zIGlzIGFsd2F5cyByZWZlcmVuY2VkIGJ5IGkyYzEuCgpJbmRlZWQs IGdvb2QgcG9pbnQuCgo+IEFueXdheSwgSSAKPiBzZWUgaW4gcGluY3RybCBkcml2ZXIgdGhhdCB0 aGVyZSBhcmUgYWN0dWFsbHkgdHdvIHBvc3NpYmxlIHBpbiBhc3NpZ25tZW50cyBmb3IgCj4gaTJj MS4gT25lIG9uIHBvcnQgRCBhbmQgYW5vdGhlciBvbiBwb3J0IEIuCgpBaCwgdGhvc2UgYXJlIHRo ZSBwaW5zIHRoYXQgYXJlIG5vdCBkb2N1bWVudGVkIGluIHRoZSBtYW51YWwgKHdoaWNoIGlzCndo ZXJlIEkgbG9va2VkIGF0KS4gSSB3aWxsIGRyb3AgdGhhdCBub2RlLgoKQ2hlZXJzLApBbmRyZQoK PiAKPiBCZXN0IHJlZ2FyZHMsCj4gSmVybmVqCj4gCj4gPiArCQkJaTJjMV9waW5zOiBpMmMxLXBp bnMgewo+ID4gKwkJCQlwaW5zID0gIlBENSIsICJQRDYiOwo+ID4gKwkJCQlmdW5jdGlvbiA9ICJp MmMxIjsKPiA+ICsJCQl9Owo+ID4gKwo+ID4gIAkJCXNwaTBfcGNfcGluczogc3BpMC1wYy1waW5z IHsKPiA+ICAJCQkJcGlucyA9ICJQQzAiLCAiUEMxIiwgIlBDMiIsICAgCj4gIlBDMyI7Cj4gPiAg CQkJCWZ1bmN0aW9uID0gInNwaTAiOwo+ID4gQEAgLTE3Nyw2ICsxODksNDQgQEAgdWFydDBfcGVf cGluczogdWFydDAtcGUtcGlucyB7Cj4gPiAgCQkJfTsKPiA+ICAJCX07Cj4gPiAKPiA+ICsJCWky YzA6IGkyY0AxYzI3MDAwIHsKPiA+ICsJCQljb21wYXRpYmxlID0gImFsbHdpbm5lcixzdW5pdi1m MWMxMDBzLWkyYyIsCj4gPiArCQkJCSAgICAgImFsbHdpbm5lcixzdW42aS1hMzEtaTJjIjsKPiA+ ICsJCQlyZWcgPSA8MHgwMWMyNzAwMCAweDQwMD47Cj4gPiArCQkJaW50ZXJydXB0cyA9IDw3PjsK PiA+ICsJCQljbG9ja3MgPSA8JmNjdSBDTEtfQlVTX0kyQzA+Owo+ID4gKwkJCXJlc2V0cyA9IDwm Y2N1IFJTVF9CVVNfSTJDMD47Cj4gPiArCQkJI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4gPiArCQkJ I3NpemUtY2VsbHMgPSA8MD47Cj4gPiArCQkJc3RhdHVzID0gImRpc2FibGVkIjsKPiA+ICsJCX07 Cj4gPiArCj4gPiArCQlpMmMxOiBpMmNAMWMyNzQwMCB7Cj4gPiArCQkJY29tcGF0aWJsZSA9ICJh bGx3aW5uZXIsc3VuaXYtZjFjMTAwcy1pMmMiLAo+ID4gKwkJCQkgICAgICJhbGx3aW5uZXIsc3Vu NmktYTMxLWkyYyI7Cj4gPiArCQkJcmVnID0gPDB4MDFjMjc0MDAgMHg0MDA+Owo+ID4gKwkJCWlu dGVycnVwdHMgPSA8OD47Cj4gPiArCQkJY2xvY2tzID0gPCZjY3UgQ0xLX0JVU19JMkMxPjsKPiA+ ICsJCQlyZXNldHMgPSA8JmNjdSBSU1RfQlVTX0kyQzE+Owo+ID4gKwkJCXBpbmN0cmwtbmFtZXMg PSAiZGVmYXVsdCI7Cj4gPiArCQkJcGluY3RybC0wID0gPCZpMmMxX3BpbnM+Owo+ID4gKwkJCSNh ZGRyZXNzLWNlbGxzID0gPDE+Owo+ID4gKwkJCSNzaXplLWNlbGxzID0gPDA+Owo+ID4gKwkJCXN0 YXR1cyA9ICJkaXNhYmxlZCI7Cj4gPiArCQl9Owo+ID4gKwo+ID4gKwkJaTJjMjogaTJjQDFjMjc4 MDAgewo+ID4gKwkJCWNvbXBhdGlibGUgPSAiYWxsd2lubmVyLHN1bml2LWYxYzEwMHMtaTJjIiwK PiA+ICsJCQkJICAgICAiYWxsd2lubmVyLHN1bjZpLWEzMS1pMmMiOwo+ID4gKwkJCXJlZyA9IDww eDAxYzI3ODAwIDB4NDAwPjsKPiA+ICsJCQlpbnRlcnJ1cHRzID0gPDk+Owo+ID4gKwkJCWNsb2Nr cyA9IDwmY2N1IENMS19CVVNfSTJDMj47Cj4gPiArCQkJcmVzZXRzID0gPCZjY3UgUlNUX0JVU19J MkMyPjsKPiA+ICsJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiA+ICsJCQkjc2l6ZS1jZWxscyA9 IDwwPjsKPiA+ICsJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ID4gKwkJfTsKPiA+ICsKPiA+ICAJ CXRpbWVyQDFjMjBjMDAgewo+ID4gIAkJCWNvbXBhdGlibGUgPSAiYWxsd2lubmVyLHN1bml2LWYx YzEwMHMtICAKPiB0aW1lciI7Cj4gPiAgCQkJcmVnID0gPDB4MDFjMjBjMDAgMHg5MD47ICAKPiAK PiAKPiAKPiAKPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg==