From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCE86C4332F for ; Sun, 6 Nov 2022 23:28:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230115AbiKFX2d (ORCPT ); Sun, 6 Nov 2022 18:28:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230024AbiKFX2c (ORCPT ); Sun, 6 Nov 2022 18:28:32 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62D19635B; Sun, 6 Nov 2022 15:28:30 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 18E94B80D69; Sun, 6 Nov 2022 23:28:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E12FC433D6; Sun, 6 Nov 2022 23:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667777307; bh=3Cd2pgUygkB4hpu5zj8Mcl7NTGFw2u8uR5Ty1Bp3ClQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aFJU8jeYmL8IiEbZgaZyhNW9UdTViNEfDOvsC0oWDH9BVeKXZPcNbJFFf0fgreBJ+ UBd+dlQsh5BiyuBFTgHZCDWRc9igRo36Hyc08+4kXVSs6raLKXFVIY493qY20RZfxd 9FLc4rTF5lds3P4wWqSiLBB/4wuooo0rEMH6R8htn/Y6pu0sgubNg2QqcuTsaVQLAR 90KDqvKIX1Z8ZHkT56T+ZLXJIVZGAzELNPH7o/Fzp5sGz+RazF48gukFGXNpNfiTtN Mx8MZZEvOSXD+jsehkLmNPtMsM+itr+nDHYhEB4J2M/cozviqiNQYvQDXoBxDj+e5W 0G8RK88EHdYRQ== Received: by pali.im (Postfix) id 9A5F8858; Mon, 7 Nov 2022 00:28:24 +0100 (CET) Date: Mon, 7 Nov 2022 00:28:24 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Lorenzo Pieralisi Cc: Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Russell King , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Thomas Petazzoni , Mauri Sandberg , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/7] PCI: mvebu: add support for orion soc Message-ID: <20221106232824.du4uou6pf77rqu45@pali> References: <20220718202843.6766-1-maukka@ext.kapsi.fi> <20220905192310.22786-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thursday 27 October 2022 16:10:48 Lorenzo Pieralisi wrote: > On Mon, Sep 05, 2022 at 09:23:03PM +0200, Pali Rohár wrote: > > Hello! This patch series add support for Orion PCIe controller into > > pci-mvebu.c driver. V3 version has completely rewritten pci-mvebu.c code > > to parse all physical addresses from device tree files according to > > mvebu-pci.txt documentation, allow access to all extended PCIe config > > space registers and use modern kernel API pci_remap_cfgspace() and > > mvebu_mbus_add_window_by_id() fir mapping PCIe config space. > > > > Most of Marvell device tree code in pci-mvebu.c is giant magic, but it was > > there because this change and it is de-facto API between dts files and > > kernel used for a long time. Note that it is misused according to PCI > > device tree bindings, but we have to follow this Marvell bindings to do > > not introduce backward incompatibility issues for other non-Orion > > platforms. > > > > Mauri tested these changes on DNS323 board with both DT and non-DT builds. > > PCIe AER is working too (one of the feature which proved that access to > > extended PCIe config registers is working fine). > > > > After this patch is accepted we are planning to look at existing Orion > > arch specific code and covert it to use this new DT based pci-mvebu.c > > code. Later this would allow to kill arch specific Orion PCIe code, > > which is in arch/arm/plat-orion/pcie.c and parts also in file > > arch/arm/mach-orion5x/pci.c (shared with old-PCI bus code). > > > > This patch series depends on another patches: > > https://lore.kernel.org/linux-pci/20220524122817.7199-1-pali@kernel.org/ > > https://lore.kernel.org/linux-pci/20220817230036.817-3-pali@kernel.org/ > > Can this series be rebased please on top of v6.1-rc1 so that we can merge it ? IIRC above two dependent patches still applies on master branch and this patch series applies on above two dependent patches. > Thanks, > Lorenzo > > > Mauri Sandberg (2): > > bus: mvebu-mbus: add configuration space aperture > > dt-bindings: PCI: mvebu: Add orion5x compatible > > > > Pali Rohár (5): > > ARM: orion: Move PCIe mbus window mapping from orion5x_setup_wins() to > > pcie_setup() > > PCI: mvebu: Remove unused busn member > > PCI: mvebu: Cleanup error handling in mvebu_pcie_probe() > > PCI: mvebu: Add support for Orion PCIe controller > > ARM: dts: orion5x: Add PCIe node > > > > .../devicetree/bindings/pci/mvebu-pci.txt | 4 +- > > arch/arm/boot/dts/orion5x.dtsi | 51 +++++ > > arch/arm/mach-orion5x/common.c | 13 -- > > arch/arm/mach-orion5x/pci.c | 14 ++ > > drivers/bus/mvebu-mbus.c | 26 ++- > > drivers/pci/controller/Kconfig | 4 +- > > drivers/pci/controller/pci-mvebu.c | 202 ++++++++++++++---- > > include/linux/mbus.h | 1 + > > 8 files changed, 256 insertions(+), 59 deletions(-) > > > > -- > > 2.20.1 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19FA7C433FE for ; Sun, 6 Nov 2022 23:29:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o98+Om4px5DL2G7W8nPmiluC57rlutY0aG2CBCNfPGo=; b=nRd3MwGnhOqWf/ EEmKIoBLyv58GES6BYB/uTA4ttHnO7i6mgVga/bueoCH0BvK1UFHatFpuJ+5eDIUtoYpfo0MBChdr QTw18TvqMneFOe7GpL8Kby7XJag7jc7qnu/JVSG9VNoy1Lr0c2iOWxcMQLRd1L5ZhbOShQp1samsk gGJhP3lw3avyadWhBOGD5XcBRz8X8XXaNS8KPS4MCwefv2lT5eB2FZ18wsMXb19Y+DHuqr7YVyXD2 udJjuBcmNlzjxyaKdrVu0pvG7KK02klbRyXbq2LmrZK5XDMH1VPeqqBAXVW1XS0YVVLwQuC6IdFIZ fGjhTmYIlQ2xzHIYq7hQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1orp46-00ANpO-Nw; Sun, 06 Nov 2022 23:28:34 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1orp43-00ANoz-OS for linux-arm-kernel@lists.infradead.org; Sun, 06 Nov 2022 23:28:33 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0B534B80D66; Sun, 6 Nov 2022 23:28:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E12FC433D6; Sun, 6 Nov 2022 23:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667777307; bh=3Cd2pgUygkB4hpu5zj8Mcl7NTGFw2u8uR5Ty1Bp3ClQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aFJU8jeYmL8IiEbZgaZyhNW9UdTViNEfDOvsC0oWDH9BVeKXZPcNbJFFf0fgreBJ+ UBd+dlQsh5BiyuBFTgHZCDWRc9igRo36Hyc08+4kXVSs6raLKXFVIY493qY20RZfxd 9FLc4rTF5lds3P4wWqSiLBB/4wuooo0rEMH6R8htn/Y6pu0sgubNg2QqcuTsaVQLAR 90KDqvKIX1Z8ZHkT56T+ZLXJIVZGAzELNPH7o/Fzp5sGz+RazF48gukFGXNpNfiTtN Mx8MZZEvOSXD+jsehkLmNPtMsM+itr+nDHYhEB4J2M/cozviqiNQYvQDXoBxDj+e5W 0G8RK88EHdYRQ== Received: by pali.im (Postfix) id 9A5F8858; Mon, 7 Nov 2022 00:28:24 +0100 (CET) Date: Mon, 7 Nov 2022 00:28:24 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Lorenzo Pieralisi Cc: Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Russell King , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Thomas Petazzoni , Mauri Sandberg , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/7] PCI: mvebu: add support for orion soc Message-ID: <20221106232824.du4uou6pf77rqu45@pali> References: <20220718202843.6766-1-maukka@ext.kapsi.fi> <20220905192310.22786-1-pali@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221106_152832_133383_08FC72BE X-CRM114-Status: GOOD ( 31.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1cnNkYXkgMjcgT2N0b2JlciAyMDIyIDE2OjEwOjQ4IExvcmVuem8gUGllcmFsaXNpIHdy b3RlOgo+IE9uIE1vbiwgU2VwIDA1LCAyMDIyIGF0IDA5OjIzOjAzUE0gKzAyMDAsIFBhbGkgUm9o w6FyIHdyb3RlOgo+ID4gSGVsbG8hIFRoaXMgcGF0Y2ggc2VyaWVzIGFkZCBzdXBwb3J0IGZvciBP cmlvbiBQQ0llIGNvbnRyb2xsZXIgaW50bwo+ID4gcGNpLW12ZWJ1LmMgZHJpdmVyLiBWMyB2ZXJz aW9uIGhhcyBjb21wbGV0ZWx5IHJld3JpdHRlbiBwY2ktbXZlYnUuYyBjb2RlCj4gPiB0byBwYXJz ZSBhbGwgcGh5c2ljYWwgYWRkcmVzc2VzIGZyb20gZGV2aWNlIHRyZWUgZmlsZXMgYWNjb3JkaW5n IHRvCj4gPiBtdmVidS1wY2kudHh0IGRvY3VtZW50YXRpb24sIGFsbG93IGFjY2VzcyB0byBhbGwg ZXh0ZW5kZWQgUENJZSBjb25maWcKPiA+IHNwYWNlIHJlZ2lzdGVycyBhbmQgdXNlIG1vZGVybiBr ZXJuZWwgQVBJIHBjaV9yZW1hcF9jZmdzcGFjZSgpIGFuZAo+ID4gbXZlYnVfbWJ1c19hZGRfd2lu ZG93X2J5X2lkKCkgZmlyIG1hcHBpbmcgUENJZSBjb25maWcgc3BhY2UuCj4gPiAKPiA+IE1vc3Qg b2YgTWFydmVsbCBkZXZpY2UgdHJlZSBjb2RlIGluIHBjaS1tdmVidS5jIGlzIGdpYW50IG1hZ2lj LCBidXQgaXQgd2FzCj4gPiB0aGVyZSBiZWNhdXNlIHRoaXMgY2hhbmdlIGFuZCBpdCBpcyBkZS1m YWN0byBBUEkgYmV0d2VlbiBkdHMgZmlsZXMgYW5kCj4gPiBrZXJuZWwgdXNlZCBmb3IgYSBsb25n IHRpbWUuIE5vdGUgdGhhdCBpdCBpcyBtaXN1c2VkIGFjY29yZGluZyB0byBQQ0kKPiA+IGRldmlj ZSB0cmVlIGJpbmRpbmdzLCBidXQgd2UgaGF2ZSB0byBmb2xsb3cgdGhpcyBNYXJ2ZWxsIGJpbmRp bmdzIHRvIGRvCj4gPiBub3QgaW50cm9kdWNlIGJhY2t3YXJkIGluY29tcGF0aWJpbGl0eSBpc3N1 ZXMgZm9yIG90aGVyIG5vbi1Pcmlvbgo+ID4gcGxhdGZvcm1zLgo+ID4gCj4gPiBNYXVyaSB0ZXN0 ZWQgdGhlc2UgY2hhbmdlcyBvbiBETlMzMjMgYm9hcmQgd2l0aCBib3RoIERUIGFuZCBub24tRFQg YnVpbGRzLgo+ID4gUENJZSBBRVIgaXMgd29ya2luZyB0b28gKG9uZSBvZiB0aGUgZmVhdHVyZSB3 aGljaCBwcm92ZWQgdGhhdCBhY2Nlc3MgdG8KPiA+IGV4dGVuZGVkIFBDSWUgY29uZmlnIHJlZ2lz dGVycyBpcyB3b3JraW5nIGZpbmUpLgo+ID4gCj4gPiBBZnRlciB0aGlzIHBhdGNoIGlzIGFjY2Vw dGVkIHdlIGFyZSBwbGFubmluZyB0byBsb29rIGF0IGV4aXN0aW5nIE9yaW9uCj4gPiBhcmNoIHNw ZWNpZmljIGNvZGUgYW5kIGNvdmVydCBpdCB0byB1c2UgdGhpcyBuZXcgRFQgYmFzZWQgcGNpLW12 ZWJ1LmMKPiA+IGNvZGUuIExhdGVyIHRoaXMgd291bGQgYWxsb3cgdG8ga2lsbCBhcmNoIHNwZWNp ZmljIE9yaW9uIFBDSWUgY29kZSwKPiA+IHdoaWNoIGlzIGluIGFyY2gvYXJtL3BsYXQtb3Jpb24v cGNpZS5jIGFuZCBwYXJ0cyBhbHNvIGluIGZpbGUKPiA+IGFyY2gvYXJtL21hY2gtb3Jpb241eC9w Y2kuYyAoc2hhcmVkIHdpdGggb2xkLVBDSSBidXMgY29kZSkuCj4gPiAKPiA+IFRoaXMgcGF0Y2gg c2VyaWVzIGRlcGVuZHMgb24gYW5vdGhlciBwYXRjaGVzOgo+ID4gaHR0cHM6Ly9sb3JlLmtlcm5l bC5vcmcvbGludXgtcGNpLzIwMjIwNTI0MTIyODE3LjcxOTktMS1wYWxpQGtlcm5lbC5vcmcvCj4g PiBodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1wY2kvMjAyMjA4MTcyMzAwMzYuODE3LTMt cGFsaUBrZXJuZWwub3JnLwo+IAo+IENhbiB0aGlzIHNlcmllcyBiZSByZWJhc2VkIHBsZWFzZSBv biB0b3Agb2YgdjYuMS1yYzEgc28gdGhhdCB3ZSBjYW4gbWVyZ2UgaXQgPwoKSUlSQyBhYm92ZSB0 d28gZGVwZW5kZW50IHBhdGNoZXMgc3RpbGwgYXBwbGllcyBvbiBtYXN0ZXIgYnJhbmNoIGFuZCB0 aGlzCnBhdGNoIHNlcmllcyBhcHBsaWVzIG9uIGFib3ZlIHR3byBkZXBlbmRlbnQgcGF0Y2hlcy4K Cj4gVGhhbmtzLAo+IExvcmVuem8KPiAKPiA+IE1hdXJpIFNhbmRiZXJnICgyKToKPiA+ICAgYnVz OiBtdmVidS1tYnVzOiBhZGQgY29uZmlndXJhdGlvbiBzcGFjZSBhcGVydHVyZQo+ID4gICBkdC1i aW5kaW5nczogUENJOiBtdmVidTogQWRkIG9yaW9uNXggY29tcGF0aWJsZQo+ID4gCj4gPiBQYWxp IFJvaMOhciAoNSk6Cj4gPiAgIEFSTTogb3Jpb246IE1vdmUgUENJZSBtYnVzIHdpbmRvdyBtYXBw aW5nIGZyb20gb3Jpb241eF9zZXR1cF93aW5zKCkgdG8KPiA+ICAgICBwY2llX3NldHVwKCkKPiA+ ICAgUENJOiBtdmVidTogUmVtb3ZlIHVudXNlZCBidXNuIG1lbWJlcgo+ID4gICBQQ0k6IG12ZWJ1 OiBDbGVhbnVwIGVycm9yIGhhbmRsaW5nIGluIG12ZWJ1X3BjaWVfcHJvYmUoKQo+ID4gICBQQ0k6 IG12ZWJ1OiBBZGQgc3VwcG9ydCBmb3IgT3Jpb24gUENJZSBjb250cm9sbGVyCj4gPiAgIEFSTTog ZHRzOiBvcmlvbjV4OiBBZGQgUENJZSBub2RlCj4gPiAKPiA+ICAuLi4vZGV2aWNldHJlZS9iaW5k aW5ncy9wY2kvbXZlYnUtcGNpLnR4dCAgICAgfCAgIDQgKy0KPiA+ICBhcmNoL2FybS9ib290L2R0 cy9vcmlvbjV4LmR0c2kgICAgICAgICAgICAgICAgfCAgNTEgKysrKysKPiA+ICBhcmNoL2FybS9t YWNoLW9yaW9uNXgvY29tbW9uLmMgICAgICAgICAgICAgICAgfCAgMTMgLS0KPiA+ICBhcmNoL2Fy bS9tYWNoLW9yaW9uNXgvcGNpLmMgICAgICAgICAgICAgICAgICAgfCAgMTQgKysKPiA+ICBkcml2 ZXJzL2J1cy9tdmVidS1tYnVzLmMgICAgICAgICAgICAgICAgICAgICAgfCAgMjYgKystCj4gPiAg ZHJpdmVycy9wY2kvY29udHJvbGxlci9LY29uZmlnICAgICAgICAgICAgICAgIHwgICA0ICstCj4g PiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktbXZlYnUuYyAgICAgICAgICAgIHwgMjAyICsr KysrKysrKysrKysrLS0tLQo+ID4gIGluY2x1ZGUvbGludXgvbWJ1cy5oICAgICAgICAgICAgICAg ICAgICAgICAgICB8ICAgMSArCj4gPiAgOCBmaWxlcyBjaGFuZ2VkLCAyNTYgaW5zZXJ0aW9ucygr KSwgNTkgZGVsZXRpb25zKC0pCj4gPiAKPiA+IC0tIAo+ID4gMi4yMC4xCj4gPiAKPiA+IAo+ID4g X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IGxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cj4gPiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKPiA+IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=