From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EB3DC433FE for ; Mon, 7 Nov 2022 15:52:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232555AbiKGPwr (ORCPT ); Mon, 7 Nov 2022 10:52:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232444AbiKGPwq (ORCPT ); Mon, 7 Nov 2022 10:52:46 -0500 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C470FDD9 for ; Mon, 7 Nov 2022 07:52:44 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 47712E0007; Mon, 7 Nov 2022 15:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1667836363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ChW92xrvfRGeQ1TQkOkts3EAp2uw56WxTOyQ2yBOYxU=; b=pfCSH7XmgV9GCgrC4qdc60s+hCDk/gIhQ6SovYcI+dvzqPXlEo1mTZjOr0iN3uyLIqRo/m 7rynvPpvzXQ5Zu3CL3Yo/qhkP2SkDIDGHf67dBOqIEVTOdeMsj5Yeg/Au31w0e53n0W8JS etyg6irZTWU5flPcnxQwSJqvdt0o358Fh2ArPybYHkYZuJLBUYN3RF92878XTD1ww+lZwd RjgcM1YtpKlhNboNc+Vriq6oWv0bCghW9V3fF4OkTYPw3HWPM2/kEbseb9llMQbhmwddgi I6CCmfFpU5TxW6qGXhwbLeAaoLS7NX7s6hf1VZjcxXl+259rmIkAifqVC7UhCw== Date: Mon, 7 Nov 2022 16:52:38 +0100 From: Miquel Raynal To: Dan Carpenter Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mtd: parsers: tplink_safeloader: fix uninitialized variable bug Message-ID: <20221107165238.17bbc8fe@xps-13> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org Hi Dan, dan.carpenter@oracle.com wrote on Tue, 25 Oct 2022 18:34:24 +0300: > On 64 bit systems, the highest 32 bits of the "offset" variable are > not initialized. Also the existing code is not endian safe (it will > fail on big endian systems). Change the type of "offset" to a u32. >=20 > Fixes: aec4d5f5ffd0 ("mtd: parsers: add TP-Link SafeLoader partitions tab= le parser") > Signed-off-by: Dan Carpenter > --- > drivers/mtd/parsers/tplink_safeloader.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/mtd/parsers/tplink_safeloader.c b/drivers/mtd/parser= s/tplink_safeloader.c > index 23584a477391..f601e7bd8627 100644 > --- a/drivers/mtd/parsers/tplink_safeloader.c > +++ b/drivers/mtd/parsers/tplink_safeloader.c I am sorry but I don't have this file in my tree, what kernel are you using? > @@ -23,8 +23,8 @@ static void *mtd_parser_tplink_safeloader_read_table(st= ruct mtd_info *mtd) > struct safeloader_cmn_header hdr; > struct device_node *np; > size_t bytes_read; > - size_t offset; > size_t size; > + u32 offset; > char *buf; > int err; > =20 > @@ -34,14 +34,14 @@ static void *mtd_parser_tplink_safeloader_read_table(= struct mtd_info *mtd) > else > np =3D of_get_child_by_name(np, "partitions"); > =20 > - if (of_property_read_u32(np, "partitions-table-offset", (u32 *)&offset)= ) { > + if (of_property_read_u32(np, "partitions-table-offset", &offset)) { > pr_err("Failed to get partitions table offset\n"); > goto err_put; > } > =20 > err =3D mtd_read(mtd, offset, sizeof(hdr), &bytes_read, (uint8_t *)&hdr= ); > if (err && !mtd_is_bitflip(err)) { > - pr_err("Failed to read from %s at 0x%zx\n", mtd->name, offset); > + pr_err("Failed to read from %s at 0x%x\n", mtd->name, offset); > goto err_put; > } > =20 Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E067C433FE for ; Mon, 7 Nov 2022 15:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dJi12mwh6mE/3/fyJyk/K+wpASR+UwNucrL06Ad2L4c=; b=KRf1WK18q4nR1Z k8PWGGngEapHK76+BDiLX8KqERWvuiji1yTkDhsL2zHcj//Di65g3O3gr+bsPLsVyKl5RrSG5Pbwo Td45jROt48bhtZSaANcMzVOtn8+m3cdRQvIJZanEcS47E7UZy917a8B+kW3LHXQuWn64axE9FKJeY 3i/J7bMo5X5TcD9SHDrVILbALQwFEtFHeMGtIJzYSYJ+drGJvk3gB1oncnXZtlwSAsMhBaDA19aY5 gkPAtKsyJKQ3ZjrhbuFYOtM6BiGnTxwMEROsJfkuFw94rMR1V88Mh2EHe8fjf0YAbtLQGAM7iIqGB +3MJe+KdbOrgDlcnnUKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1os4Qf-00Fwqz-0I; Mon, 07 Nov 2022 15:52:53 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1os4Qb-00FwlL-1i for linux-mtd@lists.infradead.org; Mon, 07 Nov 2022 15:52:50 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 47712E0007; Mon, 7 Nov 2022 15:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1667836363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ChW92xrvfRGeQ1TQkOkts3EAp2uw56WxTOyQ2yBOYxU=; b=pfCSH7XmgV9GCgrC4qdc60s+hCDk/gIhQ6SovYcI+dvzqPXlEo1mTZjOr0iN3uyLIqRo/m 7rynvPpvzXQ5Zu3CL3Yo/qhkP2SkDIDGHf67dBOqIEVTOdeMsj5Yeg/Au31w0e53n0W8JS etyg6irZTWU5flPcnxQwSJqvdt0o358Fh2ArPybYHkYZuJLBUYN3RF92878XTD1ww+lZwd RjgcM1YtpKlhNboNc+Vriq6oWv0bCghW9V3fF4OkTYPw3HWPM2/kEbseb9llMQbhmwddgi I6CCmfFpU5TxW6qGXhwbLeAaoLS7NX7s6hf1VZjcxXl+259rmIkAifqVC7UhCw== Date: Mon, 7 Nov 2022 16:52:38 +0100 From: Miquel Raynal To: Dan Carpenter Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mtd: parsers: tplink_safeloader: fix uninitialized variable bug Message-ID: <20221107165238.17bbc8fe@xps-13> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221107_075249_241784_C93FCE8D X-CRM114-Status: GOOD ( 18.08 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgRGFuLAoKZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tIHdyb3RlIG9uIFR1ZSwgMjUgT2N0IDIw MjIgMTg6MzQ6MjQgKzAzMDA6Cgo+IE9uIDY0IGJpdCBzeXN0ZW1zLCB0aGUgaGlnaGVzdCAzMiBi aXRzIG9mIHRoZSAib2Zmc2V0IiB2YXJpYWJsZSBhcmUKPiBub3QgaW5pdGlhbGl6ZWQuICBBbHNv IHRoZSBleGlzdGluZyBjb2RlIGlzIG5vdCBlbmRpYW4gc2FmZSAoaXQgd2lsbAo+IGZhaWwgb24g YmlnIGVuZGlhbiBzeXN0ZW1zKS4gIENoYW5nZSB0aGUgdHlwZSBvZiAib2Zmc2V0IiB0byBhIHUz Mi4KPiAKPiBGaXhlczogYWVjNGQ1ZjVmZmQwICgibXRkOiBwYXJzZXJzOiBhZGQgVFAtTGluayBT YWZlTG9hZGVyIHBhcnRpdGlvbnMgdGFibGUgcGFyc2VyIikKPiBTaWduZWQtb2ZmLWJ5OiBEYW4g Q2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvbXRk L3BhcnNlcnMvdHBsaW5rX3NhZmVsb2FkZXIuYyB8IDYgKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvbXRkL3BhcnNlcnMvdHBsaW5rX3NhZmVsb2FkZXIuYyBiL2RyaXZlcnMvbXRkL3BhcnNlcnMv dHBsaW5rX3NhZmVsb2FkZXIuYwo+IGluZGV4IDIzNTg0YTQ3NzM5MS4uZjYwMWU3YmQ4NjI3IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRkL3BhcnNlcnMvdHBsaW5rX3NhZmVsb2FkZXIuYwo+ICsr KyBiL2RyaXZlcnMvbXRkL3BhcnNlcnMvdHBsaW5rX3NhZmVsb2FkZXIuYwoKSSBhbSBzb3JyeSBi dXQgSSBkb24ndCBoYXZlIHRoaXMgZmlsZSBpbiBteSB0cmVlLCB3aGF0IGtlcm5lbCBhcmUgeW91 CnVzaW5nPwoKPiBAQCAtMjMsOCArMjMsOCBAQCBzdGF0aWMgdm9pZCAqbXRkX3BhcnNlcl90cGxp bmtfc2FmZWxvYWRlcl9yZWFkX3RhYmxlKHN0cnVjdCBtdGRfaW5mbyAqbXRkKQo+ICAJc3RydWN0 IHNhZmVsb2FkZXJfY21uX2hlYWRlciBoZHI7Cj4gIAlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wOwo+ ICAJc2l6ZV90IGJ5dGVzX3JlYWQ7Cj4gLQlzaXplX3Qgb2Zmc2V0Owo+ICAJc2l6ZV90IHNpemU7 Cj4gKwl1MzIgb2Zmc2V0Owo+ICAJY2hhciAqYnVmOwo+ICAJaW50IGVycjsKPiAgCj4gQEAgLTM0 LDE0ICszNCwxNCBAQCBzdGF0aWMgdm9pZCAqbXRkX3BhcnNlcl90cGxpbmtfc2FmZWxvYWRlcl9y ZWFkX3RhYmxlKHN0cnVjdCBtdGRfaW5mbyAqbXRkKQo+ICAJZWxzZQo+ICAJCW5wID0gb2ZfZ2V0 X2NoaWxkX2J5X25hbWUobnAsICJwYXJ0aXRpb25zIik7Cj4gIAo+IC0JaWYgKG9mX3Byb3BlcnR5 X3JlYWRfdTMyKG5wLCAicGFydGl0aW9ucy10YWJsZS1vZmZzZXQiLCAodTMyICopJm9mZnNldCkp IHsKPiArCWlmIChvZl9wcm9wZXJ0eV9yZWFkX3UzMihucCwgInBhcnRpdGlvbnMtdGFibGUtb2Zm c2V0IiwgJm9mZnNldCkpIHsKPiAgCQlwcl9lcnIoIkZhaWxlZCB0byBnZXQgcGFydGl0aW9ucyB0 YWJsZSBvZmZzZXRcbiIpOwo+ICAJCWdvdG8gZXJyX3B1dDsKPiAgCX0KPiAgCj4gIAllcnIgPSBt dGRfcmVhZChtdGQsIG9mZnNldCwgc2l6ZW9mKGhkciksICZieXRlc19yZWFkLCAodWludDhfdCAq KSZoZHIpOwo+ICAJaWYgKGVyciAmJiAhbXRkX2lzX2JpdGZsaXAoZXJyKSkgewo+IC0JCXByX2Vy cigiRmFpbGVkIHRvIHJlYWQgZnJvbSAlcyBhdCAweCV6eFxuIiwgbXRkLT5uYW1lLCBvZmZzZXQp Owo+ICsJCXByX2VycigiRmFpbGVkIHRvIHJlYWQgZnJvbSAlcyBhdCAweCV4XG4iLCBtdGQtPm5h bWUsIG9mZnNldCk7Cj4gIAkJZ290byBlcnJfcHV0Owo+ICAJfQo+ICAKCgpUaGFua3MsCk1pcXXD qGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg==