From: Uday Shankar <ushankar@purestorage.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@fb.com>
Subject: Re: [PATCH] nvme: scan sequentially only when list scan unsupported
Date: Mon, 7 Nov 2022 12:29:16 -0700 [thread overview]
Message-ID: <20221107192916.GA2075022@dev-ushankar.dev.purestorage.com> (raw)
In-Reply-To: <20221107055605.GF28873@lst.de>
On Mon, Nov 07, 2022 at 06:56:05AM +0100, Christoph Hellwig wrote:
> Maybe make this a bit more clear by lifting the nvme_ctrl_limited_cns
> check into nvme_scan_work, though:
>
> if (nvme_ctrl_limited_cns(ctrl))
> nvme_scan_ns_sequential(ctrl);
> else
> nvme_scan_ns_list(ctrl);
>
> and drop the now superflous error return from nvme_scan_ns_list.
Sure. I will resubmit with that revision.
prev parent reply other threads:[~2022-11-07 19:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 22:36 [PATCH] nvme: scan sequentially only when list scan unsupported Uday Shankar
2022-11-04 22:46 ` Uday Shankar
2022-11-07 5:56 ` Christoph Hellwig
2022-11-07 19:29 ` Uday Shankar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107192916.GA2075022@dev-ushankar.dev.purestorage.com \
--to=ushankar@purestorage.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.