From: Roger Quadros <rogerq@kernel.org>
To: davem@davemloft.net
Cc: edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
vigneshr@ti.com, srk@ti.com, linux-omap@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Roger Quadros <rogerq@kernel.org>
Subject: [PATCH] net: ethernet: ti: cpsw_ale: optimize cpsw_ale_restore()
Date: Tue, 8 Nov 2022 15:56:43 +0200 [thread overview]
Message-ID: <20221108135643.15094-1-rogerq@kernel.org> (raw)
If an entry was FREE then we don't have to restore it.
Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
Patch depends on
https://lore.kernel.org/netdev/20221104132310.31577-3-rogerq@kernel.org/T/
drivers/net/ethernet/ti/cpsw_ale.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw_ale.c b/drivers/net/ethernet/ti/cpsw_ale.c
index 0c5e783e574c..41bcf34a22f8 100644
--- a/drivers/net/ethernet/ti/cpsw_ale.c
+++ b/drivers/net/ethernet/ti/cpsw_ale.c
@@ -1452,12 +1452,15 @@ void cpsw_ale_dump(struct cpsw_ale *ale, u32 *data)
}
}
+/* ALE table should be cleared (ALE_CLEAR) before cpsw_ale_restore() */
void cpsw_ale_restore(struct cpsw_ale *ale, u32 *data)
{
- int i;
+ int i, type;
for (i = 0; i < ale->params.ale_entries; i++) {
- cpsw_ale_write(ale, i, data);
+ type = cpsw_ale_get_entry_type(data);
+ if (type != ALE_TYPE_FREE)
+ cpsw_ale_write(ale, i, data);
data += ALE_ENTRY_WORDS;
}
}
--
2.17.1
next reply other threads:[~2022-11-08 13:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 13:56 Roger Quadros [this message]
2022-11-10 3:19 ` [PATCH] net: ethernet: ti: cpsw_ale: optimize cpsw_ale_restore() Jakub Kicinski
2022-11-10 9:39 ` Roger Quadros
2022-11-10 20:32 ` Jakub Kicinski
2022-11-11 10:25 ` Roger Quadros
2022-11-11 12:03 ` Vladimir Oltean
2022-11-11 13:35 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221108135643.15094-1-rogerq@kernel.org \
--to=rogerq@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.