From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45BD8C433FE for ; Tue, 8 Nov 2022 15:21:40 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D20FB84F72; Tue, 8 Nov 2022 16:21:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="q9AHYwCL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 93BCC84FD4; Tue, 8 Nov 2022 16:21:36 +0100 (CET) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B97D480714 for ; Tue, 8 Nov 2022 16:21:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id a27so8803955qtw.10 for ; Tue, 08 Nov 2022 07:21:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UQEmHVivShx9y+bryjBlRlCmQgfTH6UA6aLCVE07FcQ=; b=q9AHYwCLWYIy87YdMWIIhfL1EbpxH2k6+6MBld+W+3xKgCt1EbdL/agl4Sn3C3LLWG w+RC0Ui2kyu2aRb6sc56ffzxe4FQsvzPVUrKk0HhsoofaCyXV5pI/oNrfVgdeBH8yCD9 1LM/LeLnaAs+pU++qvtZq7qZtvkh3IDiFQAII= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UQEmHVivShx9y+bryjBlRlCmQgfTH6UA6aLCVE07FcQ=; b=v89i4wz2Y5pcqMgvLSSrMFb8UxsQ7JZzYpWbwrkrv0xRVz4JsuB6hcBTxBeiTveuam jiosHJEq/Bt7msa8fRzSyvOsWrXZvsUbp/jC4ibHUBR3CeN4Tqi5PLlDkP+4tsZ7HfFs C4h40ihbRCt6m42/wfLm8Z5u+CacorwAQFkn8ZnrrfovT1T5fWm0O+srvcqtQ+8F+2ic /j2ng9d78V9LFtBhBe1L4TXL66ISWWr6wudYUPEGAvE3HDFKWC7+zRQYUjS4tbrAbS67 xBqUn6X+3AkZl0EBdcNKsbShYD+d5ZXDPcJ8xSkg3Kg45EYF5Xgi/Arg3QUUQONpIrnE X+sQ== X-Gm-Message-State: ANoB5pmaLMvy0/sZTi5N57in4CEza/bjGxwNZMara3MBspDZlxRbHMWO oolCO/zCSZx+HSZucFQCJ0GxTA== X-Google-Smtp-Source: AA0mqf4NdzycYyXhLI2pJU6nxMiYdBsPFAOLcHRR/4uWaOgqRCVExdycr+gxS99GQT/nd1ucwGRY9A== X-Received: by 2002:ac8:73c8:0:b0:3a5:82aa:fcaf with SMTP id v8-20020ac873c8000000b003a582aafcafmr11228127qtp.561.1667920892539; Tue, 08 Nov 2022 07:21:32 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-7449-d20d-0f21-ae04.res6.spectrum.com. [2603:6081:7b00:6400:7449:d20d:f21:ae04]) by smtp.gmail.com with ESMTPSA id bn5-20020a05620a2ac500b006eee3a09ff3sm9243806qkb.69.2022.11.08.07.21.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 07:21:32 -0800 (PST) Date: Tue, 8 Nov 2022 10:21:29 -0500 From: Tom Rini To: Simon Glass Cc: Patrick DELAUNAY , Francis Laniel , u-boot@lists.denx.de, Michael Nazzareno Trimarchi , Aleksandar Gerasimovski , Holger Brunck , Masahisa Kojima , Heinrich Schuchardt , Philippe Reynes , Ovidiu Panait , Ashok Reddy Soma , Thomas Huth , Artem Lapkin Subject: Re: [RFC PATCH v5 09/24] cli: Add menu for hush parser Message-ID: <20221108152129.GR6335@bill-the-cat> References: <20221101192029.10231-1-francis.laniel@amarulasolutions.com> <20221101192029.10231-10-francis.laniel@amarulasolutions.com> <3282557a-4b90-8b6b-5b60-fa7e1164aee3@foss.st.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OOq1TgGhe8eTwFBO" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --OOq1TgGhe8eTwFBO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 07, 2022 at 08:28:42AM -0700, Simon Glass wrote: > Hi Patrick, >=20 > On Mon, 7 Nov 2022 at 05:32, Patrick DELAUNAY > wrote: > > > > Hi, > > > > On 11/1/22 20:20, Francis Laniel wrote: > > > For the moment, the menu contains only entry: HUSH_OLD_PARSER which i= s the > > > default. > > > The goal is to prepare the field to add a new hush parser which guara= ntees > > > actual behavior is still correct. > > > > > > Signed-off-by: Francis Laniel > > > --- > > > cmd/Kconfig | 21 +++++++++++++++++++++ > > > common/Makefile | 3 ++- > > > 2 files changed, 23 insertions(+), 1 deletion(-) > > > > > > diff --git a/cmd/Kconfig b/cmd/Kconfig > > > index 3f6bc70d43..c15d7c51f7 100644 > > > --- a/cmd/Kconfig > > > +++ b/cmd/Kconfig > > > @@ -23,6 +23,27 @@ config HUSH_PARSER > > > If disabled, you get the old, much simpler behaviour with a s= omewhat > > > smaller memory footprint. > > > > > > +menu "Hush flavor to use" > > > + depends on HUSH_PARSER > > > + > > > + config HUSH_OLD_PARSER > > > + bool "Use hush old parser" > > > + default y > > > + help > > > + This option enables the old flavor of hush based on h= ush Busybox from > > > + 2005. > > > + > > > + It is actually the default U-Boot shell when decided = to use hush as shell. > > > + > > > + config HUSH_2021_PARSER > > > + bool "Use hush 2021 parser" > > > + help > > > + This option enables the new flavor of hush based on h= ush Busybox from > > > + 2021. > > > + > > > + For the moment, it is highly experimental and should = be used at own risks. > > > +endmenu > > > + > > > > > > I think "choice" can be made sense here > > > > =3D> only one version is used > > > > > > choice > > prompt "Hush flavor to use" > > default HUSH_OLD_PARSER > > > > depends on HUSH_PARSER > > > > > > config HUSH_OLD_PARSER > > > > bool "Use hush old parser" > > > > config HUSH_2021_PARSER > > > > bool "Use hush 2021 parser" > > > > endchoice >=20 > We need to be able to build both and then select the correct one at > runtime, at least for sandbox. Otherwise we would need yet another > sandbox build. So I think what we have here makes sense. I think choice is fine, as that's for testing. Once we're ready to merge this we'll not keep both around for long. --=20 Tom --OOq1TgGhe8eTwFBO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNqc/kACgkQFHw5/5Y0 tywpuwv+Iscz8emqneprkmmYG0ggQPLb3cohwX4yn6cKdGyhMqVuYUlyn4RvgUC7 cYrmi3Sn9i+LU9H9JUdRBu0ZWj24kuycz+Zj0wsJ/B9HVQbhLTl51L6dSUSGx6Pd xJZs31SANx+g27mp7PDaFZqsCKa3Ig7Y8M/Qhrh4tWaGWTRFqBHZMeoOulb5BwCd S1HlmoZVZSQFgEDM+c+nVBEpodHA8qMF9pr6Zl+Dtii4xqIzILyWYk3umfnggF8N 0qBLKzBOHAwg7+boJLuYA38MKegkk9q0F7FlW8o89UlFkGrmAx0J/R0FquDaE5T1 sfa8bmyYudyLra+aK76sG1gK020r4hwlnTthDxR0V4VPKm7KtxKDNLsd1XdRBzBM WjKIkYbQDsgfzAjShKDuvGXxw6cQMylHVisqrRO/niOQJtkiqR7/pu4sDEGOpt7K DDypUZ7RSd8qCZRX5UM1USZOE3HnsW7oJ4Oj7cs23wX9oDRTFWkAnf16chZNE+rF EUZRtGuX =KPL6 -----END PGP SIGNATURE----- --OOq1TgGhe8eTwFBO--