From: Jakub Kicinski <kuba@kernel.org>
To: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Looi Hong Aun <hong.aun.looi@intel.com>,
Voon Weifeng <weifeng.voon@intel.com>,
Tan Tee Min <tee.min.tan@intel.com>,
Zulkifli Muhammad Husaini <muhammad.husaini.zulkifli@intel.com>,
Gan Yi Fang <yi.fang.gan@intel.com>
Subject: Re: [PATCH net 1/1] net: phy: dp83867: Fix SGMII FIFO depth for non OF devices
Date: Tue, 8 Nov 2022 17:55:31 -0800 [thread overview]
Message-ID: <20221108175531.1a7c16a6@kernel.org> (raw)
In-Reply-To: <20221108101218.612499-1-michael.wei.hong.sit@intel.com>
On Tue, 8 Nov 2022 18:12:18 +0800 Michael Sit Wei Hong wrote:
> Current driver code will read device tree node information,
> and set default values if there is no info provided.
>
> This is not done in non-OF devices leading to SGMII fifo depths being
> set to the smallest size.
>
> This patch sets the value to the default value of the PHY as stated in the
> PHY datasheet.
We need a Fixes tag, which commit should have contained this code?
next prev parent reply other threads:[~2022-11-09 1:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 10:12 [PATCH net 1/1] net: phy: dp83867: Fix SGMII FIFO depth for non OF devices Michael Sit Wei Hong
2022-11-08 20:43 ` Andrew Lunn
2022-11-09 1:55 ` Jakub Kicinski [this message]
2022-11-09 2:18 ` Sit, Michael Wei Hong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221108175531.1a7c16a6@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=hong.aun.looi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael.wei.hong.sit@intel.com \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tee.min.tan@intel.com \
--cc=weifeng.voon@intel.com \
--cc=yi.fang.gan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.