From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Hannes Reinecke <hare@suse.de>, Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Subject: Re: [PATCH 07/16] nvme-auth: remove redundant if statement
Date: Wed, 9 Nov 2022 07:37:57 +0100 [thread overview]
Message-ID: <20221109063757.GA10893@lst.de> (raw)
In-Reply-To: <20221109034420.1000086-8-sagi@grimberg.me>
On Wed, Nov 09, 2022 at 05:44:10AM +0200, Sagi Grimberg wrote:
> diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c
> index a6312a8846f8..07d497f49e4b 100644
> --- a/drivers/nvme/host/auth.c
> +++ b/drivers/nvme/host/auth.c
> @@ -874,7 +874,7 @@ int nvme_auth_negotiate(struct nvme_ctrl *ctrl, int qid)
> mutex_unlock(&ctrl->dhchap_auth_mutex);
> return -ENOMEM;
> }
> - chap->qid = (qid == NVME_QID_ANY) ? 0 : qid;
> + chap->qid = qid;
Btw, the same "transformation" can also be removed in nvme_auth_submit.
next prev parent reply other threads:[~2022-11-09 6:38 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 3:44 [PATCH 00/16] nvme: rework dhchap authentication host code Sagi Grimberg
2022-11-09 3:44 ` [PATCH 01/16] nvme-auth: rename __nvme_auth_[reset|free] to nvme_auth[reset|free]_dhchap Sagi Grimberg
2022-11-09 17:35 ` Hannes Reinecke
2022-11-09 3:44 ` [PATCH 02/16] nvme-auth: remove symbol export from nvme_auth_reset Sagi Grimberg
2022-11-09 7:30 ` Hannes Reinecke
2022-11-09 3:44 ` [PATCH 03/16] nvme-auth: don't re-authenticate if the controller is not LIVE Sagi Grimberg
2022-11-09 7:33 ` Hannes Reinecke
2022-11-09 19:00 ` Sagi Grimberg
2022-11-09 3:44 ` [PATCH 04/16] nvme-auth: remove redundant buffer deallocations Sagi Grimberg
2022-11-09 17:36 ` Hannes Reinecke
2022-11-09 3:44 ` [PATCH 05/16] nvme-auth: don't ignore key generation failures when initializing ctrl keys Sagi Grimberg
2022-11-09 7:33 ` Hannes Reinecke
2022-11-09 3:44 ` [PATCH 06/16] nvme-auth: don't override ctrl keys before validation Sagi Grimberg
2022-11-09 7:34 ` Hannes Reinecke
2022-11-09 3:44 ` [PATCH 07/16] nvme-auth: remove redundant if statement Sagi Grimberg
2022-11-09 6:37 ` Christoph Hellwig [this message]
2022-11-09 18:42 ` Sagi Grimberg
2022-11-09 7:34 ` Hannes Reinecke
2022-11-09 3:44 ` [PATCH 08/16] nvme-auth: don't keep long lived 4k dhchap buffer Sagi Grimberg
2022-11-09 6:39 ` Christoph Hellwig
2022-11-09 18:05 ` Sagi Grimberg
2022-11-09 17:37 ` Hannes Reinecke
2022-11-09 3:44 ` [PATCH 09/16] nvme-auth: clear sensitive info right after authentication completes Sagi Grimberg
2022-11-09 7:35 ` Hannes Reinecke
2022-11-09 3:44 ` [PATCH 10/16] nvme-auth: remove redundant deallocations Sagi Grimberg
2022-11-09 3:44 ` [PATCH 11/16] nvme-auth: no need to reset chap contexts on re-authentication Sagi Grimberg
2022-11-09 7:36 ` Hannes Reinecke
2022-11-09 3:44 ` [PATCH 12/16] nvme-auth: convert dhchap_auth_list to an array Sagi Grimberg
2022-11-09 6:48 ` Christoph Hellwig
2022-11-09 19:06 ` Sagi Grimberg
2022-11-09 17:40 ` Hannes Reinecke
2022-11-09 19:05 ` Sagi Grimberg
2022-11-09 3:44 ` [PATCH 13/16] nvme-auth: remove redundant auth_work flush Sagi Grimberg
2022-11-09 17:41 ` Hannes Reinecke
2022-11-09 3:44 ` [PATCH 14/16] nvme-auth: have dhchap_auth_work wait for queues auth to complete Sagi Grimberg
2022-11-09 7:44 ` Hannes Reinecke
2022-11-09 19:01 ` Sagi Grimberg
2022-11-09 3:44 ` [PATCH 15/16] nvme-tcp: stop auth work after tearing down queues in error recovery Sagi Grimberg
2022-11-09 3:44 ` [PATCH 16/16] nvme-rdma: " Sagi Grimberg
2022-11-09 3:44 ` [PATCH 17/16 blktests] nvme: add re-authentication running concurrently with reset Sagi Grimberg
2022-11-09 3:47 ` [PATCH 00/16] nvme: rework dhchap authentication host code Sagi Grimberg
2022-11-09 7:45 ` Hannes Reinecke
2022-11-09 17:42 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109063757.GA10893@lst.de \
--to=hch@lst.de \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.