From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66E06C4332F for ; Wed, 9 Nov 2022 12:45:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230093AbiKIMpe (ORCPT ); Wed, 9 Nov 2022 07:45:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229615AbiKIMpe (ORCPT ); Wed, 9 Nov 2022 07:45:34 -0500 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EE20220C3; Wed, 9 Nov 2022 04:45:32 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 547C91BF207; Wed, 9 Nov 2022 12:45:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1667997930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CP5HR4/fW62hCUEuUWY+rJW5C3z5hPsLxg/D74tYsWg=; b=IQaY+i8KKGP7I+eJmahCk+nqdTj3vEIF7eoLt1ZRFZKkeRIwcVnF3JnaYCeSduXrh/bn6K w4UJf6oLc0ToqR/TsdchrX3M87LJsUqeVpdoxX/b79NlYnEFeN6ylERltWBiWFq4sbUpak H8DsZA7e/bBadHXaNogTXrMlnkYbI8auXlcKSTclxaGcbzlpqA3kbgP1jk6OFS2sF/+Ruw RyGNOg3Xhy3LmartbIq7ojm3aDQo3BOkBLEqXSSASDpJRMM27TPM17VWxqDgSEr/5bJsXa qvpXB2QjMXjsCSARHkY6FP5r6BgvzSrjHtzsSefQRXiFwqY2zMeUNO6XAQCfSQ== Date: Wed, 9 Nov 2022 13:45:26 +0100 From: Miquel Raynal To: Daniel Golle Cc: Jens Axboe , Richard Weinberger , Vignesh Raghavendra , Davidlohr Bueso , Matthew Wilcox , "Martin K. Petersen" , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-efi@vger.kernel.org Subject: Re: [PATCH v4 4/5] mtd_blkdevs: add option to enable scanning for partitions Message-ID: <20221109134526.158047e1@xps-13> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hi Daniel, daniel@makrotopia.org wrote on Tue, 8 Nov 2022 23:04:13 +0000: > Add Kconfig boolean CONFIG_MTD_BLOCK_PARTITIONS and enable block > partition parsers on non-NAND mtdblock devices in case it is selected. >=20 > Signed-off-by: Daniel Golle > Acked-by: Miquel Raynal > --- > drivers/mtd/Kconfig | 11 +++++++++++ > drivers/mtd/mtd_blkdevs.c | 4 +++- > 2 files changed, 14 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig > index 796a2eccbef0..12874dec1569 100644 > --- a/drivers/mtd/Kconfig > +++ b/drivers/mtd/Kconfig > @@ -69,6 +69,17 @@ config MTD_BLOCK_RO > You do not need this option for use with the DiskOnChip devices. For > those, enable NFTL support (CONFIG_NFTL) instead. > =20 > +config MTD_BLOCK_PARTITIONS > + bool "Scan for partitions on MTD block devices" > + depends on MTD_BLOCK || MTD_BLOCK_RO > + default y if FIT_PARTITION > + help > + Scan MTD block devices for partitions (ie. MBR, GPT, uImage.FIT, ...). > + (NAND devices are omitted, ubiblock should be used instead when) > + > + Unless your MTD partitions contain sub-partitions mapped using a > + partition table, say no. Actually I know I've acked this patch in the past but I am now wondering again if this is the right way so I would like to discuss this again. I don't feel making partitions on top of blk devices like that is the right solution. Why not using the advanced partition parsers that we now have in MTD to create these subpartitions and then have blocks emulated on top of them? > + > comment "Note that in some cases UBI block is preferred. See MTD_UBI_BLO= CK." > depends on MTD_BLOCK || MTD_BLOCK_RO > =20 > diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c > index 60b222799871..e6f2e0888246 100644 > --- a/drivers/mtd/mtd_blkdevs.c > +++ b/drivers/mtd/mtd_blkdevs.c > @@ -359,7 +359,9 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new) > } else { > snprintf(gd->disk_name, sizeof(gd->disk_name), > "%s%d", tr->name, new->devnum); > - gd->flags |=3D GENHD_FL_NO_PART; > + > + if (!IS_ENABLED(CONFIG_MTD_BLOCK_PARTITIONS) || mtd_type_is_nand(new->= mtd)) > + gd->flags |=3D GENHD_FL_NO_PART; > } > =20 > set_capacity(gd, ((u64)new->size * tr->blksize) >> 9); Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8580FC4332F for ; Wed, 9 Nov 2022 12:45:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ibq2vlwHFr6jm6utqBF4ThWyRFQlCU//vJFDyL818ZI=; b=etEzNCWDglnQP+ 3g94IvvQheHnE6OFt8syUxz+4bL8lyZ1mluNnT2L3NNDIX0e+GFEX/3p/E24OWU1Q9r3TpsIbp6cK qEuEfP/LhaOdv15f3asJaX7ijcCeLrZtPwXNNDNO8vcI/VvUMHqan6Z9GnmdJVjrWPDFGJWvr9gll 9ZybLwyb9iIrwUIr6AYZFtImx/2F+uSU/fivqsfwIL/q8SgVlocKLwTTYWdubETybbOB1Tqk/ON9u KSVrRA5sNj9kvcZeA6yUC4pqGC/XdI5/rOSRPTiWv4Z+etoFyaONyXFMjBtOGySeC5+EE3B2sstyC 2ABVOcmPR1gp7TrPdTpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oskSd-00DTZ8-4N; Wed, 09 Nov 2022 12:45:43 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oskSZ-00DTUD-OR for linux-mtd@lists.infradead.org; Wed, 09 Nov 2022 12:45:42 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 547C91BF207; Wed, 9 Nov 2022 12:45:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1667997930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CP5HR4/fW62hCUEuUWY+rJW5C3z5hPsLxg/D74tYsWg=; b=IQaY+i8KKGP7I+eJmahCk+nqdTj3vEIF7eoLt1ZRFZKkeRIwcVnF3JnaYCeSduXrh/bn6K w4UJf6oLc0ToqR/TsdchrX3M87LJsUqeVpdoxX/b79NlYnEFeN6ylERltWBiWFq4sbUpak H8DsZA7e/bBadHXaNogTXrMlnkYbI8auXlcKSTclxaGcbzlpqA3kbgP1jk6OFS2sF/+Ruw RyGNOg3Xhy3LmartbIq7ojm3aDQo3BOkBLEqXSSASDpJRMM27TPM17VWxqDgSEr/5bJsXa qvpXB2QjMXjsCSARHkY6FP5r6BgvzSrjHtzsSefQRXiFwqY2zMeUNO6XAQCfSQ== Date: Wed, 9 Nov 2022 13:45:26 +0100 From: Miquel Raynal To: Daniel Golle Cc: Jens Axboe , Richard Weinberger , Vignesh Raghavendra , Davidlohr Bueso , Matthew Wilcox , "Martin K. Petersen" , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-efi@vger.kernel.org Subject: Re: [PATCH v4 4/5] mtd_blkdevs: add option to enable scanning for partitions Message-ID: <20221109134526.158047e1@xps-13> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221109_044540_077663_9CFFC8FB X-CRM114-Status: GOOD ( 23.12 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgRGFuaWVsLAoKZGFuaWVsQG1ha3JvdG9waWEub3JnIHdyb3RlIG9uIFR1ZSwgOCBOb3YgMjAy MiAyMzowNDoxMyArMDAwMDoKCj4gQWRkIEtjb25maWcgYm9vbGVhbiBDT05GSUdfTVREX0JMT0NL X1BBUlRJVElPTlMgYW5kIGVuYWJsZSBibG9jawo+IHBhcnRpdGlvbiBwYXJzZXJzIG9uIG5vbi1O QU5EIG10ZGJsb2NrIGRldmljZXMgaW4gY2FzZSBpdCBpcyBzZWxlY3RlZC4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBEYW5pZWwgR29sbGUgPGRhbmllbEBtYWtyb3RvcGlhLm9yZz4KPiBBY2tlZC1ieTog TWlxdWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4KPiAtLS0KPiAgZHJpdmVy cy9tdGQvS2NvbmZpZyAgICAgICB8IDExICsrKysrKysrKysrCj4gIGRyaXZlcnMvbXRkL210ZF9i bGtkZXZzLmMgfCAgNCArKystCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9LY29uZmlnIGIvZHJp dmVycy9tdGQvS2NvbmZpZwo+IGluZGV4IDc5NmEyZWNjYmVmMC4uMTI4NzRkZWMxNTY5IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvbXRkL0tjb25maWcKPiArKysgYi9kcml2ZXJzL210ZC9LY29uZmln Cj4gQEAgLTY5LDYgKzY5LDE3IEBAIGNvbmZpZyBNVERfQkxPQ0tfUk8KPiAgCSAgWW91IGRvIG5v dCBuZWVkIHRoaXMgb3B0aW9uIGZvciB1c2Ugd2l0aCB0aGUgRGlza09uQ2hpcCBkZXZpY2VzLiBG b3IKPiAgCSAgdGhvc2UsIGVuYWJsZSBORlRMIHN1cHBvcnQgKENPTkZJR19ORlRMKSBpbnN0ZWFk Lgo+ICAKPiArY29uZmlnIE1URF9CTE9DS19QQVJUSVRJT05TCj4gKwlib29sICJTY2FuIGZvciBw YXJ0aXRpb25zIG9uIE1URCBibG9jayBkZXZpY2VzIgo+ICsJZGVwZW5kcyBvbiBNVERfQkxPQ0sg fHwgTVREX0JMT0NLX1JPCj4gKwlkZWZhdWx0IHkgaWYgRklUX1BBUlRJVElPTgo+ICsJaGVscAo+ ICsJICBTY2FuIE1URCBibG9jayBkZXZpY2VzIGZvciBwYXJ0aXRpb25zIChpZS4gTUJSLCBHUFQs IHVJbWFnZS5GSVQsIC4uLikuCj4gKwkgIChOQU5EIGRldmljZXMgYXJlIG9taXR0ZWQsIHViaWJs b2NrIHNob3VsZCBiZSB1c2VkIGluc3RlYWQgd2hlbikKPiArCj4gKwkgIFVubGVzcyB5b3VyIE1U RCBwYXJ0aXRpb25zIGNvbnRhaW4gc3ViLXBhcnRpdGlvbnMgbWFwcGVkIHVzaW5nIGEKPiArCSAg cGFydGl0aW9uIHRhYmxlLCBzYXkgbm8uCgpBY3R1YWxseSBJIGtub3cgSSd2ZSBhY2tlZCB0aGlz IHBhdGNoIGluIHRoZSBwYXN0IGJ1dCBJIGFtIG5vdwp3b25kZXJpbmcgYWdhaW4gaWYgdGhpcyBp cyB0aGUgcmlnaHQgd2F5IHNvIEkgd291bGQgbGlrZSB0byBkaXNjdXNzCnRoaXMgYWdhaW4uIEkg ZG9uJ3QgZmVlbCBtYWtpbmcgcGFydGl0aW9ucyBvbiB0b3Agb2YgYmxrIGRldmljZXMgbGlrZQp0 aGF0IGlzIHRoZSByaWdodCBzb2x1dGlvbi4gV2h5IG5vdCB1c2luZyB0aGUgYWR2YW5jZWQgcGFy dGl0aW9uCnBhcnNlcnMgdGhhdCB3ZSBub3cgaGF2ZSBpbiBNVEQgdG8gY3JlYXRlIHRoZXNlIHN1 YnBhcnRpdGlvbnMgYW5kIHRoZW4KaGF2ZSBibG9ja3MgZW11bGF0ZWQgb24gdG9wIG9mIHRoZW0/ Cgo+ICsKPiAgY29tbWVudCAiTm90ZSB0aGF0IGluIHNvbWUgY2FzZXMgVUJJIGJsb2NrIGlzIHBy ZWZlcnJlZC4gU2VlIE1URF9VQklfQkxPQ0suIgo+ICAJZGVwZW5kcyBvbiBNVERfQkxPQ0sgfHwg TVREX0JMT0NLX1JPCj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9tdGRfYmxrZGV2cy5j IGIvZHJpdmVycy9tdGQvbXRkX2Jsa2RldnMuYwo+IGluZGV4IDYwYjIyMjc5OTg3MS4uZTZmMmUw ODg4MjQ2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRkL210ZF9ibGtkZXZzLmMKPiArKysgYi9k cml2ZXJzL210ZC9tdGRfYmxrZGV2cy5jCj4gQEAgLTM1OSw3ICszNTksOSBAQCBpbnQgYWRkX210 ZF9ibGt0cmFuc19kZXYoc3RydWN0IG10ZF9ibGt0cmFuc19kZXYgKm5ldykKPiAgCX0gZWxzZSB7 Cj4gIAkJc25wcmludGYoZ2QtPmRpc2tfbmFtZSwgc2l6ZW9mKGdkLT5kaXNrX25hbWUpLAo+ICAJ CQkgIiVzJWQiLCB0ci0+bmFtZSwgbmV3LT5kZXZudW0pOwo+IC0JCWdkLT5mbGFncyB8PSBHRU5I RF9GTF9OT19QQVJUOwo+ICsKPiArCQlpZiAoIUlTX0VOQUJMRUQoQ09ORklHX01URF9CTE9DS19Q QVJUSVRJT05TKSB8fCBtdGRfdHlwZV9pc19uYW5kKG5ldy0+bXRkKSkKPiArCQkJZ2QtPmZsYWdz IHw9IEdFTkhEX0ZMX05PX1BBUlQ7Cj4gIAl9Cj4gIAo+ICAJc2V0X2NhcGFjaXR5KGdkLCAoKHU2 NCluZXctPnNpemUgKiB0ci0+Ymxrc2l6ZSkgPj4gOSk7CgoKVGhhbmtzLApNaXF1w6hsCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgg TVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo=