From: Rob Herring <robh@kernel.org>
To: Dominique Martinet <dominique.martinet@atmark-techno.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Marcel Holtmann <marcel@holtmann.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Johan Hedberg <johan.hedberg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
mizo@atmark-techno.com
Subject: Re: [RFC PATCH 1/2] dt-bindings: net: h4-bluetooth: add new bindings for hci_h4
Date: Wed, 9 Nov 2022 16:00:05 -0600 [thread overview]
Message-ID: <20221109220005.GA2930253-robh@kernel.org> (raw)
In-Reply-To: <Y2tW8EMmhTpCwitM@atmark-techno.com>
On Wed, Nov 09, 2022 at 04:29:52PM +0900, Dominique Martinet wrote:
> Dominique Martinet wrote on Wed, Nov 09, 2022 at 08:54:42AM +0900:
> > This is a pretty terrible design, as the Bluetooth side cannot actually
> > know when the device is ready as the initialization takes place, but
> > that means there really aren't any property to give here
> >
> > (I haven't reproduced during normal boot, but in particular if I run
> > bluetoothd before loading the wifi driver, I need to unbind/bind the
> > serial device from the hci_uart_h4 driver to recover bluetooth...
> > With that in mind it might actually be best to try to coordinate this
> > from userspace with btattach after all, and I'd be happy with that if I
> > didn't have to fight our init system so much, but as things stand having
> > it autoloaded by the kernel is more convenient for us... Which is
> > admitedly a weak reason for you all, feel free to tell me this isn't
> > viable)
Punting the issue to userspace is not a great solution...
> This actually hasn't taken long to bite us: while the driver does work,
> we get error messages early on before the firmware is loaded.
> (In hindsight, I probably should have waited a few days before sending
> this...)
>
>
> My current workaround is to return EPROBE_DEFER until we can find a
> netdev with a known name in the init namespace, but that isn't really
> something I'd consider upstreamable for obvious reasons (interfaces can
> be renamed or moved to different namespaces so this is inherently racy
> and it's just out of place in BT code)
Can't you just try to access the BT h/w in some way and defer when that
fails?
Or perhaps use fw_devlink to create a dependency on the wifi node. I'm
not sure offhand how exactly you do that with a custom property.
Rob
next prev parent reply other threads:[~2022-11-09 22:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 5:55 [RFC PATCH 0/2] Add serdev support for hci h4 Dominique Martinet
2022-11-08 5:55 ` [RFC PATCH 1/2] dt-bindings: net: h4-bluetooth: add new bindings for hci_h4 Dominique Martinet
2022-11-08 7:15 ` Add serdev support for hci h4 bluez.test.bot
2022-11-08 11:37 ` [RFC PATCH 1/2] dt-bindings: net: h4-bluetooth: add new bindings for hci_h4 Krzysztof Kozlowski
2022-11-08 23:54 ` Dominique Martinet
2022-11-09 7:29 ` Dominique Martinet
2022-11-09 22:00 ` Rob Herring [this message]
2022-11-10 7:37 ` Dominique Martinet
2022-11-10 16:27 ` Rob Herring
2022-11-08 12:54 ` Rob Herring
2022-11-08 13:59 ` Rob Herring
2022-11-18 3:50 ` Add serdev support for hci h4 bluez.test.bot
2022-11-18 4:38 ` bluez.test.bot
2022-11-18 5:34 ` bluez.test.bot
2022-11-18 6:34 ` bluez.test.bot
2022-11-18 7:33 ` bluez.test.bot
2022-11-18 8:37 ` bluez.test.bot
2022-11-18 9:31 ` bluez.test.bot
2022-11-08 5:55 ` [RFC PATCH 2/2] bluetooth/hci_h4: add serdev support Dominique Martinet
2022-11-08 20:38 ` Andrew Lunn
2022-11-08 20:58 ` Krzysztof Kozlowski
2022-11-09 9:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109220005.GA2930253-robh@kernel.org \
--to=robh@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dominique.martinet@atmark-techno.com \
--cc=edumazet@google.com \
--cc=johan.hedberg@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mizo@atmark-techno.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.