All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: U-Boot Mailing List <u-boot@lists.denx.de>
Cc: "Tom Rini" <trini@konsulko.com>,
	"Rasmus Villemoes" <rasmus.villemoes@prevas.dk>,
	"Simon Glass" <sjg@chromium.org>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	"Marek Behún" <kabel@kernel.org>,
	"Masahiro Yamada" <yamada.masahiro@socionext.com>,
	"Pali Rohár" <pali@kernel.org>,
	"Quentin Schulz" <quentin.schulz@theobroma-systems.com>
Subject: [PATCH v5 02/16] Makefile: Correct the binman rule
Date: Wed,  9 Nov 2022 19:14:40 -0700	[thread overview]
Message-ID: <20221110021455.1004335-3-sjg@chromium.org> (raw)
In-Reply-To: <20221110021455.1004335-1-sjg@chromium.org>

This currently uses if_changed on a phony target. Use a real file as the
target and add FORCE at the end, as required. Drop the 'inputs' phony
since it is not needed.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

(no changes since v2)

Changes in v2:
- Use a separate rule for running binman

 Makefile | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/Makefile b/Makefile
index d6699a54dbb..93d5c064f4c 100644
--- a/Makefile
+++ b/Makefile
@@ -1108,18 +1108,15 @@ define deprecated
 
 endef
 
-PHONY += inputs
-inputs: $(INPUTS-y)
-
-all: .binman_stamp inputs
+# Timestamp file to make sure that binman always runs
+.binman_stamp: $(INPUTS-y) FORCE
 ifeq ($(CONFIG_BINMAN),y)
 	$(call if_changed,binman)
 endif
-
-# Timestamp file to make sure that binman always runs
-.binman_stamp: FORCE
 	@touch $@
 
+all: .binman_stamp
+
 ifeq ($(CONFIG_DEPRECATED),y)
 	$(warning "You have deprecated configuration options enabled in your .config! Please check your configuration.")
 endif
-- 
2.38.1.431.g37b22c650d-goog


  parent reply	other threads:[~2022-11-10  2:16 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10  2:14 [PATCH v5 00/16] buildman: Correct various issues with missing blobs Simon Glass
2022-11-10  2:14 ` [PATCH v5 01/16] image: Correct strncpy() warning with image_set_name() Simon Glass
2022-11-23  2:12   ` Simon Glass
2022-11-10  2:14 ` Simon Glass [this message]
2022-11-10  8:01   ` [PATCH v5 02/16] Makefile: Correct the binman rule Pali Rohár
2022-11-10 20:40     ` Simon Glass
2022-11-23  2:11       ` Simon Glass
2022-11-10  2:14 ` [PATCH v5 03/16] doc: Correct the path to the Makefile documentation Simon Glass
2022-11-23  2:11   ` Simon Glass
2022-11-10  2:14 ` [PATCH v5 04/16] binman: Use an exit code when blobs are missing Simon Glass
2022-11-23  2:11   ` Simon Glass
2022-11-10  2:14 ` [PATCH v5 05/16] buildman: Convert documentation to rST Simon Glass
2022-11-23  2:11   ` Simon Glass
2022-11-10  2:14 ` [PATCH v5 06/16] buildman: Drop mention of MAKEALL Simon Glass
2022-11-23  2:11   ` Simon Glass
2022-11-10  2:14 ` [PATCH v5 07/16] buildman: Update the arc toolchain Simon Glass
2022-11-23  2:11   ` Simon Glass
2022-11-10  2:14 ` [PATCH v5 08/16] buildman: Update the default settings file Simon Glass
2022-11-23  2:11   ` Simon Glass
2022-11-10  2:14 ` [PATCH v5 09/16] buildman: Drop mention of old architectures Simon Glass
2022-11-23  2:11   ` Simon Glass
2022-11-10  2:14 ` [PATCH v5 10/16] buildman: Detect binman reporting missing blobs Simon Glass
2022-11-23  2:11   ` Simon Glass
2022-12-05 23:13   ` Peter Robinson
2022-12-05 23:23     ` Tom Rini
2022-12-05 23:29       ` Peter Robinson
2022-12-05 23:34         ` Tom Rini
2022-12-05 23:43           ` Peter Robinson
2022-12-05 23:46             ` Tom Rini
2022-12-05 23:49               ` Peter Robinson
2022-12-05 23:55               ` Simon Glass
2022-12-05 23:56                 ` Tom Rini
2022-12-05 23:57                   ` Simon Glass
2022-11-10  2:14 ` [PATCH v5 11/16] binman: Add a separate section about environment variables Simon Glass
2022-11-23  2:11   ` Simon Glass
2022-11-10  2:14 ` [PATCH v5 12/16] global: Do not default to faking missing binaries for buildman Simon Glass
2022-11-23  2:11   ` Simon Glass
2022-11-10  2:14 ` [PATCH v5 13/16] buildman: Ensure config_fname is inited Simon Glass
2022-11-23  2:11   ` Simon Glass
2022-11-10  2:14 ` [PATCH v5 14/16] buildman: Reinstate removal of temp output dir in tests Simon Glass
2022-11-23  2:11   ` Simon Glass
2022-11-10  2:14 ` [PATCH v5 15/16] buildman: Add --allow-missing flag to allow missing blobs Simon Glass
2022-11-23  2:11   ` Simon Glass
2022-11-10  2:14 ` [PATCH v5 16/16] binman: Add documentation for the command line args Simon Glass
2022-11-23  2:11   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221110021455.1004335-3-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=kabel@kernel.org \
    --cc=pali@kernel.org \
    --cc=quentin.schulz@theobroma-systems.com \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.