From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Subject: [PATCH v2 5/6] crypto: silence noisy kdf_sp800108 self-test
Date: Thu, 10 Nov 2022 00:13:45 -0800 [thread overview]
Message-ID: <20221110081346.336046-6-ebiggers@kernel.org> (raw)
In-Reply-To: <20221110081346.336046-1-ebiggers@kernel.org>
From: Eric Biggers <ebiggers@google.com>
Make the kdf_sp800108 self-test only print a message on success when
fips_enabled, so that it's consistent with testmgr.c and doesn't spam
the kernel log with a message that isn't really important.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
crypto/kdf_sp800108.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/kdf_sp800108.c b/crypto/kdf_sp800108.c
index c6e3ad82d5f7a..c3f9938e1ad27 100644
--- a/crypto/kdf_sp800108.c
+++ b/crypto/kdf_sp800108.c
@@ -140,7 +140,7 @@ static int __init crypto_kdf108_init(void)
WARN(1,
"alg: self-tests for CTR-KDF (hmac(sha256)) failed (rc=%d)\n",
ret);
- } else {
+ } else if (fips_enabled) {
pr_info("alg: self-tests for CTR-KDF (hmac(sha256)) passed\n");
}
--
2.38.1
next prev parent reply other threads:[~2022-11-10 8:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 8:13 [PATCH v2 0/6] crypto: reduce overhead when self-tests disabled Eric Biggers
2022-11-10 8:13 ` [PATCH v2 1/6] crypto: optimize algorithm registration " Eric Biggers
2022-11-10 19:42 ` Eric Biggers
2022-11-11 4:06 ` Herbert Xu
2022-11-10 8:13 ` [PATCH v2 2/6] crypto: optimize registration of internal algorithms Eric Biggers
2022-11-10 8:13 ` [PATCH v2 3/6] crypto: compile out crypto_boot_test_finished when tests disabled Eric Biggers
2022-11-10 8:13 ` [PATCH v2 4/6] crypto: skip kdf_sp800108 self-test " Eric Biggers
2022-11-10 8:13 ` Eric Biggers [this message]
2022-11-10 8:13 ` [PATCH v2 6/6] crypto: compile out test-related algboss code " Eric Biggers
2022-11-11 4:14 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221110081346.336046-6-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.