All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
Cc: "Mogilappagari, Sudheer" <sudheer.mogilappagari@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"mkubecek@suse.cz" <mkubecek@suse.cz>,
	"andrew@lunn.ch" <andrew@lunn.ch>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Subject: Re: [PATCH net-next v2] ethtool: add netlink based get rxfh support
Date: Thu, 10 Nov 2022 14:34:13 -0800	[thread overview]
Message-ID: <20221110143413.58f107c2@kernel.org> (raw)
In-Reply-To: <eba940d8-a2da-9a7e-2802-fbac680b7df6@intel.com>

On Thu, 10 Nov 2022 16:08:04 -0600 Samudrala, Sridhar wrote:
> Can we use QGRP as a prefix to indicate that these are per-queue group parameters
> and not restricted to RSS related parameters?
> 
>    QGRP_CONTEXT
>    QGRP_RSS_HFUNC
>    QGRP_RSS_KEY
>    QGRP_RSS_INDIR_TABLE
> 
> In future, we would like to add per-queue group parameters like
>    QGRP_INLINE_FLOW_STEERING (Round robin flow steering of TCP flows)

The RSS context thing is a pretty shallow abstraction, I don't think we
should be extending it into "queue groups" or whatnot. We'll probably
need some devlink objects at some point (rate configuration?) and
locking order is devlink > rtnl, so spawning things from within ethtool
will be a pain :S

  reply	other threads:[~2022-11-10 22:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04 23:42 [PATCH net-next v2] ethtool: add netlink based get rxfh support Sudheer Mogilappagari
2022-11-08  2:25 ` Jakub Kicinski
2022-11-10  0:26   ` Mogilappagari, Sudheer
2022-11-10  0:46     ` Jakub Kicinski
2022-11-10 22:08       ` Samudrala, Sridhar
2022-11-10 22:34         ` Jakub Kicinski [this message]
2022-11-10 23:24           ` Samudrala, Sridhar
2022-11-11  0:12             ` Jakub Kicinski
2022-11-14  4:23               ` Samudrala, Sridhar
2022-11-14 17:15                 ` Jakub Kicinski
2022-11-15  1:46                   ` Samudrala, Sridhar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221110143413.58f107c2@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=corbet@lwn.net \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=sridhar.samudrala@intel.com \
    --cc=sudheer.mogilappagari@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.