From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B38DC43217 for ; Thu, 10 Nov 2022 23:39:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231542AbiKJXjL (ORCPT ); Thu, 10 Nov 2022 18:39:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229675AbiKJXjH (ORCPT ); Thu, 10 Nov 2022 18:39:07 -0500 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9758A4E425 for ; Thu, 10 Nov 2022 15:39:06 -0800 (PST) Received: by mail-pf1-x435.google.com with SMTP id k22so3449163pfd.3 for ; Thu, 10 Nov 2022 15:39:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=egD5Tg++8qx4ItNprsKNgzbgrJeq4vL0OWVeOsX4bbk=; b=JbrJhXsxnEC6xWL50DeLPpqlBafgykYLTM2Xw/4Z/zI3QEWWvHC2Zymh5PfxYB2Ki/ GMSCiHP0POQDXpdibgCAIDDk0qB4OGKvRDbzxwE8JVEPGNLhvzGKXc39DeCdggd/k3oq 0lVaUTtPIv23gKvAObPZgVdVdRMvWruw/Xzr1gA1r2NzkSbCzX+vaem9UKBu1dsWN8nx PBj3ujyuQK4tiqGncJ62NDFGd9Iel7tmAjZpHwFZSJ4+5TA4stX9iSa75cuzUSkquBQe sBGBeaa6RJKZG1Pl+OCZp6uSwLSrn2j+RpfLJwUcGYe1hESxdU5GT8Cn1ZlOK4hu6eV/ NRIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=egD5Tg++8qx4ItNprsKNgzbgrJeq4vL0OWVeOsX4bbk=; b=OhtylOxSjEEQauPQNpQCGut0grmPwR4TEp9eq0G6gbKgpAgYmmOVAMwrr8p2ZnbTvZ OiuZGXnwO9QWRrtdc0BlmbJo3gCCfABdZ6A4RvyF4xAiFryIn3RoGyb0feJxajNHoxhs AoUw7ZtA0DSe1GGb3uPFSzGYC5ffrYcP4WWEYbnq0900PfiXf4TsRJRz1vo04Ee+OXuY jWTDMU7RJGLObt6oK241igH2W+Q2+7ZtZXGq0iY0jgAyHC6YWVN8r13YnPFed6ul3Mod ZPcIQ/p36ysRN9830ep0sKm7RpgeVd29wzS2Oj/BNDcGzMU44dUh9sm6sz5cVp/bW1aC 5pYQ== X-Gm-Message-State: ACrzQf2AlNrWW7pZFiC0LUqyPoNZKqkfkbjRbOnDq27Wiks5RcEWnbmI Skp+m18qNHHf2VsKdxzUdF8AuQ== X-Google-Smtp-Source: AMsMyM5kS/IQV5jAfUUf7aC0Yja0iyMPxgwH8pK9Sci2X/77qGSjw+nGM6+hKorqrSp/vyGe9VF2xQ== X-Received: by 2002:a63:1250:0:b0:459:a339:89e0 with SMTP id 16-20020a631250000000b00459a33989e0mr3809729pgs.300.1668123546045; Thu, 10 Nov 2022 15:39:06 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id c188-20020a624ec5000000b0056be7ac5261sm203023pfb.163.2022.11.10.15.39.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 15:39:05 -0800 (PST) Date: Thu, 10 Nov 2022 15:39:01 -0800 From: Stephen Hemminger To: Jamie Bainbridge Cc: Eric Dumazet , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tcp: Add listening address to SYN flood message Message-ID: <20221110153901.7daa86e1@hermes.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Nov 2022 21:21:06 +1100 Jamie Bainbridge wrote: > + xchg(&queue->synflood_warned, 1) == 0) { > +#if IS_ENABLED(CONFIG_IPV6) > + if (sk->sk_family == AF_INET6) { > + net_info_ratelimited("%s: Possible SYN flooding on port %d. IP %pI6c. %s. Check SNMP counters.\n", > + proto, sk->sk_num, > + &sk->sk_v6_rcv_saddr, msg); > + } else > +#endif > + { > + net_info_ratelimited("%s: Possible SYN flooding on port %d. IP %pI4. %s. Check SNMP counters.\n", > + proto, sk->sk_num, &sk->sk_rcv_saddr, msg); > + } > + } > Port number is unsigned not signed. Message also seems overly wordy to me.