From: Jakub Kicinski <kuba@kernel.org>
To: Daniele Palmas <dnlplm@gmail.com>
Cc: "David Miller" <davem@davemloft.net>,
"Paolo Abeni" <pabeni@redhat.com>,
"Eric Dumazet" <edumazet@google.com>,
"Subash Abhinov Kasiviswanathan" <quic_subashab@quicinc.com>,
"Sean Tranchetti" <quic_stranche@quicinc.com>,
"Jonathan Corbet" <corbet@lwn.net>, "Bjørn Mork" <bjorn@mork.no>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] net: qualcomm: rmnet: add tx packets aggregation
Date: Fri, 11 Nov 2022 09:14:40 -0800 [thread overview]
Message-ID: <20221111091440.51f9c09e@kernel.org> (raw)
In-Reply-To: <20221109180249.4721-3-dnlplm@gmail.com>
On Wed, 9 Nov 2022 19:02:48 +0100 Daniele Palmas wrote:
> +bool rmnet_map_tx_agg_skip(struct sk_buff *skb)
> +{
> + bool is_icmp = 0;
> +
> + if (skb->protocol == htons(ETH_P_IP)) {
> + struct iphdr *ip4h = ip_hdr(skb);
> +
> + if (ip4h->protocol == IPPROTO_ICMP)
> + is_icmp = true;
> + } else if (skb->protocol == htons(ETH_P_IPV6)) {
> + unsigned int icmp_offset = 0;
> +
> + if (ipv6_find_hdr(skb, &icmp_offset, IPPROTO_ICMPV6, NULL, NULL) == IPPROTO_ICMPV6)
> + is_icmp = true;
> + }
> +
> + return is_icmp;
> +}
Why this? I don't see it mention in the commit message or any code
comment.
next prev parent reply other threads:[~2022-11-11 17:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 18:02 [PATCH net-next 0/3] add tx packets aggregation to ethtool and rmnet Daniele Palmas
2022-11-09 18:02 ` [PATCH net-next 1/3] ethtool: add tx aggregation parameters Daniele Palmas
2022-11-11 17:07 ` Jakub Kicinski
2022-11-11 21:51 ` Daniele Palmas
2022-11-13 9:48 ` Gal Pressman
2022-11-14 10:06 ` Daniele Palmas
2022-11-14 10:45 ` Dave Taht
2022-11-15 11:51 ` Daniele Palmas
2022-11-15 15:27 ` Dave Taht
2022-11-15 0:42 ` Jakub Kicinski
2022-11-15 10:59 ` Gal Pressman
2022-11-15 16:21 ` Jakub Kicinski
2022-11-09 18:02 ` [PATCH net-next 2/3] net: qualcomm: rmnet: add tx packets aggregation Daniele Palmas
2022-11-10 17:32 ` Alexander Lobakin
2022-11-11 1:17 ` Subash Abhinov Kasiviswanathan (KS)
2022-11-11 17:11 ` Jakub Kicinski
2022-11-11 22:00 ` Daniele Palmas
2022-11-14 8:48 ` Daniele Palmas
2022-11-11 17:23 ` Daniele Palmas
2022-11-16 15:19 ` Daniele Palmas
2022-11-16 16:20 ` Alexander Lobakin
2022-11-20 9:25 ` Daniele Palmas
2022-11-20 9:39 ` Bjørn Mork
2022-11-20 9:52 ` Daniele Palmas
2022-11-20 17:48 ` Subash Abhinov Kasiviswanathan (KS)
2022-11-21 7:00 ` Daniele Palmas
2022-11-24 3:32 ` Subash Abhinov Kasiviswanathan (KS)
2022-11-10 19:09 ` kernel test robot
2022-11-11 17:14 ` Jakub Kicinski [this message]
2022-11-14 9:13 ` Daniele Palmas
2022-11-14 10:25 ` Bjørn Mork
2022-11-15 0:43 ` Jakub Kicinski
2022-11-09 18:02 ` [PATCH net-next 3/3] net: qualcomm: rmnet: add ethtool support for configuring tx aggregation Daniele Palmas
2022-11-11 6:46 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111091440.51f9c09e@kernel.org \
--to=kuba@kernel.org \
--cc=bjorn@mork.no \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dnlplm@gmail.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_stranche@quicinc.com \
--cc=quic_subashab@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.