From: Yonghong Song <yhs@fb.com>
To: <bpf@vger.kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>, <kernel-team@fb.com>,
Martin KaFai Lau <martin.lau@kernel.org>
Subject: [PATCH bpf-next v5 7/7] selftests/bpf: Add rcu_read_lock test to s390x/aarch64 deny lists
Date: Fri, 11 Nov 2022 08:58:11 -0800 [thread overview]
Message-ID: <20221111165811.2530740-1-yhs@fb.com> (raw)
In-Reply-To: <20221111165734.2524596-1-yhs@fb.com>
The new rcu_read_lock test failed on s390x with the following error message:
...
test_rcu_read_lock:PASS:join_cgroup /rcu_read_lock 0 nsec
test_local_storage:PASS:skel_open 0 nsec
libbpf: prog 'cgrp_succ': failed to find kernel BTF type ID of '__s390x_sys_getpgid': -3
libbpf: prog 'cgrp_succ': failed to prepare load attributes: -3
libbpf: prog 'cgrp_succ': failed to load: -3
libbpf: failed to load object 'rcu_read_lock'
libbpf: failed to load BPF skeleton 'rcu_read_lock': -3
test_local_storage:FAIL:skel_load unexpected error: -3 (errno 3)
...
It failed on aarch64 with the following error message due to inadequate
trampoline support.
...
test_rcu_read_lock:PASS:join_cgroup /rcu_read_lock 0 nsec
test_local_storage:PASS:skel_open 0 nsec
test_local_storage:PASS:skel_load 0 nsec
libbpf: prog 'cgrp_succ': failed to attach: ERROR: strerror_r(-524)=22
libbpf: prog 'cgrp_succ': failed to auto-attach: -524
test_local_storage:FAIL:skel_attach unexpected error: -524 (errno 524)
...
So add the test to s390x and aarch64 deny lists.
Signed-off-by: Yonghong Song <yhs@fb.com>
---
tools/testing/selftests/bpf/DENYLIST.aarch64 | 1 +
tools/testing/selftests/bpf/DENYLIST.s390x | 1 +
2 files changed, 2 insertions(+)
diff --git a/tools/testing/selftests/bpf/DENYLIST.aarch64 b/tools/testing/selftests/bpf/DENYLIST.aarch64
index 09416d5d2e33..2ff8a40ed9dd 100644
--- a/tools/testing/selftests/bpf/DENYLIST.aarch64
+++ b/tools/testing/selftests/bpf/DENYLIST.aarch64
@@ -44,6 +44,7 @@ modify_return # modify_return__attach failed
module_attach # skel_attach skeleton attach failed: -524
mptcp/base # run_test mptcp unexpected error: -524 (errno 524)
netcnt # packets unexpected packets: actual 10001 != expected 10000
+rcu_read_lock # failed to attach: ERROR: strerror_r(-524)=22
recursion # skel_attach unexpected error: -524 (errno 524)
ringbuf # skel_attach skeleton attachment failed: -1
setget_sockopt # attach_cgroup unexpected error: -524
diff --git a/tools/testing/selftests/bpf/DENYLIST.s390x b/tools/testing/selftests/bpf/DENYLIST.s390x
index be4e3d47ea3e..dd5db40b5a09 100644
--- a/tools/testing/selftests/bpf/DENYLIST.s390x
+++ b/tools/testing/selftests/bpf/DENYLIST.s390x
@@ -41,6 +41,7 @@ module_attach # skel_attach skeleton attach failed: -
mptcp
netcnt # failed to load BPF skeleton 'netcnt_prog': -7 (?)
probe_user # check_kprobe_res wrong kprobe res from probe read (?)
+rcu_read_lock # failed to find kernel BTF type ID of '__x64_sys_getpgid': -3 (?)
recursion # skel_attach unexpected error: -524 (trampoline)
ringbuf # skel_load skeleton load failed (?)
select_reuseport # intermittently fails on new s390x setup
--
2.30.2
prev parent reply other threads:[~2022-11-11 16:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 16:57 [PATCH bpf-next v5 0/7] bpf: Add bpf_rcu_read_lock() support Yonghong Song
2022-11-11 16:57 ` [PATCH bpf-next v5 1/7] compiler_types: Define __rcu as __attribute__((btf_type_tag("rcu"))) Yonghong Song
2022-11-11 16:57 ` [PATCH bpf-next v5 2/7] bpf: Abstract out functions to check sleepable helpers Yonghong Song
2022-11-11 16:57 ` [PATCH bpf-next v5 3/7] bpf: Add kfunc bpf_rcu_read_lock/unlock() Yonghong Song
2022-11-11 16:57 ` [PATCH bpf-next v5 4/7] bpf: Add bpf_rcu_read_lock() verifier support Yonghong Song
2022-11-11 16:58 ` [PATCH bpf-next v5 5/7] bpf: Enable sleeptable support for cgrp local storage Yonghong Song
2022-11-11 16:58 ` [PATCH bpf-next v5 6/7] selftests/bpf: Add tests for bpf_rcu_read_lock() Yonghong Song
2022-11-15 6:50 ` Martin KaFai Lau
2022-11-16 5:33 ` Yonghong Song
2022-11-11 16:58 ` Yonghong Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111165811.2530740-1-yhs@fb.com \
--to=yhs@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.