All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Michael Nosthoff via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v2] package/swupdate: add libubootenv as dependency
Date: Sat, 12 Nov 2022 21:32:44 +0100	[thread overview]
Message-ID: <20221112213244.161b83fe@windsurf> (raw)
In-Reply-To: <20221110102313.182828-1-buildroot@heine.tech>

Hello Michael,

On Thu, 10 Nov 2022 11:23:12 +0100
Michael Nosthoff via buildroot <buildroot@buildroot.org> wrote:

> when using BR2_PER_PACKAGE_DIRECTORIES and configuring swupdate to
> use uboot the build fails because libubootenv is not a dependency.
> 
> Fixes:
> bootloader/uboot.c:23:10: fatal error: libuboot.h: No such file or directory
>    23 | #include <libuboot.h>
> 
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>

Could you provide a bit more details? Your change is only making sure
libubootenv is built before swupdate *if* libubootenv is eanbled in the
Buildroot configuration. This would mean libubootenv is an optional
dependency of swupdate.

But your commit log seems to imply otherwise.

We are not seeing any build errors on swupdate in our autobuilders.
Could you provide an example Buildroot configuration that exhibits the
issue?

Thanks

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-11-12 20:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 10:23 [Buildroot] [PATCH v2] package/swupdate: add libubootenv as dependency Michael Nosthoff via buildroot
2022-11-12 20:32 ` Thomas Petazzoni via buildroot [this message]
2022-11-13 11:56   ` Michael Nosthoff via buildroot
2022-11-24 12:36     ` Arnout Vandecappelle
2022-11-27 20:22       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221112213244.161b83fe@windsurf \
    --to=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.