From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: haris.iqbal@ionos.com, jinpu.wang@ionos.com, jgg@ziepe.ca,
leon@kernel.org
Cc: linux-rdma@vger.kernel.org
Subject: [PATCH RFC 10/12] RDMA/rtrs-srv: Remove paths_num
Date: Sun, 13 Nov 2022 09:08:21 +0800 [thread overview]
Message-ID: <20221113010823.6436-11-guoqing.jiang@linux.dev> (raw)
In-Reply-To: <20221113010823.6436-1-guoqing.jiang@linux.dev>
The paths_num is only increased by rtrs_rdma_connect -> __alloc_path
which is only one time thing, so is the decreasing of it given only
rtrs_srv_close_work -> del_path_from_srv, which means paths_num should
always be 1.
Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
---
drivers/infiniband/ulp/rtrs/rtrs-srv.c | 8 --------
drivers/infiniband/ulp/rtrs/rtrs-srv.h | 1 -
2 files changed, 9 deletions(-)
diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
index e2ea09a8def7..400cf8ae34a3 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
@@ -1437,8 +1437,6 @@ static void __add_path_to_srv(struct rtrs_srv_sess *srv,
struct rtrs_srv_path *srv_path)
{
list_add_tail(&srv_path->s.entry, &srv->paths_list);
- srv->paths_num++;
- WARN_ON(srv->paths_num >= MAX_PATHS_NUM);
}
static void del_path_from_srv(struct rtrs_srv_path *srv_path)
@@ -1450,8 +1448,6 @@ static void del_path_from_srv(struct rtrs_srv_path *srv_path)
mutex_lock(&srv->paths_mutex);
list_del(&srv_path->s.entry);
- WARN_ON(!srv->paths_num);
- srv->paths_num--;
mutex_unlock(&srv->paths_mutex);
}
@@ -1719,10 +1715,6 @@ static struct rtrs_srv_path *__alloc_path(struct rtrs_srv_sess *srv,
char str[NAME_MAX];
struct rtrs_addr path;
- if (srv->paths_num >= MAX_PATHS_NUM) {
- err = -ECONNRESET;
- goto err;
- }
if (__is_path_w_addr_exists(srv, &cm_id->route.addr)) {
err = -EEXIST;
pr_err("Path with same addr exists\n");
diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.h b/drivers/infiniband/ulp/rtrs/rtrs-srv.h
index eccc432b0715..8e4fcb578f49 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs-srv.h
+++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.h
@@ -100,7 +100,6 @@ struct rtrs_srv_sess {
struct list_head paths_list;
int paths_up;
struct mutex paths_ev_mutex;
- size_t paths_num;
struct mutex paths_mutex;
uuid_t paths_uuid;
refcount_t refcount;
--
2.31.1
next prev parent reply other threads:[~2022-11-13 1:09 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 1:08 [PATCH RFC 00/12] Misc changes for rtrs Guoqing Jiang
2022-11-13 1:08 ` [PATCH RFC 01/12] RDMA/rtrs-srv: Remove ib_dev_count from rtrs_srv_ib_ctx Guoqing Jiang
2022-11-14 7:39 ` Jinpu Wang
2022-11-14 8:00 ` Guoqing Jiang
2022-11-14 8:24 ` Jinpu Wang
2022-11-14 8:45 ` Guoqing Jiang
2022-11-14 13:36 ` Haris Iqbal
2022-11-15 10:22 ` Guoqing Jiang
2022-11-13 1:08 ` [PATCH RFC 02/12] RDMA/rtrs-srv: Refactor rtrs_srv_rdma_cm_handler Guoqing Jiang
2022-11-14 14:39 ` Haris Iqbal
2022-11-15 10:24 ` Guoqing Jiang
2022-11-13 1:08 ` [PATCH RFC 03/12] RDMA/rtrs-srv: Only close srv_path if it is just allocated Guoqing Jiang
2022-11-14 16:18 ` Haris Iqbal
2022-11-15 10:24 ` Guoqing Jiang
2022-11-15 10:31 ` Jinpu Wang
2022-11-13 1:08 ` [PATCH RFC 04/12] RDMA/rtrs-srv: refactor the handling of failure case in map_cont_bufs Guoqing Jiang
2022-11-14 16:21 ` Haris Iqbal
2022-11-13 1:08 ` [PATCH RFC 05/12] RDMA/rtrs-srv: Correct the checking of ib_map_mr_sg Guoqing Jiang
2022-11-15 11:46 ` Jinpu Wang
2022-11-16 1:13 ` Guoqing Jiang
2022-11-16 5:44 ` Jinpu Wang
2022-11-13 1:08 ` [PATCH RFC 06/12] RDMA/rtrs-clt: " Guoqing Jiang
2022-11-15 11:49 ` Jinpu Wang
2022-11-13 1:08 ` [PATCH RFC 07/12] RDMA/rtrs-srv: Remove outdated comments from create_con Guoqing Jiang
2022-11-14 16:22 ` Haris Iqbal
2022-11-13 1:08 ` [PATCH RFC 08/12] RDMA/rtrs: Kill recon_cnt from several structs Guoqing Jiang
2022-11-15 9:39 ` Haris Iqbal
2022-11-15 9:53 ` Jinpu Wang
2022-11-15 9:58 ` Jinpu Wang
2022-11-15 10:33 ` Guoqing Jiang
2022-11-13 1:08 ` [PATCH RFC 09/12] RDMA/rtrs: Clean up rtrs_rdma_dev_pd_ops Guoqing Jiang
2022-11-15 9:18 ` Haris Iqbal
2022-11-13 1:08 ` Guoqing Jiang [this message]
2022-11-15 9:48 ` [PATCH RFC 10/12] RDMA/rtrs-srv: Remove paths_num Haris Iqbal
2022-11-15 10:01 ` Jinpu Wang
2022-11-15 10:30 ` Guoqing Jiang
2022-11-13 1:08 ` [PATCH RFC 11/12] RDMA/rtrs-srv: fix several issues in rtrs_srv_destroy_path_files Guoqing Jiang
2022-11-14 16:22 ` Haris Iqbal
2022-11-13 1:08 ` [PATCH RFC 12/12] RDMA/rtrs-srv: Remove kobject_del from rtrs_srv_destroy_once_sysfs_root_folders Guoqing Jiang
2022-11-14 16:23 ` Haris Iqbal
2022-11-14 8:32 ` [PATCH RFC 00/12] Misc changes for rtrs Leon Romanovsky
2022-11-14 8:46 ` Guoqing Jiang
2022-11-17 9:52 ` Leon Romanovsky
2022-11-17 10:06 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221113010823.6436-11-guoqing.jiang@linux.dev \
--to=guoqing.jiang@linux.dev \
--cc=haris.iqbal@ionos.com \
--cc=jgg@ziepe.ca \
--cc=jinpu.wang@ionos.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.