All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
	Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/imagemagick: utilities now need C++ support
Date: Sun, 13 Nov 2022 15:12:28 +0100	[thread overview]
Message-ID: <20221113141228.GG2123054@scaer> (raw)
In-Reply-To: <20221111224011.430289-1-thomas.petazzoni@bootlin.com>

Thomas, All,

On 2022-11-11 23:40 +0100, Thomas Petazzoni via buildroot spake thusly:
> Since upstream commit
> https://github.com/ImageMagick/ImageMagick/commit/07f3b487f9860fd4eb9422f1a906d0fe83b6fd1c
> (which first appeared in version 7.1.0-47), ImageMagick forces the
> need of a C++ compiler to build its utilities. Despite the request of
> Bernd Kuhls to revert this change, upstream declined.
> 
> Since this change is causing build failures in our autobuilders, our
> only choice is to follow the choice of upstream, and disable building
> the utilities when C++ support is not available.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/4283235d697408cf2e70be5e3769dbe6ebb9ddae/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/imagemagick/imagemagick.mk | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/imagemagick/imagemagick.mk b/package/imagemagick/imagemagick.mk
> index 6bdf24c1e8..8a2ec460d5 100644
> --- a/package/imagemagick/imagemagick.mk
> +++ b/package/imagemagick/imagemagick.mk
> @@ -178,6 +178,12 @@ else
>  IMAGEMAGICK_CONF_OPTS += --without-bzlib
>  endif
>  
> +ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
> +IMAGEMAGICK_CONF_OPTS += --with-utilities
> +else
> +IMAGEMAGICK_CONF_OPTS += --without-utilities
> +endif
> +
>  HOST_IMAGEMAGICK_CONF_OPTS = \
>  	--disable-opencl \
>  	--disable-openmp \
> -- 
> 2.38.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-11-13 14:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-11 22:40 [Buildroot] [PATCH] package/imagemagick: utilities now need C++ support Thomas Petazzoni via buildroot
2022-11-13 14:12 ` Yann E. MORIN [this message]
2022-11-15 13:01 ` Peter Korsgaard
2022-11-15 13:43   ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221113141228.GG2123054@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=bernd.kuhls@t-online.de \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.