From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Subject: [PATCH v3 6/6] crypto: compile out test-related algboss code when tests disabled
Date: Sun, 13 Nov 2022 16:12:38 -0800 [thread overview]
Message-ID: <20221114001238.163209-7-ebiggers@kernel.org> (raw)
In-Reply-To: <20221114001238.163209-1-ebiggers@kernel.org>
From: Eric Biggers <ebiggers@google.com>
When CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is set, the code in algboss.c
that handles CRYPTO_MSG_ALG_REGISTER is unnecessary, so make it be
compiled out.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
crypto/algboss.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/crypto/algboss.c b/crypto/algboss.c
index 13d37320a66eb..0de1e66979498 100644
--- a/crypto/algboss.c
+++ b/crypto/algboss.c
@@ -175,11 +175,7 @@ static int cryptomgr_test(void *data)
{
struct crypto_test_param *param = data;
u32 type = param->type;
- int err = 0;
-
-#ifdef CONFIG_CRYPTO_MANAGER_DISABLE_TESTS
- goto skiptest;
-#endif
+ int err;
err = alg_test(param->driver, param->alg, type, CRYPTO_ALG_TESTED);
@@ -194,6 +190,9 @@ static int cryptomgr_schedule_test(struct crypto_alg *alg)
struct task_struct *thread;
struct crypto_test_param *param;
+ if (IS_ENABLED(CONFIG_CRYPTO_MANAGER_DISABLE_TESTS))
+ return NOTIFY_DONE;
+
if (!try_module_get(THIS_MODULE))
goto err;
--
2.38.1
next prev parent reply other threads:[~2022-11-14 0:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 0:12 [PATCH v3 0/6] crypto: reduce overhead when self-tests disabled Eric Biggers
2022-11-14 0:12 ` [PATCH v3 1/6] crypto: optimize algorithm registration " Eric Biggers
2022-11-14 0:12 ` [PATCH v3 2/6] crypto: optimize registration of internal algorithms Eric Biggers
2022-11-30 19:04 ` Eric Biggers
2022-12-01 10:19 ` Herbert Xu
2022-11-14 0:12 ` [PATCH v3 3/6] crypto: compile out crypto_boot_test_finished when tests disabled Eric Biggers
2022-11-14 0:12 ` [PATCH v3 4/6] crypto: skip kdf_sp800108 self-test " Eric Biggers
2022-11-14 0:12 ` [PATCH v3 5/6] crypto: silence noisy kdf_sp800108 self-test Eric Biggers
2022-11-14 0:12 ` Eric Biggers [this message]
2022-11-25 9:44 ` [PATCH v3 0/6] crypto: reduce overhead when self-tests disabled Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221114001238.163209-7-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.