From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 187DDC433FE for ; Mon, 14 Nov 2022 08:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rKmvBts4isxGtpBsubG69tcKfE/YdMPBrkvYr0Akb9c=; b=CtHwJynuxx4gIy UemkpWNpJEFgDsd9vbUlQ9Osu51+MJXDUjTkI473Kz8euUdjb6e2O3oHOGeoyYOXhCmi4rtxsbXIm rZZL02l8QJGL2X+P4wJSWjYyTWtP82AsCYuOasgj/B7Xf5JHzVLnXlkYpEjVzkCLL+r/Lq1eAxRCd +Emm0T67ieWfDLUrOt1rVr54AZ91eo50sjsxrSnEZ0QzL3Bb7+grZJyM6g9S2dVyALvy184tBuriM uSUIOsp0GtayWAWvUhVKhHqGGRNQAPrOPWXcdduOfaGHl58/mJLv4mjNkW2rhS1Br/f3kCxpSk1GT ZJYSWEaPm+YGYGuj1goA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouUS5-00Gep3-EP; Mon, 14 Nov 2022 08:04:21 +0000 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouUS2-00Geip-ED for linux-mtd@lists.infradead.org; Mon, 14 Nov 2022 08:04:20 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 54E31240010; Mon, 14 Nov 2022 08:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1668413052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cvKVGnbTF4i/qSpcUrTjr5cPePLfjlEgnVYVKtrHHPM=; b=TqDNsDAceBd8e2E8Jea/mSZZE3E50Rt2olFVg+yu/1KrHOvo4YNL5Kk9COOL/bv9tyJxHC 1FXTDCr+U6OeBv4quKeO4+nYYpOTv1789rOqQr5kM7TFivHBYlj5KyrHizQaIB9FFcp3Hy JDZmsjseXSgJFbr/HMQxqzpIxtWkGdIF9LYj6emoL7fSgBBEfUdCZMSrcKbTX069fU7M4D zv0xFEcgCbWotA8E5xtcFRKGt/F1f0YUvnRR9WvOwIIrEQlL4LGkIJ8C2rfJvM75mhS4t/ U1Vxdvb2tRS6L55D3imCZRjHo3EYuoMQOyjv2K5vDDF+NjZWyJd1bOOLhF49tg== Date: Mon, 14 Nov 2022 09:04:08 +0100 From: Miquel Raynal To: Hui Tang Cc: , , , , , , Subject: Re: [PATCH] mtd: lpddr2_nvm: i2c: mux: reg: Fix possible null-ptr-deref Message-ID: <20221114090408.7ed0e7c1@xps-13> In-Reply-To: <20221114020141.28138-1-tanghui20@huawei.com> References: <20221114020141.28138-1-tanghui20@huawei.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221114_000418_647105_F3CA65EA X-CRM114-Status: GOOD ( 12.27 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgSHVpLAoKdGFuZ2h1aTIwQGh1YXdlaS5jb20gd3JvdGUgb24gTW9uLCAxNCBOb3YgMjAyMiAx MDowMTo0MSArMDgwMDoKCj4gSXQgd2lsbCBjYXVzZSBudWxsLXB0ci1kZXJlZiB3aGVuIHJlc291 cmNlX3NpemUoYWRkX3JhbmdlKSBpbnZva2VkLAo+IGlmIHBsYXRmb3JtX2dldF9yZXNvdXJjZSgp IHJldHVybnMgTlVMTC4KPiAKPiBGaXhlczogOTZiYTlkZDY1Nzg4ICgibXRkOiBscGRkcjogYWRk IGRyaXZlciBmb3IgTFBERFIyLU5WTSBQQ00gbWVtb3JpZXMiKQo+IFNpZ25lZC1vZmYtYnk6IEh1 aSBUYW5nIDx0YW5naHVpMjBAaHVhd2VpLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9tdGQvbHBkZHIv bHBkZHIyX252bS5jIHwgMiArKwo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL2xwZGRyL2xwZGRyMl9udm0uYyBiL2RyaXZlcnMv bXRkL2xwZGRyL2xwZGRyMl9udm0uYwo+IGluZGV4IDM2N2UyZDkwNmRlMC4uY2Y4ZTg2ZWI0YjJj IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRkL2xwZGRyL2xwZGRyMl9udm0uYwo+ICsrKyBiL2Ry aXZlcnMvbXRkL2xwZGRyL2xwZGRyMl9udm0uYwo+IEBAIC00MzMsNiArNDMzLDggQEAgc3RhdGlj IGludCBscGRkcjJfbnZtX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAo+ ICAJLyogbHBkZHIyX252bSBhZGRyZXNzIHJhbmdlICovCj4gIAlhZGRfcmFuZ2UgPSBwbGF0Zm9y bV9nZXRfcmVzb3VyY2UocGRldiwgSU9SRVNPVVJDRV9NRU0sIDApOwo+ICsJaWYgKElTX0VSUihh ZGRfcmFuZ2UpKQoKcGxhdGZvcm1fZ2V0X3Jlc291cmNlKCkganVzdCByZXR1cm5zIE5VTEwgdXBv biBlcnJvci4KCj4gKwkJcmV0dXJuIC1FTk9ERVY7Cj4gIAo+ICAJLyogUG9wdWxhdGUgbWFwX2lu Zm8gZGF0YSBzdHJ1Y3R1cmUgKi8KPiAgCSptYXAgPSAoc3RydWN0IG1hcF9pbmZvKSB7CgoKVGhh bmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43834C433FE for ; Mon, 14 Nov 2022 08:04:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236168AbiKNIEQ (ORCPT ); Mon, 14 Nov 2022 03:04:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235782AbiKNIEP (ORCPT ); Mon, 14 Nov 2022 03:04:15 -0500 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CADD6220 for ; Mon, 14 Nov 2022 00:04:13 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 54E31240010; Mon, 14 Nov 2022 08:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1668413052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cvKVGnbTF4i/qSpcUrTjr5cPePLfjlEgnVYVKtrHHPM=; b=TqDNsDAceBd8e2E8Jea/mSZZE3E50Rt2olFVg+yu/1KrHOvo4YNL5Kk9COOL/bv9tyJxHC 1FXTDCr+U6OeBv4quKeO4+nYYpOTv1789rOqQr5kM7TFivHBYlj5KyrHizQaIB9FFcp3Hy JDZmsjseXSgJFbr/HMQxqzpIxtWkGdIF9LYj6emoL7fSgBBEfUdCZMSrcKbTX069fU7M4D zv0xFEcgCbWotA8E5xtcFRKGt/F1f0YUvnRR9WvOwIIrEQlL4LGkIJ8C2rfJvM75mhS4t/ U1Vxdvb2tRS6L55D3imCZRjHo3EYuoMQOyjv2K5vDDF+NjZWyJd1bOOLhF49tg== Date: Mon, 14 Nov 2022 09:04:08 +0100 From: Miquel Raynal To: Hui Tang Cc: , , , , , , Subject: Re: [PATCH] mtd: lpddr2_nvm: i2c: mux: reg: Fix possible null-ptr-deref Message-ID: <20221114090408.7ed0e7c1@xps-13> In-Reply-To: <20221114020141.28138-1-tanghui20@huawei.com> References: <20221114020141.28138-1-tanghui20@huawei.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hui, tanghui20@huawei.com wrote on Mon, 14 Nov 2022 10:01:41 +0800: > It will cause null-ptr-deref when resource_size(add_range) invoked, > if platform_get_resource() returns NULL. >=20 > Fixes: 96ba9dd65788 ("mtd: lpddr: add driver for LPDDR2-NVM PCM memories") > Signed-off-by: Hui Tang > --- > drivers/mtd/lpddr/lpddr2_nvm.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/mtd/lpddr/lpddr2_nvm.c b/drivers/mtd/lpddr/lpddr2_nv= m.c > index 367e2d906de0..cf8e86eb4b2c 100644 > --- a/drivers/mtd/lpddr/lpddr2_nvm.c > +++ b/drivers/mtd/lpddr/lpddr2_nvm.c > @@ -433,6 +433,8 @@ static int lpddr2_nvm_probe(struct platform_device *p= dev) > =20 > /* lpddr2_nvm address range */ > add_range =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (IS_ERR(add_range)) platform_get_resource() just returns NULL upon error. > + return -ENODEV; > =20 > /* Populate map_info data structure */ > *map =3D (struct map_info) { Thanks, Miqu=C3=A8l