From: Jakub Kicinski <kuba@kernel.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: dsa: use more appropriate NET_NAME_* constants for user ports
Date: Tue, 15 Nov 2022 08:38:28 -0800 [thread overview]
Message-ID: <20221115083828.06cebab1@kernel.org> (raw)
In-Reply-To: <20221115074356.998747-1-linux@rasmusvillemoes.dk>
On Tue, 15 Nov 2022 08:43:55 +0100 Rasmus Villemoes wrote:
> + if (port->name) {
> + name = port->name;
> + assign_type = NET_NAME_PREDICTABLE;
> + } else {
> + name = "eth%d";
> + assign_type = NET_NAME_ENUM;
Per Andrew's comment lets make the change in two steps.
Which one should come first is a judgment call :)
next prev parent reply other threads:[~2022-11-15 16:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 16:17 [PATCH] net: dsa: use NET_NAME_PREDICTABLE for user ports with name given in DT Rasmus Villemoes
2022-11-11 17:10 ` Andrew Lunn
2022-11-13 20:03 ` Rasmus Villemoes
2022-11-15 2:17 ` Jakub Kicinski
2022-11-15 15:02 ` Andrew Lunn
2022-11-15 7:43 ` [PATCH v2] net: dsa: use more appropriate NET_NAME_* constants for user ports Rasmus Villemoes
2022-11-15 16:38 ` Jakub Kicinski [this message]
2022-11-15 18:55 ` Rasmus Villemoes
2022-11-16 1:59 ` Jakub Kicinski
2022-11-16 10:52 ` [PATCH v3 0/3] " Rasmus Villemoes
2022-11-16 10:52 ` [PATCH v3 1/3] net: dsa: refactor name assignment " Rasmus Villemoes
2022-11-16 13:40 ` Andrew Lunn
2022-11-16 16:22 ` Florian Fainelli
2022-11-16 10:52 ` [PATCH v3 2/3] net: dsa: use NET_NAME_PREDICTABLE for user ports with name given in DT Rasmus Villemoes
2022-11-16 13:41 ` Andrew Lunn
2022-11-16 16:22 ` Florian Fainelli
2022-11-16 10:52 ` [PATCH v3 3/3] net: dsa: set name_assign_type to NET_NAME_ENUM for enumerated user ports Rasmus Villemoes
2022-11-16 13:42 ` Andrew Lunn
2022-11-16 16:23 ` Florian Fainelli
2022-11-18 4:50 ` [PATCH v3 0/3] net: dsa: use more appropriate NET_NAME_* constants for " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221115083828.06cebab1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.