From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82D6CC433FE for ; Tue, 15 Nov 2022 17:59:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232203AbiKOR7I (ORCPT ); Tue, 15 Nov 2022 12:59:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232592AbiKOR6P (ORCPT ); Tue, 15 Nov 2022 12:58:15 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B89CA303CD for ; Tue, 15 Nov 2022 09:58:14 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CF0BC13D5; Tue, 15 Nov 2022 09:58:20 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B31353F587; Tue, 15 Nov 2022 09:58:13 -0800 (PST) Date: Tue, 15 Nov 2022 17:58:11 +0000 From: Andre Przywara To: Fuad Tabba Cc: kvm@vger.kernel.org, julien.thierry.kdev@gmail.com, alexandru.elisei@arm.com, will@kernel.org Subject: Re: [PATCH kvmtool v1 02/17] Make mmap_hugetlbfs() static Message-ID: <20221115175811.44b6e98e@donnerap.cambridge.arm.com> In-Reply-To: <20221115111549.2784927-3-tabba@google.com> References: <20221115111549.2784927-1-tabba@google.com> <20221115111549.2784927-3-tabba@google.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 15 Nov 2022 11:15:34 +0000 Fuad Tabba wrote: > This function isn't used outside of util.c. > > No functional change intended. I am not sure if it was once intended to be public, but it's indeed not used outside, and it looks like we lose this function anyway, so: > Signed-off-by: Fuad Tabba Reviewed-by: Andre Przywara Cheers, Andre > --- > include/kvm/util.h | 1 - > util/util.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/kvm/util.h b/include/kvm/util.h > index b494548..b0c3684 100644 > --- a/include/kvm/util.h > +++ b/include/kvm/util.h > @@ -140,7 +140,6 @@ static inline int pow2_size(unsigned long x) > } > > struct kvm; > -void *mmap_hugetlbfs(struct kvm *kvm, const char *htlbfs_path, u64 size); > void *mmap_anon_or_hugetlbfs(struct kvm *kvm, const char *hugetlbfs_path, u64 size); > > #endif /* KVM__UTIL_H */ > diff --git a/util/util.c b/util/util.c > index 1877105..093bd3b 100644 > --- a/util/util.c > +++ b/util/util.c > @@ -81,7 +81,7 @@ void die_perror(const char *s) > exit(1); > } > > -void *mmap_hugetlbfs(struct kvm *kvm, const char *htlbfs_path, u64 size) > +static void *mmap_hugetlbfs(struct kvm *kvm, const char *htlbfs_path, u64 size) > { > char mpath[PATH_MAX]; > int fd;