All of lore.kernel.org
 help / color / mirror / Atom feed
* [merged mm-nonmm-stable] llist-avoid-extra-memory-read-in-llist_add_batch.patch removed from -mm tree
@ 2022-11-15 22:31 Andrew Morton
  0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2022-11-15 22:31 UTC (permalink / raw)
  To: mm-commits, ubizjak, akpm


The quilt patch titled
     Subject: llist: avoid extra memory read in llist_add_batch
has been removed from the -mm tree.  Its filename was
     llist-avoid-extra-memory-read-in-llist_add_batch.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Uros Bizjak <ubizjak@gmail.com>
Subject: llist: avoid extra memory read in llist_add_batch
Date: Mon, 17 Oct 2022 16:52:26 +0200

try_cmpxchg implicitly assigns old head->first value to "first" when
cmpxchg fails. There is no need to re-read the value in the loop.

Link: https://lkml.kernel.org/r/20221017145226.4044-1-ubizjak@gmail.com
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 lib/llist.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/lib/llist.c~llist-avoid-extra-memory-read-in-llist_add_batch
+++ a/lib/llist.c
@@ -26,10 +26,10 @@
 bool llist_add_batch(struct llist_node *new_first, struct llist_node *new_last,
 		     struct llist_head *head)
 {
-	struct llist_node *first;
+	struct llist_node *first = READ_ONCE(head->first);
 
 	do {
-		new_last->next = first = READ_ONCE(head->first);
+		new_last->next = first;
 	} while (!try_cmpxchg(&head->first, &first, new_first));
 
 	return !first;
_

Patches currently in -mm which might be from ubizjak@gmail.com are



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-11-15 22:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-15 22:31 [merged mm-nonmm-stable] llist-avoid-extra-memory-read-in-llist_add_batch.patch removed from -mm tree Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.