From: Christoph Hellwig <hch@lst.de>
To: Mike Christie <michael.christie@oracle.com>
Cc: kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me,
martin.petersen@oracle.com, jejb@linux.ibm.com,
linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH v2 4/4] nvme: Convert NVMe errors to PR errors
Date: Wed, 16 Nov 2022 07:40:42 +0100 [thread overview]
Message-ID: <20221116064042.GC19581@lst.de> (raw)
In-Reply-To: <20221115212825.7945-5-michael.christie@oracle.com>
On Tue, Nov 15, 2022 at 03:28:25PM -0600, Mike Christie wrote:
> This converts the NVMe errors we commonly see during PR handling to PR_STS
> errors or -Exyz errors. pr_ops callers can then handle scsi and nvme errors
> without knowing the device types.
Looks fine, although the improvement suggested by Chaitanya would be
nice:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2022-11-16 6:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 21:28 [PATCH v2 0/4] block/scsi/nvme: Add error codes for PR ops Mike Christie
2022-11-15 21:28 ` [PATCH v2 1/4] block: Add error codes for common PR failures Mike Christie
2022-11-16 0:59 ` Chaitanya Kulkarni
2022-11-16 6:38 ` Christoph Hellwig
2022-11-15 21:28 ` [PATCH v2 2/4] scsi: Rename status_byte to sg_status_byte Mike Christie
2022-11-16 1:00 ` Chaitanya Kulkarni
2022-11-16 6:39 ` Christoph Hellwig
2022-11-15 21:28 ` [PATCH v2 3/4] scsi: Convert SCSI errors to PR errors Mike Christie
2022-11-16 1:01 ` Chaitanya Kulkarni
2022-11-15 21:28 ` [PATCH v2 4/4] nvme: Convert NVMe " Mike Christie
2022-11-16 1:09 ` Chaitanya Kulkarni
2022-11-16 6:40 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116064042.GC19581@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=jejb@linux.ibm.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.