From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Aleksandr Miloserdov <a.miloserdov@yadro.com>,
Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, linux@yadro.com,
Konstantin Shelekhin <k.shelekhin@yadro.com>,
Dmitriy Bogdanov <d.bogdanov@yadro.com>
Subject: Re: [PATCH v2 1/2] nvmet: expose IEEE OUI to configfs
Date: Wed, 16 Nov 2022 07:58:38 +0100 [thread overview]
Message-ID: <20221116065838.GA19952@lst.de> (raw)
In-Reply-To: <1243d214-e399-237f-e70d-bb4541a66b28@grimberg.me>
On Tue, Nov 15, 2022 at 04:05:14PM +0200, Sagi Grimberg wrote:
>> index c8a061ce3ee5..48a2f587f38a 100644
>> --- a/drivers/nvme/target/admin-cmd.c
>> +++ b/drivers/nvme/target/admin-cmd.c
>> @@ -372,6 +372,8 @@ static void nvmet_execute_identify_ctrl(struct nvmet_req *req)
>> memcpy_and_pad(id->fr, sizeof(id->fr),
>> UTS_RELEASE, strlen(UTS_RELEASE), ' ');
>> + put_unaligned_le24(subsys->ieee_oui, id->ieee);
>> +
>
> Any particular reason why it is placed here and not where the comment
> was?
Keeping the ID assignment together seems pretty reasonable to me.
next prev parent reply other threads:[~2022-11-16 6:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 11:58 [PATCH v2 0/2] Allow user to set nvmet firmware revision and IEEE OUI Aleksandr Miloserdov
2022-11-15 11:58 ` [PATCH v2 1/2] nvmet: expose IEEE OUI to configfs Aleksandr Miloserdov
2022-11-15 14:05 ` Sagi Grimberg
2022-11-16 6:58 ` Christoph Hellwig [this message]
2022-11-16 11:58 ` Aleksandr Miloserdov
2022-11-20 11:36 ` Sagi Grimberg
2022-11-15 11:58 ` [PATCH v2 2/2] nvmet: expose firmware revision " Aleksandr Miloserdov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116065838.GA19952@lst.de \
--to=hch@lst.de \
--cc=a.miloserdov@yadro.com \
--cc=d.bogdanov@yadro.com \
--cc=k.shelekhin@yadro.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux@yadro.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.