From: Stephen Hemminger <stephen@networkplumber.org>
To: Junxiao Shi <git@mail1.yoursunny.com>
Cc: dev@dpdk.org
Subject: Re: [RFC PATCH v2] net/memif: change socket listener owner uid/gid
Date: Wed, 16 Nov 2022 09:04:46 -0800 [thread overview]
Message-ID: <20221116090446.1e2c67a9@hermes.local> (raw)
In-Reply-To: <c079ae42cce57a45@cs.arizona.edu>
On Wed, 16 Nov 2022 13:09:20 +0000
Junxiao Shi <git@mail1.yoursunny.com> wrote:
> +static int
> +memif_set_owner(const char *key, const char *value, void *extra_args)
> +{
> + static_assert(sizeof(uid_t) == sizeof(uint32_t), "");
> + static_assert(sizeof(gid_t) == sizeof(uint32_t), "");
Use RTE_ASSERT() for these
> + uint32_t *id = (uint32_t *)extra_args;
> +
> + char *end = NULL;
> + unsigned long val = strtoul(value, &end, 10);
The DPDK style inherited from Linux kernel is to have blank line
after declarations.
next prev parent reply other threads:[~2022-11-16 17:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 20:44 [RFC PATCH] net/memif: change socket listener owner uid/gid Junxiao Shi
2022-11-15 23:53 ` Stephen Hemminger
2022-11-16 13:09 ` [RFC PATCH v2] " Junxiao Shi
2022-11-16 17:04 ` Stephen Hemminger [this message]
2022-11-16 17:14 ` [RFC PATCH v3] " Junxiao Shi
2022-11-16 17:14 ` [PATCH] " Junxiao Shi
2022-12-07 14:28 ` Ferruh Yigit
2022-12-07 14:41 ` [PATCH v2] " Junxiao Shi
2022-12-07 15:43 ` Ferruh Yigit
2022-12-07 16:56 ` Ferruh Yigit
2022-12-07 17:48 ` Junxiao Shi
2022-12-08 14:29 ` Ferruh Yigit
2022-12-07 15:53 ` [PATCH v3] " Junxiao Shi
2022-12-08 16:25 ` Ferruh Yigit
2022-12-08 16:25 ` Ferruh Yigit
2022-11-16 17:52 ` [RFC PATCH " Stephen Hemminger
2022-12-07 11:43 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116090446.1e2c67a9@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=git@mail1.yoursunny.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.