Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add IMX519 CMOS sensor binding

[lee <lee@arducam.com>]

On Fri, 4 Nov 2022 09:17:15 -0400
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 04/11/2022 03:26, lee wrote:
> > Add YAML device tree binding for IMX519 CMOS image sensor, and
> > the relevant MAINTAINERS entries.
> > 
> > Signed-off-by: Lee Jackson <lee@arducam.com>
> > ---
> >  .../bindings/media/i2c/sony,imx519.yaml       | 107
> > ++++++++++++++++++ MAINTAINERS                                   |
> >  9 ++ 2 files changed, 116 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml
> > b/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new
> > file mode 100644 index 000000000000..9b6cda96f613 --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml
> > @@ -0,0 +1,107 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/i2c/sony,imx519.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor
> > +
> > +maintainers:
> > +  - Lee Jackson <lee@arducam.com>
> > +
> > +description: |-
> > +  The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital image
> > sensor
> > +  with an active array size of 4656H x 3496V. It is programmable
> > through
> > +  I2C interface. The I2C address is fixed to 0x1A as per sensor
> > data sheet.
> > +  Image data is sent through MIPI CSI-2, which is configured as
> > either 2 or
> > +  4 data lanes.
> > +
> > +properties:
> > +  compatible:
> > +    const: sony,imx519
> > +
> > +  reg:
> > +    description: I2C device address  
> 
> This is a friendly reminder during the review process.
> 
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply
> it. Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
> 
> Thank you.
> 
> Best regards,
> Krzysztof
> 

Hi,
Thanks for your friendly reminder. Sorry for my last error commit. I have modified the dts based on your comments and resubmitted new driver. 
I have checked it using make dt_binding_check command. 
You are welcome to submit new comments again.
Have a nice day.
Lee.