From: Lukas Wunner <lukas@wunner.de>
To: Li Ming <ming4.li@intel.com>
Cc: bhelgaas@google.com, Jonathan.Cameron@huawei.com,
ira.weiny@intel.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH V2 1/1] PCI/DOE: Fix maximum data object length miscalculation
Date: Wed, 16 Nov 2022 10:44:00 +0100 [thread overview]
Message-ID: <20221116094400.GA18061@wunner.de> (raw)
In-Reply-To: <20221116015637.3299664-1-ming4.li@intel.com>
On Wed, Nov 16, 2022 at 09:56:37AM +0800, Li Ming wrote:
> The value of data object length 0x0 indicates 2^18 dwords being
> transferred.
A spec reference would be nice, e.g.:
"According to PCIe r6.0.1 sec 6.30.1 table 6-29, the value of ..."
> This patch adjusts the value of data object length for the
> above case on both sending side and receiving side.
Nit: Generally phrases like "This patch ..." should be avoided.
Use imperative mood instead, e.g.: "Adjust the value ..."
> Signed-off-by: Li Ming <ming4.li@intel.com>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
Thanks,
Lukas
next prev parent reply other threads:[~2022-11-16 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 1:56 [PATCH V2 1/1] PCI/DOE: Fix maximum data object length miscalculation Li Ming
2022-11-16 9:37 ` Jonathan Cameron
2022-11-16 9:44 ` Lukas Wunner [this message]
2022-11-16 18:02 ` Bjorn Helgaas
2022-11-16 18:07 ` Bjorn Helgaas
2022-11-16 18:56 ` Lukas Wunner
2022-11-16 20:29 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116094400.GA18061@wunner.de \
--to=lukas@wunner.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=ira.weiny@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=ming4.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.