From: Stephen Hemminger <stephen@networkplumber.org>
To: Lai Peter Jun Ann <jun.ann.lai@intel.com>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Subject: Re: [PATCH iproute2-next v1] tc_util: Fix no error return when large parent id used
Date: Thu, 17 Nov 2022 08:35:37 -0800 [thread overview]
Message-ID: <20221117083537.6aceb759@hermes.local> (raw)
In-Reply-To: <1668663197-22115-1-git-send-email-jun.ann.lai@intel.com>
On Thu, 17 Nov 2022 13:33:17 +0800
Lai Peter Jun Ann <jun.ann.lai@intel.com> wrote:
> This patch is to fix the issue where there is no error return
> when large value of parent ID is being used. The return value by
> stroul() is unsigned long int. Hence the datatype for maj and min
> should defined as unsigned long to avoid overflow issue.
>
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> Signed-off-by: Lai Peter Jun Ann <jun.ann.lai@intel.com>
Yes, looks good. Will apply to main.
What about qdisc_handle as well?
next prev parent reply other threads:[~2022-11-17 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 5:33 [PATCH iproute2-next v1] tc_util: Fix no error return when large parent id used Lai Peter Jun Ann
2022-11-17 16:35 ` Stephen Hemminger [this message]
2022-11-21 2:26 ` Lai, Peter Jun Ann
2022-11-23 17:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221117083537.6aceb759@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=jun.ann.lai@intel.com \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=netdev@vger.kernel.org \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.