From: Kees Cook <keescook@chromium.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
will@kernel.org
Subject: Re: [PATCH 1/2] arm64: remove current_top_of_stack()
Date: Thu, 17 Nov 2022 14:09:00 -0800 [thread overview]
Message-ID: <202211171408.D9C4DE6BA@keescook> (raw)
In-Reply-To: <20221117120902.3974163-2-mark.rutland@arm.com>
On Thu, Nov 17, 2022 at 12:09:01PM +0000, Mark Rutland wrote:
> We no longer use current_top_of_stack() on arm64, so it can be removed.
>
> We introduced current_top_of_stack() for STACKLEAK in commit:
>
> 0b3e336601b82c6a ("arm64: Add support for STACKLEAK gcc plugin")
>
> ... then we figured out the intended semantics were unclear, and
> reworked it in commit:
>
> e85094c31ddb794a ("arm64: stackleak: fix current_top_of_stack()")
>
> ... then we removed the only user in commit:
>
> 0cfa2ccd285d98ad ("stackleak: rework stack high bound handling")
>
> Given that it's no longer used, and it's very easy to misuse, this patch
> removes current_top_of_stack(). For the moment, on_thread_stack() is
> left where it is as moving it will change some header dependencies.
>
> There should be no functional change as a result of this patch.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-17 22:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 12:09 [PATCH 0/2] arm64: stack helper cleanups Mark Rutland
2022-11-17 12:09 ` [PATCH 1/2] arm64: remove current_top_of_stack() Mark Rutland
2022-11-17 15:46 ` Mark Brown
2022-11-17 22:09 ` Kees Cook [this message]
2022-11-17 12:09 ` [PATCH 2/2] arm64: move on_thread_stack() to <asm/stacktrace.h> Mark Rutland
2022-11-17 15:47 ` Mark Brown
2022-11-17 22:09 ` Kees Cook
2022-11-18 19:40 ` [PATCH 0/2] arm64: stack helper cleanups Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202211171408.D9C4DE6BA@keescook \
--to=keescook@chromium.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.