From: Jakub Kicinski <kuba@kernel.org>
To: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
Cc: netdev@vger.kernel.org, mkubecek@suse.cz, andrew@lunn.ch,
corbet@lwn.net, sridhar.samudrala@intel.com,
anthony.l.nguyen@intel.com
Subject: Re: [PATCH net-next v3] ethtool: add netlink based get rss support
Date: Thu, 17 Nov 2022 20:08:45 -0800 [thread overview]
Message-ID: <20221117200845.5eb5b81a@kernel.org> (raw)
In-Reply-To: <20221116232554.310466-1-sudheer.mogilappagari@intel.com>
On Wed, 16 Nov 2022 15:25:54 -0800 Sudheer Mogilappagari wrote:
> +RSS_GET
> +========
One too many =
> + {
> + .cmd = ETHTOOL_MSG_RSS_GET,
> + .doit = ethnl_default_doit,
> + .start = ethnl_default_start,
> + .done = ethnl_default_done,
start and done are part of the dump procedure, since we have no dump
now I think we should drop those
> + .policy = ethnl_rss_get_policy,
> + .maxattr = ARRAY_SIZE(ethnl_rss_get_policy) - 1,
> + },
> };
next prev parent reply other threads:[~2022-11-18 4:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 23:25 [PATCH net-next v3] ethtool: add netlink based get rss support Sudheer Mogilappagari
2022-11-17 3:12 ` Michal Kubecek
2022-11-18 4:08 ` Jakub Kicinski [this message]
2022-11-18 10:38 ` Francois Romieu
2022-11-20 8:40 ` Mogilappagari, Sudheer
2022-11-20 15:37 ` Francois Romieu
2022-11-20 21:02 ` Michal Kubecek
2022-11-21 18:58 ` Jakub Kicinski
2022-11-23 19:05 ` Mogilappagari, Sudheer
-- strict thread matches above, loose matches on Subject: below --
2022-11-18 13:09 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221117200845.5eb5b81a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.