From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org, Chao.Xu9@zeekrlife.com,
akpm@linux-foundation.org
Subject: [failures] mm-vmstat-correct-some-wrong-comments-based-on-fls.patch removed from -mm tree
Date: Thu, 17 Nov 2022 12:14:36 -0800 [thread overview]
Message-ID: <20221117201437.15162C433D6@smtp.kernel.org> (raw)
The quilt patch titled
Subject: mm/vmstat: correct some wrong comments based-on fls()
has been removed from the -mm tree. Its filename was
mm-vmstat-correct-some-wrong-comments-based-on-fls.patch
This patch was dropped because it had testing failures
------------------------------------------------------
From: Chao Xu <Chao.Xu9@zeekrlife.com>
Subject: mm/vmstat: correct some wrong comments based-on fls()
Date: Sat, 29 Oct 2022 12:44:36 +0800
The threshold should grow logarithmically, using fls() as an easy
approximation. But there are some errors in fls(mem) and fls(Processors).
It is misleading so let's correct it.
Link: https://lkml.kernel.org/r/20221029044436.198169-1-xuchao066@163.com
Signed-off-by: Chao Xu <Chao.Xu9@zeekrlife.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/vmstat.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
--- a/mm/vmstat.c~mm-vmstat-correct-some-wrong-comments-based-on-fls
+++ a/mm/vmstat.c
@@ -241,17 +241,17 @@ int calculate_normal_threshold(struct zo
* 28 2 2 4-8 GB 7
* 32 2 2 8-16 GB 8
* 4 2 2 <128M 1
- * 30 4 3 2-4 GB 5
+ * 30 4 3 2-4 GB 6
* 48 4 3 8-16 GB 8
- * 32 8 4 1-2 GB 4
+ * 32 8 4 1-2 GB 5
* 32 8 4 0.9-1GB 4
* 10 16 5 <128M 1
* 40 16 5 900M 4
- * 70 64 7 2-4 GB 5
- * 84 64 7 4-8 GB 6
- * 108 512 9 4-8 GB 6
- * 125 1024 10 8-16 GB 8
- * 125 1024 10 16-32 GB 9
+ * 70 64 7 2-4 GB 6
+ * 84 64 7 4-8 GB 7
+ * 108 512 10 4-8 GB 7
+ * 125 1024 11 8-16 GB 8
+ * 125 1024 11 16-32 GB 9
*/
mem = zone_managed_pages(zone) >> (27 - PAGE_SHIFT);
_
Patches currently in -mm which might be from Chao.Xu9@zeekrlife.com are
reply other threads:[~2022-11-17 20:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221117201437.15162C433D6@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=Chao.Xu9@zeekrlife.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.