All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Collin <collin@burrougc.net>,
	linux-kernel@vger.kernel.org,
	Network Development <netdev@vger.kernel.org>
Subject: Re: Missing generic netlink controller operations
Date: Thu, 17 Nov 2022 20:45:59 -0800	[thread overview]
Message-ID: <20221117204559.4ab9e4f8@kernel.org> (raw)
In-Reply-To: <8baab0a4-aa71-2fd9-d3cd-93daf1d792cb@infradead.org>

On Thu, 17 Nov 2022 08:38:40 -0800 Randy Dunlap wrote:
> [change linux-netdev@ to netdev@]
> 
> On 11/16/22 19:54, Collin wrote:
> > While messing around with libnl and netlink I noticed that despite
> > existing in an enum in linux/genetlink.h, the
> > CTRL_CMD_{NEW,DEL,GET}OPS operations (and in fact, all operations
> > except for
> > CTRL_CMD_{NEWFAMILY,DELFAMILY,NEWMCAST_GRP,DELMCAST_GRP}) are
> > unimplemented, and have been around, untouched, since the
> > introduction of the generic netlink family. Is there a reason these
> > exist without implementation, or has it simply not been done?  

Only CTRL_CMD_GETMCAST_GRP was never used AFAIU, it was likely added
to maintain the triplet cadence (NEW,DEL,GET); probably cargo cult /
inspired by the classic netlink / rtnl.

Ops used to be more dynamic, and separately registered, I think.
Which found no real life use, so that option was dropped and now
all ops must be statically defined for the family at family
registration time.

      reply	other threads:[~2022-11-18  4:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17  3:54 Missing generic netlink controller operations Collin
2022-11-17 16:38 ` Randy Dunlap
2022-11-18  4:45   ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221117204559.4ab9e4f8@kernel.org \
    --to=kuba@kernel.org \
    --cc=collin@burrougc.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.