From: Christoph Hellwig <hch@lst.de>
To: David Sterba <dsterba@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Qu Wenruo <wqu@suse.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] btrfs: move struct btrfs_tree_parent_check out of disk-io.h
Date: Sun, 20 Nov 2022 13:41:14 +0100 [thread overview]
Message-ID: <20221120124114.GA7245@lst.de> (raw)
In-Reply-To: <20221118140722.GO5824@twin.jikos.cz>
On Fri, Nov 18, 2022 at 03:07:23PM +0100, David Sterba wrote:
> On Tue, Nov 15, 2022 at 10:44:04AM +0100, Christoph Hellwig wrote:
> > Move struct btrfs_tree_parent_check out of disk-io.h so that volumes.h
> > an various .c files don't have to include disk-io.h just for it.
>
> Splitting that from disk-io.h makes sense but why creating a new file
> that has just the one structure?
Because there is no other header where it obviously fits.
> We have the tree-checker.h that seems
> like a place for various checks so I'll move it there.
Despite the similar naming there's actually no overlap between the
functionality offered in tree-checker.h and these uses of
struct btrfs_tree_parent_check at all.
next prev parent reply other threads:[~2022-11-20 12:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 9:44 move the low-level btrfs_bio code into a separate file v3 Christoph Hellwig
2022-11-15 9:44 ` [PATCH 1/3] btrfs: move struct btrfs_tree_parent_check out of disk-io.h Christoph Hellwig
2022-11-15 14:38 ` Josef Bacik
2022-11-18 14:07 ` David Sterba
2022-11-20 12:41 ` Christoph Hellwig [this message]
2022-11-23 17:17 ` David Sterba
2022-11-15 9:44 ` [PATCH 2/3] btrfs: split the bio submission path into a separate file Christoph Hellwig
2022-11-15 9:44 ` [PATCH 3/3] btrfs: move repair_io_failure to bio.c Christoph Hellwig
2022-11-18 16:01 ` move the low-level btrfs_bio code into a separate file v3 David Sterba
-- strict thread matches above, loose matches on Subject: below --
2022-11-13 16:24 move the low-level btrfs_bio code into a separate file v2 Christoph Hellwig
2022-11-13 16:24 ` [PATCH 1/3] btrfs: move struct btrfs_tree_parent_check out of disk-io.h Christoph Hellwig
2022-11-13 22:28 ` Qu Wenruo
2022-11-14 8:06 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221120124114.GA7245@lst.de \
--to=hch@lst.de \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.