From: Rob Herring <robh@kernel.org>
To: Yinbo Zhu <zhuyinbo@loongson.cn>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Wolfram Sang <wsa@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Jean Delvare <jdelvare@suse.de>,
William Zhang <william.zhang@broadcom.com>,
Conor Dooley <conor.dooley@microchip.com>,
Jan Dabros <jsd@semihalf.com>,
Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
Tyrone Ting <kfting@nuvoton.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] dt-bindings: i2c: add loongson i2c
Date: Sun, 20 Nov 2022 11:23:48 -0600 [thread overview]
Message-ID: <20221120172348.GA3217015-robh@kernel.org> (raw)
In-Reply-To: <20221117075938.23379-2-zhuyinbo@loongson.cn>
On Thu, Nov 17, 2022 at 03:59:38PM +0800, Yinbo Zhu wrote:
> Add the Loongson platform i2c binding with DT schema format using
> json-schema.
>
> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
> ---
> .../bindings/i2c/loongson,ls-i2c.yaml | 49 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/loongson,ls-i2c.yaml
>
> diff --git a/Documentation/devicetree/bindings/i2c/loongson,ls-i2c.yaml b/Documentation/devicetree/bindings/i2c/loongson,ls-i2c.yaml
> new file mode 100644
> index 000000000000..275afe8c8483
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/loongson,ls-i2c.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/loongson,ls-i2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Loongson I2C controller
> +
> +maintainers:
> + - Yinbo Zhu <zhuyinbo@loongson.cn>
> +
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - loongson,ls2k-i2c
> + - loongson,ls7a-i2c
> +
> + interrupts:
> + maxItems: 1
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - "#address-cells"
> + - "#size-cells"
You can drop these 2. i2c-controller.yaml requires them.
With that,
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-11-20 17:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 7:59 [PATCH v1 1/2] i2c: loongson: add bus driver for the loongson i2c controller Yinbo Zhu
2022-11-17 7:59 ` [PATCH v1 2/2] dt-bindings: i2c: add loongson i2c Yinbo Zhu
2022-11-20 17:23 ` Rob Herring [this message]
2022-11-17 8:28 ` [PATCH v1 1/2] i2c: loongson: add bus driver for the loongson i2c controller Andy Shevchenko
2022-11-17 8:35 ` Wolfram Sang
2022-11-17 8:47 ` Andy Shevchenko
2022-11-17 8:44 ` Andy Shevchenko
2022-11-28 13:13 ` Yinbo Zhu
2022-11-28 13:25 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221120172348.GA3217015-robh@kernel.org \
--to=robh@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=jsd@semihalf.com \
--cc=kfting@nuvoton.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=phil.edworthy@renesas.com \
--cc=semen.protsenko@linaro.org \
--cc=tharunkumar.pasumarthi@microchip.com \
--cc=william.zhang@broadcom.com \
--cc=wsa@kernel.org \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.