From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50CE3C4332F for ; Mon, 21 Nov 2022 06:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hXaKqvxMevRYgiL6AGjK2JMBK30DBpgjzTQguhI8avA=; b=MpGFKrwByDMQ6P xeQgiMvxDA9j4FAfnaNIhvEgLCmA6+F/Dwb4xAIo8MkwgWUmqgVtn2Z/x3GkMVUWazbcGNp0Wd8r+ 0923kSslnApn9lqPxq8Nlp+TE9iRE25p+hNfXQvHsNFp3oEdJkO+pIZLy3coDlswU9d7hAit9gqPd lX9tgs0Y3oNAFNGGGk3G0S0ugzOhEItsrzsktB42noUEIm5N3TomSdY8lUZRfZU9FVeP8tFg+7Ugv haWoWJ6RG3XsiZzl7D3UTiNS9fPF0YDgEDybPFtb6dRc5ecNdc1r/RLo1cdPLKrLEwxIc73KxbIIw xM8czeN1AaqT65kNDwhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ox0Vp-009ule-R5; Mon, 21 Nov 2022 06:42:37 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ox0Vl-009uhb-FV for linux-arm-kernel@lists.infradead.org; Mon, 21 Nov 2022 06:42:35 +0000 Received: by mail-pg1-x529.google.com with SMTP id 6so10296526pgm.6 for ; Sun, 20 Nov 2022 22:42:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Ka6Q0Zy6QrfcwL/CSvIzpjvnD4BQcyLVYFcLJW2zm44=; b=eNAoMx9XYSD3E6TlqY/LO/eSe6DOJcSXrUsT2o3LX4RdBXicRWFCc+ECtGK8SsDC1X VTsgWPxoc30xplkGVv1b7y3+pkV7YUtn0zAcD5K/0LwThmy2aoomAPeK+y8UbPt7Axms Ug5VwOfkOb4YhyLAzewvgsAilQSOERs6Pr6tnfHR/CQ8blUy63w4uHO+adl9VXd+0l+m x2JoaaU0KR0xXZ/AHvUoe9UM3qM9KB/gV9KYQUbjjb+KaFjt7B4kvj5ow3v+iWHxzQPh E0kFS1P/FMAd07AMV1hSAVve3yRanQo34vG0NU++2Hfmzs/rOdVk2SsysmCBF+mno6V3 N9nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ka6Q0Zy6QrfcwL/CSvIzpjvnD4BQcyLVYFcLJW2zm44=; b=1hGXHx9MI9fKsarTXXO7oYz++BK5m4uYcfj2mIfjzHu5QdMSI1KwPqsKpplyvNmSWY FYhmQWirvTIMj024ER0X2a+fjexORzIPmSYTTO+1pLlBbzVKxyv7IE53i7WNXnUZJ/IH U62Po1Vuo/brCt7FGk7z38Tw5b977jqtzBdQtlPazPCdVqj6z6X1SCfeLW+vhrB6/YpP oBXtj7LfYyb9JPxdd7Iteof6vfRv0h7WKNTw4iefkeSzOznZJQSUh/fR5ilWyQT2Ds2q sa3CXKqiupDryWh366vedFOz1VkRM5wnL+Q6BodFwPFkEXweiPJmUnya1TDUS9beQCtJ By4g== X-Gm-Message-State: ANoB5pknHL3ob6h8xctR4wfnppo/pwUtDtOStlhopjnNd1lowrmETYZW YGzsk0HRaFGn71Ba0uhquCZD X-Google-Smtp-Source: AA0mqf6SOw1bsMBSVvaKIDjRLtE0EG36yQRvgTWvQZmk5KxiBImOnTVz2U4HWOVmlCqxSJmqBWrIVw== X-Received: by 2002:aa7:81d8:0:b0:561:c694:80b with SMTP id c24-20020aa781d8000000b00561c694080bmr18994198pfn.47.1669012948034; Sun, 20 Nov 2022 22:42:28 -0800 (PST) Received: from thinkpad ([59.92.99.222]) by smtp.gmail.com with ESMTPSA id b8-20020a170903228800b0016c9e5f291bsm8914094plh.111.2022.11.20.22.42.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Nov 2022 22:42:27 -0800 (PST) Date: Mon, 21 Nov 2022 12:12:24 +0530 From: Manivannan Sadhasivam To: Will Deacon Cc: Catalin Marinas , Robin Murphy , amit.pundir@linaro.org, andersson@kernel.org, quic_sibis@quicinc.com, sumit.semwal@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "arm64: dma: Drop cache invalidation from arch_dma_prep_coherent()" Message-ID: <20221121064224.GB11945@thinkpad> References: <20221114110329.68413-1-manivannan.sadhasivam@linaro.org> <20221114141109.GG30263@willie-the-truck> <1659929b-1372-cea6-5840-c58369a4252d@arm.com> <20221118105402.GA184726@thinkpad> <20221118123349.GC3697@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221118123349.GC3697@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221120_224233_647242_9E3822AE X-CRM114-Status: GOOD ( 36.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBOb3YgMTgsIDIwMjIgYXQgMTI6MzM6NDlQTSArMDAwMCwgV2lsbCBEZWFjb24gd3Jv dGU6Cj4gT24gRnJpLCBOb3YgMTgsIDIwMjIgYXQgMDQ6MjQ6MDJQTSArMDUzMCwgTWFuaXZhbm5h biBTYWRoYXNpdmFtIHdyb3RlOgo+ID4gT24gTW9uLCBOb3YgMTQsIDIwMjIgYXQgMDU6Mzg6MDBQ TSArMDAwMCwgQ2F0YWxpbiBNYXJpbmFzIHdyb3RlOgo+ID4gPiBPbiBNb24sIE5vdiAxNCwgMjAy MiBhdCAwMzoxNDoyMVBNICswMDAwLCBSb2JpbiBNdXJwaHkgd3JvdGU6Cj4gPiA+ID4gT24gMjAy Mi0xMS0xNCAxNDoxMSwgV2lsbCBEZWFjb24gd3JvdGU6Cj4gPiA+ID4gPiBPbiBNb24sIE5vdiAx NCwgMjAyMiBhdCAwNDozMzoyOVBNICswNTMwLCBNYW5pdmFubmFuIFNhZGhhc2l2YW0gd3JvdGU6 Cj4gPiA+ID4gPiA+IFRoaXMgcmV2ZXJ0cyBjb21taXQgYzQ0MDk0ZWVlMzJmMzJmMTc1YWFkYzBl ZmNhYzQ0OWQ5OWIxYmJmNy4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IEFzIHJlcG9ydGVkIGJ5 IEFtaXQgWzFdLCBkcm9wcGluZyBjYWNoZSBpbnZhbGlkYXRpb24gZnJvbQo+ID4gPiA+ID4gPiBh cmNoX2RtYV9wcmVwX2NvaGVyZW50KCkgdHJpZ2dlcnMgYSBjcmFzaCBvbiB0aGUgUXVhbGNvbW0g U004MjUwIHBsYXRmb3JtCj4gPiA+ID4gPiA+IChtb3N0IHByb2JhYmx5IG9uIG90aGVyIFFjb20g cGxhdGZvcm1zIHRvbykuIFRoZSByZWFzb24gaXMsIFFjb20KPiA+ID4gPiA+ID4gcWNvbV9xNnY1 X21zcyBkcml2ZXIgY29waWVzIHRoZSBmaXJtd2FyZSBtZXRhZGF0YSBhbmQgc2hhcmVzIGl0IHdp dGggbW9kZW0KPiA+ID4gPiA+ID4gZm9yIHZhbGlkYXRpb24uIFRoZSBtb2RlbSBoYXMgYSBzZWN1 cmUgYmxvY2sgKFhQVSkgdGhhdCB3aWxsIHRyaWdnZXIgYQo+ID4gPiA+ID4gPiB3aG9sZSBzeXN0 ZW0gY3Jhc2ggaWYgdGhlIHNoYXJlZCBtZW1vcnkgaXMgYWNjZXNzZWQgYnkgdGhlIENQVSB3aGls ZSBtb2RlbQo+ID4gPiA+ID4gPiBpcyBwb2tpbmcgYXQgaXQuCj4gPiA+ID4gPiA+IAo+ID4gPiA+ ID4gPiBUbyBhdm9pZCB0aGlzIGlzc3VlLCB0aGUgcWNvbV9xNnY1X21zcyBkcml2ZXIgYWxsb2Nh dGVzIGEgY2h1bmsgb2YgbWVtb3J5Cj4gPiA+ID4gPiA+IHdpdGggbm8ga2VybmVsIG1hcHBpbmcs IHZtYXAncyBpdCwgY29waWVzIHRoZSBmaXJtd2FyZSBtZXRhZGF0YSBhbmQKPiA+ID4gPiA+ID4g dW52bWFwJ3MgaXQuIEZpbmFsbHkgdGhlIGFkZHJlc3MgaXMgdGhlbiBzaGFyZWQgd2l0aCBtb2Rl bSBmb3IgbWV0YWRhdGEKPiA+ID4gPiA+ID4gdmFsaWRhdGlvbiBbMl0uCj4gPiA+ID4gPiA+IAo+ ID4gPiA+ID4gPiBOb3cgYmVjYXVzZSBvZiB0aGUgcmVtb3ZhbCBvZiBjYWNoZSBpbnZhbGlkYXRp b24gZnJvbQo+ID4gPiA+ID4gPiBhcmNoX2RtYV9wcmVwX2NvaGVyZW50KCksIHRoZXJlIHdpbGwg YmUgY2FjaGUgbGluZXMgYXNzb2NpYXRlZCB3aXRoIHRoaXMKPiA+ID4gPiA+ID4gbWVtb3J5IGV2 ZW4gYWZ0ZXIgc2hhcmluZyB3aXRoIG1vZGVtLiBTbyB3aGVuIHRoZSBDUFUgYWNjZXNzZXMgaXQs IHRoZSBYUFUKPiA+ID4gPiA+ID4gdmlvbGF0aW9uIGdldHMgdHJpZ2dlcmVkLgo+ID4gPiA+ID4g Cj4gPiA+ID4gPiBUaGlzIGxhc3QgcGFzdCBpcyBhIG5vbi1zZXF1aXR1cjogdGhlIGJ1ZmZlciBp cyBubyBsb25nZXIgbWFwcGVkIG9uIHRoZSBDUFUKPiA+ID4gPiA+IHNpZGUsIHNvIGhvdyB3b3Vs ZCB0aGUgQ1BVIGFjY2VzcyBpdD8KPiA+ID4gPiAKPiA+ID4gPiBSaWdodCwgZm9yIHRoZSBwcmV2 aW91cyBjaGFuZ2UgdG8gaGF2ZSBtYWRlIGEgZGlmZmVyZW5jZSB0aGUgb2ZmZW5kaW5nIHBhcnQK PiA+ID4gPiBvZiB0aGlzIGJ1ZmZlciBtdXN0IGJlIHByZXNlbnQgaW4gc29tZSBjYWNoZSBzb21l d2hlcmUgKmJlZm9yZSogdGhlIERNQQo+ID4gPiA+IGJ1ZmZlciBhbGxvY2F0aW9uIGNvbXBsZXRl cy4KPiA+ID4gPiAKPiA+ID4gPiBDbGVhcmx5IHRoYXQgZHJpdmVyIGlzIGNvbXBsZXRlbHkgYnJv a2VuIHRob3VnaC4gSWYgdGhlIERNQSBhbGxvY2F0aW9uIGNhbWUKPiA+ID4gPiBmcm9tIGEgbm8t bWFwIGNhcnZlb3V0IHZtYV9kbWFfYWxsb2NfZnJvbV9kZXZfY29oZXJlbnQoKSB0aGVuIHRoZSB2 bWFwKCkKPiA+ID4gPiBzaGVuYW5pZ2FucyB3b3VsZG4ndCB3b3JrLCBzbyBpZiBpdCBiYWNrZWQg Ynkgc3RydWN0IHBhZ2VzIHRoZW4gdGhlIHdob2xlCj4gPiA+ID4gZGFuY2UgaXMgc3RpbGwgcG9p bnRsZXNzIGJlY2F1c2UgKmEgY2FjaGVhYmxlIGxpbmVhciBtYXBwaW5nIGV4aXN0cyosIGFuZAo+ ID4gPiA+IGl0J3MganVzdCByZWx5aW5nIG9uIHRoZSByZWR1Y2VkIGNoYW5jZSB0aGF0IGFueXRo aW5nJ3MgZ29pbmcgdG8gcmUtZmV0Y2gKPiA+ID4gPiB0aGUgbGluZWFyIG1hcCBhZGRyZXNzIGFm dGVyIHRob3NlIHBhZ2VzIGhhdmUgYmVlbiBhbGxvY2F0ZWQsIGV4YWN0bHkgYXMgSQo+ID4gPiA+ IGNhbGxlZCBvdXQgcHJldmlvdXNseVsxXS4KPiA+ID4gCj4gPiA+IFNvIEkgZ3Vlc3MgYSBETUEg cG9vbCB0aGF0J3Mgbm90IG1hcHBlZCBpbiB0aGUgbGluZWFyIG1hcCwgdG9nZXRoZXIgd2l0aAo+ ID4gPiBtZW1yZW1hcCgpIGluc3RlYWQgb2Ygdm1hcCgpLCB3b3VsZCB3b3JrIGFyb3VuZCB0aGUg aXNzdWUuIEJ1dCB0aGUKPiA+ID4gZHJpdmVyIG5lZWRzIGZpeGluZywgbm90IHRoZSBhcmNoIGNv ZGUuCj4gPiA+IAo+ID4gCj4gPiBPa2F5LCB0aGFua3MgZm9yIHRoZSBoaW50LiBDYW4geW91IHNo YXJlIGhvdyB0byBhbGxvY2F0ZSB0aGUgZG1hLXBvb2wgdGhhdCdzCj4gPiBub3QgcGFydCBvZiB0 aGUga2VybmVsJ3MgbGluZWFyIG1hcD8gSSBsb29rZWQgaW50byBpdCBidXQgY291bGRuJ3QgZmlu ZCBhIHdheS4KPiAKPiBUaGUgbm8tbWFwIHByb3BlcnR5IHNob3VsZCB0YWtlIGNhcmUgb2YgdGhp cyBpaXJjCj4gCgpZZWFoLCB3ZSBoYXZlIGJlZW4gdXNpbmcgaXQgaW4gb3RoZXIgcGxhY2VzIG9m IHRoZSBzYW1lIGRyaXZlci4gQnV0IGFzIHBlcgpTaWJpLCB3ZSB1c2VkIGR5bmFtaWMgYWxsb2Nh dGlvbiBmb3IgbWV0YWRhdGEgdmFsaWRhdGlvbiBzaW5jZSB0aGVyZSB3YXMgbm8KbWVtb3J5IHJl c2VydmVkIHN0YXRpY2FsbHkgZm9yIHRoYXQuCgpCdXQgaWYgd2UgZG8gbm90IGhhdmUgYSB3YXkg dG8gYWxsb2NhdGUgYSBkeW5hbWljIG1lbW9yeSB0aGF0IGlzIG5vdCBwYXJ0IG9mCmtlcm5lbCdz IGxpbmVhciBtYXAsIHRoZW4gd2UgbWF5IGhhdmUgdG8gcmVzb3J0IHRvIHVzaW5nIGFuIGV4aXN0 aW5nIHJlc2VydmVkCm1lbW9yeS4KClRoYW5rcywKTWFuaQoKPiBXaWxsCgotLSAK4K6u4K6j4K6/ 4K614K6j4K+N4K6j4K6p4K+NIOCumuCupOCuvuCumuCuv+CuteCuruCvjQoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3599EC433FE for ; Mon, 21 Nov 2022 06:42:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229632AbiKUGmt (ORCPT ); Mon, 21 Nov 2022 01:42:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbiKUGmo (ORCPT ); Mon, 21 Nov 2022 01:42:44 -0500 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98C16EAF for ; Sun, 20 Nov 2022 22:42:28 -0800 (PST) Received: by mail-pf1-x430.google.com with SMTP id b29so10462022pfp.13 for ; Sun, 20 Nov 2022 22:42:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Ka6Q0Zy6QrfcwL/CSvIzpjvnD4BQcyLVYFcLJW2zm44=; b=eNAoMx9XYSD3E6TlqY/LO/eSe6DOJcSXrUsT2o3LX4RdBXicRWFCc+ECtGK8SsDC1X VTsgWPxoc30xplkGVv1b7y3+pkV7YUtn0zAcD5K/0LwThmy2aoomAPeK+y8UbPt7Axms Ug5VwOfkOb4YhyLAzewvgsAilQSOERs6Pr6tnfHR/CQ8blUy63w4uHO+adl9VXd+0l+m x2JoaaU0KR0xXZ/AHvUoe9UM3qM9KB/gV9KYQUbjjb+KaFjt7B4kvj5ow3v+iWHxzQPh E0kFS1P/FMAd07AMV1hSAVve3yRanQo34vG0NU++2Hfmzs/rOdVk2SsysmCBF+mno6V3 N9nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ka6Q0Zy6QrfcwL/CSvIzpjvnD4BQcyLVYFcLJW2zm44=; b=xN9M/EIiJbpEWxNb5hImFIDWcr0Co2N1Z4VKkbMkDKn7sU8g//D+K6BSHVDCxziDXV o0lVy0Mr4OcUJmYZHW3uazkpJgI1duZ/iMcqLfj6+/C6BcRGjlOjmvMrkCmNlRpU7FvF dra4tX0VH6EgDQGCi9AiQX0DouzpVpk8TR32vXBTK+LqiqetxWmc90bRqODYCCfzDT59 9jVXRMxM6H6MFUwLEvQxQokhoDDh62NOikYxww/A5Oi3QAE4Pm2V6vIVApE6BY/Ap9EQ nPfgkX3CTs5rXD8OBzp4e2oYaXesxqNeNqmaRg98AFydNzXfvkOE9s4xfMgasmFy4hzZ 1Oyg== X-Gm-Message-State: ANoB5pmmoJajsDDsfhJg/UWM9GYSp/tD4z9lhczEU1NHNwNbHWr84GVy hxFgSHIngVfnH7m67fDVYYZQ X-Google-Smtp-Source: AA0mqf6SOw1bsMBSVvaKIDjRLtE0EG36yQRvgTWvQZmk5KxiBImOnTVz2U4HWOVmlCqxSJmqBWrIVw== X-Received: by 2002:aa7:81d8:0:b0:561:c694:80b with SMTP id c24-20020aa781d8000000b00561c694080bmr18994198pfn.47.1669012948034; Sun, 20 Nov 2022 22:42:28 -0800 (PST) Received: from thinkpad ([59.92.99.222]) by smtp.gmail.com with ESMTPSA id b8-20020a170903228800b0016c9e5f291bsm8914094plh.111.2022.11.20.22.42.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Nov 2022 22:42:27 -0800 (PST) Date: Mon, 21 Nov 2022 12:12:24 +0530 From: Manivannan Sadhasivam To: Will Deacon Cc: Catalin Marinas , Robin Murphy , amit.pundir@linaro.org, andersson@kernel.org, quic_sibis@quicinc.com, sumit.semwal@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "arm64: dma: Drop cache invalidation from arch_dma_prep_coherent()" Message-ID: <20221121064224.GB11945@thinkpad> References: <20221114110329.68413-1-manivannan.sadhasivam@linaro.org> <20221114141109.GG30263@willie-the-truck> <1659929b-1372-cea6-5840-c58369a4252d@arm.com> <20221118105402.GA184726@thinkpad> <20221118123349.GC3697@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221118123349.GC3697@willie-the-truck> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2022 at 12:33:49PM +0000, Will Deacon wrote: > On Fri, Nov 18, 2022 at 04:24:02PM +0530, Manivannan Sadhasivam wrote: > > On Mon, Nov 14, 2022 at 05:38:00PM +0000, Catalin Marinas wrote: > > > On Mon, Nov 14, 2022 at 03:14:21PM +0000, Robin Murphy wrote: > > > > On 2022-11-14 14:11, Will Deacon wrote: > > > > > On Mon, Nov 14, 2022 at 04:33:29PM +0530, Manivannan Sadhasivam wrote: > > > > > > This reverts commit c44094eee32f32f175aadc0efcac449d99b1bbf7. > > > > > > > > > > > > As reported by Amit [1], dropping cache invalidation from > > > > > > arch_dma_prep_coherent() triggers a crash on the Qualcomm SM8250 platform > > > > > > (most probably on other Qcom platforms too). The reason is, Qcom > > > > > > qcom_q6v5_mss driver copies the firmware metadata and shares it with modem > > > > > > for validation. The modem has a secure block (XPU) that will trigger a > > > > > > whole system crash if the shared memory is accessed by the CPU while modem > > > > > > is poking at it. > > > > > > > > > > > > To avoid this issue, the qcom_q6v5_mss driver allocates a chunk of memory > > > > > > with no kernel mapping, vmap's it, copies the firmware metadata and > > > > > > unvmap's it. Finally the address is then shared with modem for metadata > > > > > > validation [2]. > > > > > > > > > > > > Now because of the removal of cache invalidation from > > > > > > arch_dma_prep_coherent(), there will be cache lines associated with this > > > > > > memory even after sharing with modem. So when the CPU accesses it, the XPU > > > > > > violation gets triggered. > > > > > > > > > > This last past is a non-sequitur: the buffer is no longer mapped on the CPU > > > > > side, so how would the CPU access it? > > > > > > > > Right, for the previous change to have made a difference the offending part > > > > of this buffer must be present in some cache somewhere *before* the DMA > > > > buffer allocation completes. > > > > > > > > Clearly that driver is completely broken though. If the DMA allocation came > > > > from a no-map carveout vma_dma_alloc_from_dev_coherent() then the vmap() > > > > shenanigans wouldn't work, so if it backed by struct pages then the whole > > > > dance is still pointless because *a cacheable linear mapping exists*, and > > > > it's just relying on the reduced chance that anything's going to re-fetch > > > > the linear map address after those pages have been allocated, exactly as I > > > > called out previously[1]. > > > > > > So I guess a DMA pool that's not mapped in the linear map, together with > > > memremap() instead of vmap(), would work around the issue. But the > > > driver needs fixing, not the arch code. > > > > > > > Okay, thanks for the hint. Can you share how to allocate the dma-pool that's > > not part of the kernel's linear map? I looked into it but couldn't find a way. > > The no-map property should take care of this iirc > Yeah, we have been using it in other places of the same driver. But as per Sibi, we used dynamic allocation for metadata validation since there was no memory reserved statically for that. But if we do not have a way to allocate a dynamic memory that is not part of kernel's linear map, then we may have to resort to using an existing reserved memory. Thanks, Mani > Will -- மணிவண்ணன் சதாசிவம்