From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Eric Biggers <ebiggers@kernel.org>,
linux-block@vger.kernel.org
Subject: Re: untangle the request_queue refcounting from the queue kobject v2
Date: Mon, 21 Nov 2022 08:02:44 +0100 [thread overview]
Message-ID: <20221121070244.GA23563@lst.de> (raw)
In-Reply-To: <Y3g9P8NB+ubuKaqA@ZenIV>
On Sat, Nov 19, 2022 at 02:19:43AM +0000, Al Viro wrote:
> > Changes since v1:
> > - also change the blk_crypto_sysfs_unregister prototype
> > - add two patches to fix the error handling in blk_register_queue
>
> Umm... Do we ever want access to queue parameters of the stuff that has
> a queue, but no associated gendisk? SCSI tape, for example...
What do you mean with "access queue parameters"? The sysfs access can
since day one only happen through the queue.
> Re refcounting: AFAICS, blk_mq_alloc_disk_for_queue() is broken.
> __alloc_disk_node() consumes queue reference (and stuffs it into gendisk->queue)
> on success; on failure it leaves the reference alone. E.g. this
Yes, it needs a put_queue for the error handler.
next prev parent reply other threads:[~2022-11-21 7:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 4:26 untangle the request_queue refcounting from the queue kobject v2 Christoph Hellwig
2022-11-14 4:26 ` [PATCH 1/5] blk-crypto: pass a gendisk to blk_crypto_sysfs_{,un}register Christoph Hellwig
2022-11-18 2:59 ` Eric Biggers
2022-11-14 4:26 ` [PATCH 2/5] block: factor out a blk_debugfs_remove helper Christoph Hellwig
2022-11-14 4:26 ` [PATCH 3/5] block: fix error unwinding in blk_register_queue Christoph Hellwig
2022-11-14 4:26 ` [PATCH 4/5] block: untangle request_queue refcounting from sysfs Christoph Hellwig
2022-11-14 4:26 ` [PATCH 5/5] block: mark blk_put_queue as potentially blocking Christoph Hellwig
2022-11-19 2:19 ` untangle the request_queue refcounting from the queue kobject v2 Al Viro
2022-11-19 3:00 ` Al Viro
2022-11-21 7:03 ` Christoph Hellwig
2022-11-21 7:02 ` Christoph Hellwig [this message]
2022-11-21 8:27 ` Christoph Hellwig
2022-11-30 18:09 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121070244.GA23563@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=ebiggers@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.