From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>,
kbusch@kernel.org, lengchao@huawei.com,
linux-nvme@lists.infradead.org, Gerd Bayer <gbayer@linux.ibm.com>
Subject: Re: [PATCH] nvme: don't call blk_mq_{,un}quiesce_tagset when ctrl->tagset is NULL
Date: Mon, 21 Nov 2022 08:04:32 +0100 [thread overview]
Message-ID: <20221121070432.GC23563@lst.de> (raw)
In-Reply-To: <2b6bae87-b008-6f8d-3c70-2334b5bd48b7@grimberg.me>
On Sun, Nov 20, 2022 at 01:38:28PM +0200, Sagi Grimberg wrote:
>
>>> All the other drivers check that they have IO queues before
>>> quiescing/unquiescing them.
>>
>> The core firmware activation code does not.
>
> Well, ideally it should, but maybe it would be more readable
> if we condition on ctrl->queue_count > 1.
I find this more confusing to be honest, but if we get a consensus for
that I can live with it.
next prev parent reply other threads:[~2022-11-21 7:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 7:27 [PATCH] nvme: don't call blk_mq_{,un}quiesce_tagset when ctrl->tagset is NULL Christoph Hellwig
2022-11-16 7:52 ` Chao Leng
2022-11-16 18:38 ` Chaitanya Kulkarni
2022-11-16 13:20 ` Sagi Grimberg
2022-11-16 13:22 ` Christoph Hellwig
2022-11-16 13:23 ` Sagi Grimberg
2022-11-16 13:28 ` Christoph Hellwig
2022-11-20 11:38 ` Sagi Grimberg
2022-11-21 7:04 ` Christoph Hellwig [this message]
2022-11-22 12:31 ` Christoph Hellwig
2022-11-22 12:34 ` Christoph Hellwig
2022-11-29 9:04 ` Christoph Hellwig
2022-11-30 8:27 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121070432.GC23563@lst.de \
--to=hch@lst.de \
--cc=gbayer@linux.ibm.com \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.