From: Christoph Hellwig <hch@lst.de>
To: David Howells <dhowells@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-afs@lists.infradead.org,
Marc Dionne <marc.dionne@auristor.com>,
Matthew Wilcox <willy@infradead.org>,
Theodore Ts'o <tytso@mit.edu>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] afs: Stop implementing ->writepage()
Date: Mon, 21 Nov 2022 09:33:03 +0100 [thread overview]
Message-ID: <20221121083303.GB27500@lst.de> (raw)
In-Reply-To: <150667.1669019337@warthog.procyon.org.uk>
On Mon, Nov 21, 2022 at 08:28:57AM +0000, David Howells wrote:
> > That would be much preferred over the for_write_begin hack, given that
> > write_begin really isn't a well defined method but a hacky hook for
> > legacy write implementations.
>
> So I don't need to worry about the control group stuff? I'll still need some
> way to flush a conflicting write whatever mechanism is being used to write to
> the page cache.
cgroup is used for throttling writeback. If you need to flush conflicting
writes I can't see how interacting with the cgroups benefits anyone.
An as far as I can tell afs doesn't support cgroup writeback to start
with.
prev parent reply other threads:[~2022-11-21 8:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 10:37 [RFC PATCH] afs: Stop implementing ->writepage() David Howells
2022-11-21 7:17 ` Christoph Hellwig
2022-11-21 8:28 ` David Howells
2022-11-21 8:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121083303.GB27500@lst.de \
--to=hch@lst.de \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.