From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Christoph Hellwig <hch@lst.de>,
Greg Ungerer <gerg@linux-m68k.org>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-m68k@lists.linux-m68k.org, uclinux-dev@uclinux.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] net: fec: use dma_alloc_noncoherent for m532x
Date: Mon, 21 Nov 2022 11:43:13 +0100 [thread overview]
Message-ID: <20221121104313.GA4644@lst.de> (raw)
In-Reply-To: <CAMuHMdVWjDYEAXqWuYYEOb=C-phYjS7wYNPSyZYweR0WhzSZ+A@mail.gmail.com>
On Mon, Nov 21, 2022 at 11:24:29AM +0100, Geert Uytterhoeven wrote:
> > +#ifdef CONFIG_M532x
>
> Shouldn't this be the !CONFIG_M532x path?
Yes.
next prev parent reply other threads:[~2022-11-21 10:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 9:56 fix dma_alloc_coherent on m68knommu / coldfire Christoph Hellwig
2022-11-21 9:56 ` [PATCH 1/2] net: fec: use dma_alloc_noncoherent for m532x Christoph Hellwig
2022-11-21 10:24 ` Geert Uytterhoeven
2022-11-21 10:43 ` Christoph Hellwig [this message]
2022-12-01 5:41 ` Greg Ungerer
2022-12-02 7:02 ` Christoph Hellwig
2022-12-05 14:09 ` Greg Ungerer
2022-11-21 9:56 ` [PATCH 2/2] m68k: return NULL from dma_alloc_coherent for nommu or coldfire Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121104313.GA4644@lst.de \
--to=hch@lst.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qiangqing.zhang@nxp.com \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.