From: Jakub Kicinski <kuba@kernel.org>
To: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Guangbin Huang <huangguangbin2@huawei.com>,
Andrew Lunn <andrew@lunn.ch>, Tom Rix <trix@redhat.com>,
Marco Bonelli <marco@mebeim.net>,
Edward Cree <ecree@solarflare.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] ethtool: avoiding integer overflow in ethtool_phys_id()
Date: Mon, 21 Nov 2022 12:12:58 -0800 [thread overview]
Message-ID: <20221121121258.4f359da8@kernel.org> (raw)
In-Reply-To: <20221121075618.15877-1-korotkov.maxim.s@gmail.com>
On Mon, 21 Nov 2022 10:56:18 +0300 Maxim Korotkov wrote:
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 2adc6edcaec0 ("ethtool: fix error handling in ethtool_phys_id")
I'm leaning towards dropping the fixes tag, and applying to -next.
Drivers returning high enough rc to cause an overflow seems theoretical,
and is pretty harmless. Please LMK if I'm missing something.
prev parent reply other threads:[~2022-11-21 20:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 7:56 [PATCH] ethtool: avoiding integer overflow in ethtool_phys_id() Maxim Korotkov
2022-11-21 14:10 ` Andrew Lunn
2022-11-21 15:03 ` Alexander Lobakin
2022-11-21 21:30 ` Keller, Jacob E
2022-11-22 6:53 ` Maxim Korotkov
2022-11-21 20:12 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121121258.4f359da8@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=edumazet@google.com \
--cc=huangguangbin2@huawei.com \
--cc=korotkov.maxim.s@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=marco@mebeim.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.