From: Roger Quadros <rogerq@kernel.org>
To: davem@davemloft.net, kuba@kernel.org
Cc: edumazet@google.com, pabeni@redhat.com, vigneshr@ti.com,
linux-omap@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Roger Quadros <rogerq@kernel.org>
Subject: [PATCH v2 2/4] net: ethernet: ti: am65-cpsw-nuss: Remove redundant ALE_CLEAR
Date: Mon, 21 Nov 2022 16:22:58 +0200 [thread overview]
Message-ID: <20221121142300.9320-3-rogerq@kernel.org> (raw)
In-Reply-To: <20221121142300.9320-1-rogerq@kernel.org>
ALE_CLEAR command is issued in cpsw_ale_start() so no need
to issue it before the call to cpsw_ale_start().
Fixes: fd23df72f2be ("net: ethernet: ti: am65-cpsw: Add suspend/resume support")
Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index 505c9edf98ff..2acde5b14516 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -404,7 +404,6 @@ static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common)
/* disable priority elevation */
writel(0, common->cpsw_base + AM65_CPSW_REG_PTYPE);
- cpsw_ale_control_set(common->ale, 0, ALE_CLEAR, 1);
cpsw_ale_start(common->ale);
/* limit to one RX flow only */
--
2.17.1
next prev parent reply other threads:[~2022-11-21 14:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 14:22 [PATCH v2 0/4] net: ethernet: ti: am65-cpsw: Fix set channel operation Roger Quadros
2022-11-21 14:22 ` [PATCH v2 1/4] " Roger Quadros
2022-11-21 17:50 ` Maciej Fijalkowski
2022-11-22 17:30 ` Roger Quadros
2022-11-22 0:58 ` Andrew Lunn
2022-11-22 17:31 ` Roger Quadros
2022-11-21 14:22 ` Roger Quadros [this message]
2022-11-21 17:51 ` [PATCH v2 2/4] net: ethernet: ti: am65-cpsw-nuss: Remove redundant ALE_CLEAR Maciej Fijalkowski
2022-11-22 1:02 ` Andrew Lunn
2022-11-22 11:46 ` Maciej Fijalkowski
2022-11-21 14:22 ` [PATCH v2 3/4] net: ethernet: ti: am65-cpsw: Restore ALE only if any interface was up Roger Quadros
2022-11-21 14:23 ` [PATCH v2 4/4] net: ethernet: ti: cpsw_ale: optimize cpsw_ale_restore() Roger Quadros
2022-11-21 17:11 ` [PATCH v2 0/4] net: ethernet: ti: am65-cpsw: Fix set channel operation Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121142300.9320-3-rogerq@kernel.org \
--to=rogerq@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.