All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: "Frager, Neal" <neal.frager@amd.com>
Cc: "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
	"buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v1 1/1] boot/uboot/uboot.mk: add stripped u-boot.elf support
Date: Mon, 21 Nov 2022 15:49:17 +0100	[thread overview]
Message-ID: <20221121154917.59ce2022@booty> (raw)
In-Reply-To: <CH2PR12MB5004C153A3109B9BC5400F46F00A9@CH2PR12MB5004.namprd12.prod.outlook.com>

Hello Neal,

On Mon, 21 Nov 2022 09:12:05 +0000
"Frager, Neal" <neal.frager@amd.com> wrote:

> Hello everyone,
> 
> Just a friendly reminder regarding this patch.  Any feedback?
> 
> If a user requests a u-boot binary in elf format, they may actually want the stripped u-boot.elf version.
> This patch provides the stripped u-boot.elf binary.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
>  boot/uboot/uboot.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk index 0439ec5e4b..216efc5a13 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -53,7 +53,7 @@ UBOOT_BINS += u-boot.dtb  endif
>  
>  ifeq ($(BR2_TARGET_UBOOT_FORMAT_ELF),y)
> -UBOOT_BINS += u-boot
> +UBOOT_BINS += u-boot u-boot.elf

This assumes BR2_TARGET_UBOOT_FORMAT_ELF will always result in
building u-boot.elf, but I don't think this is true for all platforms.

At a quick test with a RISC-V build and BR2_TARGET_UBOOT_FORMAT_ELF=y I
got a failure with your patch applied because u-boot is produced but
u-boot.elf isn't.

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-11-21 14:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 20:07 [Buildroot] [PATCH v1 1/1] boot/uboot/uboot.mk: add stripped u-boot.elf support Neal Frager via buildroot
2022-11-21  9:12 ` Frager, Neal via buildroot
2022-11-21 14:49   ` Luca Ceresoli via buildroot [this message]
2022-11-21 18:04     ` Frager, Neal via buildroot
2022-11-21 18:28     ` Frager, Neal via buildroot
  -- strict thread matches above, loose matches on Subject: below --
2022-11-08 20:11 Neal Frager via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221121154917.59ce2022@booty \
    --to=buildroot@buildroot.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=neal.frager@amd.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.