From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57395C43219 for ; Tue, 22 Nov 2022 06:07:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232004AbiKVGHI (ORCPT ); Tue, 22 Nov 2022 01:07:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbiKVGHH (ORCPT ); Tue, 22 Nov 2022 01:07:07 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29D932936B; Mon, 21 Nov 2022 22:07:05 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 6CF9A68D05; Tue, 22 Nov 2022 07:06:59 +0100 (CET) Date: Tue, 22 Nov 2022 07:06:59 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Jeff Layton , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Alexander Viro , Xiubo Li , Ilya Dryomov , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Christine Caulfield , David Teigland , Chuck Lever , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Namjae Jeon , Sergey Senozhatsky , Trond Myklebust , Anna Schumaker , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , "Darrick J. Wong" , hch@lst.de, linux-kernel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, devel@lists.orangefs.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH] filelock: move file locking definitions to separate header file Message-ID: <20221122060659.GA14084@lst.de> References: <20221120210004.381842-1-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On Tue, Nov 22, 2022 at 03:51:31AM +0000, Matthew Wilcox wrote: > These two seem undefined at this point. > > > + struct fasync_struct * fl_fasync; /* for lease break notifications */ Given that we just use a pointer to it there is no need to have a definition. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Tue, 22 Nov 2022 07:06:59 +0100 Subject: [Cluster-devel] [PATCH] filelock: move file locking definitions to separate header file In-Reply-To: References: <20221120210004.381842-1-jlayton@kernel.org> Message-ID: <20221122060659.GA14084@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Nov 22, 2022 at 03:51:31AM +0000, Matthew Wilcox wrote: > These two seem undefined at this point. > > > + struct fasync_struct * fl_fasync; /* for lease break notifications */ Given that we just use a pointer to it there is no need to have a definition. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aib29ajc255.phx1.oracleemaildelivery.com (aib29ajc255.phx1.oracleemaildelivery.com [192.29.103.255]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D80AAC4332F for ; Sat, 26 Nov 2022 18:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=oss-phx-1109; d=oss.oracle.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=BsQWRe+9ZJfTuObUFlzsV2taA2SJtVVBChi8D5kJqtI=; b=sjX4yqB2Kna13ZbGNBq9Z7o4sXMqFSXfDeEKEj+9/4x3hPax1NotKVS4werT9veS0BsZgRVBTmU8 fIM3fERvnjWGsTYiWUulOkJojvFE5JiR22tza54XNDY7VM0Xv6J3I42CPy5lEWBANzx05DVIWCUM 2qPzmptvJwpRj1hCrpkAPsFIGb9+tNxXFT2+ce+AtZDvy0XQG3aKxcFK9kKX/mGeBKBiTnILrEe1 nQ1ufPsywr41BRM9lKT5adSnqfxg3WtHVFrAuZKBbjL41ZZguGB+L9W6+COK80W0uKX5rmiAfkgY 9P6nHdce5H/iXOzaYZFIdYdjD4UvqsEyjTLU1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=prod-phx-20191217; d=phx1.rp.oracleemaildelivery.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=BsQWRe+9ZJfTuObUFlzsV2taA2SJtVVBChi8D5kJqtI=; b=RcaHf8jlEMyXNm6w1asF7RBaIGJVIQGjLr8MALPPZfQAaI5F/iu1SfcK9Lxohv5tHbQ9Wy/fe7yy NXl5916mjAct/5tCmeVmfbOw8WAM77zF1T31JpUSOdylm7F2P4M4qP1OhQgJSs/MO2pL/Z8lOFyM GoewbQ9KmfS2isTudxc7g0rvyRv8+aMq2qCvnIBdQ3sucDhqABsq/GlRLSgjvI0QX2YevAcyL+37 BeTheqpu3BmKrNBW2lJG8fi+5gAaE5T3nBDkUVewWhpksxP2XJ2scEoiZFuCrOiri4Muz+KO2bnM Z7n5hopCeBynQ00wyng98dIdWrlw2SBNowpd3Q== Received: by omta-ad3-fd3-302-us-phoenix-1.omtaad3.vcndpphx.oraclevcn.com (Oracle Communications Messaging Server 8.1.0.1.20221104 64bit (built Nov 4 2022)) with ESMTPS id <0RLY00AUZVZ1YL70@omta-ad3-fd3-302-us-phoenix-1.omtaad3.vcndpphx.oraclevcn.com> for ocfs2-devel@archiver.kernel.org; Sat, 26 Nov 2022 18:13:49 +0000 (GMT) Date: Tue, 22 Nov 2022 07:06:59 +0100 To: Matthew Wilcox Message-id: <20221122060659.GA14084@lst.de> References: <20221120210004.381842-1-jlayton@kernel.org> MIME-version: 1.0 Content-disposition: inline In-reply-to: User-Agent: Mutt/1.5.17 (2007-11-01) X-Source-IP: 213.95.11.211 X-Proofpoint-Virus-Version: vendor=nai engine=6500 definitions=10538 signatures=596816 X-Proofpoint-Spam-Details: rule=tap_notspam policy=tap score=0 spamscore=0 suspectscore=0 mlxlogscore=680 clxscore=303 adultscore=0 lowpriorityscore=0 phishscore=0 mlxscore=0 bulkscore=0 malwarescore=0 impostorscore=0 priorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211220044 Cc: Latchesar Ionkov , Martin Brandenburg , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, Mike Marshall , linux-cifs@vger.kernel.org, Andreas Gruenbacher , Miklos Szeredi , linux-afs@lists.infradead.org, cluster-devel@redhat.com, Christine Caulfield , v9fs-developer@lists.sourceforge.net, Ilya Dryomov , Namjae Jeon , devel@lists.orangefs.org, Shyam Prasad N , Eric Van Hensbergen , Tom Talpey , linux-fsdevel@vger.kernel.org, Alexander Viro , ceph-devel@vger.kernel.org, Xiubo Li , Trond Myklebust , linux-nfs@vger.kernel.org, Paulo Alcantara , Jeff Layton , linux-kernel@vger.kernel.org, Ronnie Sahlberg , Steve French , Sergey Senozhatsky , Chuck Lever , Anna Schumaker , Bob Peterson , ocfs2-devel@oss.oracle.com Subject: Re: [Ocfs2-devel] [PATCH] filelock: move file locking definitions to separate header file X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Christoph Hellwig via Ocfs2-devel Reply-to: Christoph Hellwig Content-type: text/plain; charset="us-ascii" Content-transfer-encoding: 7bit Errors-to: ocfs2-devel-bounces@oss.oracle.com X-ServerName: verein.lst.de X-Proofpoint-SPF-Result: None X-Spam: Clean X-Proofpoint-GUID: tEwG3X4PQorLgdAUiwMje8_J7ukolO-5 X-Proofpoint-ORIG-GUID: tEwG3X4PQorLgdAUiwMje8_J7ukolO-5 X-Mailman-Approved-At: Sat, 26 Nov 2022 18:13:43 +0000 Reporting-Meta: AAGWssAnS/k6StFg12VxWIdd+jMm53JlV3NBdCRMsSqZ7ZIRQgVOOQG2XogQllyv jjrS2PJuJAvTPg22izQl5ILHHFty+AppD+2ewJhsfIfuyUkKLAnu87Y09G7Kq9Mo 37BRkfsczochfgxqMJr6mX24ABBvEcDTE3kjuH2KAD3KHs4JW5jc/OD2ahNjCyZe orBmaKx6ZhSqBM0hPVXEDeMZUxHTQqmLomN/ytAgi72rYW8EP3Q5SP7UQTsNLLXo UdE28+3VvhNPO57PHILJfyxNdcBQ7bODasbt0XmQGUBWFGskb7L4q+CZWup/Cy50 ZgeYmUG2/lCeFu6HNSBM4jJfY81EN8XyfqJyt0H/t0+rv7xx0cKcv9mkaXrxvF7s Q5ZI4WVWilHoCksWyGstP6U1qqAmGkXQW3FsKyEtPPVfEewdvFNN9UM+7RutJeN4 kknNFrMhwD6VoBszpD/ovThUnEWnqDcvzaPQQ3oYj7ZM/NHxDoZ4sZ/l9o5Olffr 5mOl/VYeDZtUu/yAJXLp87vTpCPnK0AUO0hhs0TYTIQe On Tue, Nov 22, 2022 at 03:51:31AM +0000, Matthew Wilcox wrote: > These two seem undefined at this point. > > > + struct fasync_struct * fl_fasync; /* for lease break notifications */ Given that we just use a pointer to it there is no need to have a definition. _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel