From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 434B1C4332F for ; Tue, 22 Nov 2022 09:12:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 98A8410E3BD; Tue, 22 Nov 2022 09:12:56 +0000 (UTC) X-Greylist: delayed 510 seconds by postgrey-1.36 at gabe; Tue, 22 Nov 2022 08:32:17 UTC Received: from mail.fris.de (mail.fris.de [IPv6:2a01:4f8:c2c:390b::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 78CD010E3A8 for ; Tue, 22 Nov 2022 08:32:17 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5C2D4BFCC8; Tue, 22 Nov 2022 09:23:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fris.de; s=dkim; t=1669105422; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding; bh=HF/dQ7k7L9EVK7uPaLgIE5BOxzPXAihnaMZPR/UT1nM=; b=C7hrUPVl5EI4C4/6K7jCUsTQ4eKq9V2kKy+XeTx1e/lWQQdMGQErEC+cP3zm1LhiM5vu82 Ij6+ujbbTpSGVgKedvZYIToLbyCH2cK9CRi/uDRhnpsqhALmVNwKE35GmyOVW35oxMfPu5 2cDOprgQy7jTqapK+aTZ8scjkYhA7SZOgHOsLewhOmkF+xxc8j0RhpG1K6M6AAqHzlsUYS 1WUet/2/i9ftPmd2Z7suQuZyEdJcu4x34ps++NvTPg0ADASSxR6cMmmCYyhIMewPEMTe1u okf0LOem1UHOCsInXIx6xyUQKrsd30wrUcSyI9djo19I61vVNe5c1B9mZ5h5zQ== From: Frieder Schrempf To: Andrzej Hajda , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, Frieder Schrempf , Linus Walleij , linux-kernel@vger.kernel.org, Marek Vasut , Neil Armstrong , Robert Foss Subject: [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec Date: Tue, 22 Nov 2022 09:12:18 +0100 Message-Id: <20221122081219.20143-1-frieder@fris.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 X-Mailman-Approved-At: Tue, 22 Nov 2022 09:12:53 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonas Karlman , Alexander Stein , Jernej Skrabec , Christophe JAILLET , Laurent Pinchart , =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Frieder Schrempf The datasheet specifies a delay of 10 milliseconds, but the current driver only waits for 1 ms. Fix this to make sure the initialization sequence meets the spec. Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver") Signed-off-by: Frieder Schrempf --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 7ba9467fff12..047c14ddbbf1 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c @@ -346,7 +346,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge *bridge, /* Deassert reset */ gpiod_set_value_cansleep(ctx->enable_gpio, 1); - usleep_range(1000, 1100); + usleep_range(10000, 11000); /* Get the LVDS format from the bridge state. */ bridge_state = drm_atomic_get_new_bridge_state(state, bridge); -- 2.38.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E35ABC4332F for ; Tue, 22 Nov 2022 08:23:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232717AbiKVIXs (ORCPT ); Tue, 22 Nov 2022 03:23:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232132AbiKVIXr (ORCPT ); Tue, 22 Nov 2022 03:23:47 -0500 Received: from mail.fris.de (mail.fris.de [116.203.77.234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CB3D29351 for ; Tue, 22 Nov 2022 00:23:45 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5C2D4BFCC8; Tue, 22 Nov 2022 09:23:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fris.de; s=dkim; t=1669105422; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding; bh=HF/dQ7k7L9EVK7uPaLgIE5BOxzPXAihnaMZPR/UT1nM=; b=C7hrUPVl5EI4C4/6K7jCUsTQ4eKq9V2kKy+XeTx1e/lWQQdMGQErEC+cP3zm1LhiM5vu82 Ij6+ujbbTpSGVgKedvZYIToLbyCH2cK9CRi/uDRhnpsqhALmVNwKE35GmyOVW35oxMfPu5 2cDOprgQy7jTqapK+aTZ8scjkYhA7SZOgHOsLewhOmkF+xxc8j0RhpG1K6M6AAqHzlsUYS 1WUet/2/i9ftPmd2Z7suQuZyEdJcu4x34ps++NvTPg0ADASSxR6cMmmCYyhIMewPEMTe1u okf0LOem1UHOCsInXIx6xyUQKrsd30wrUcSyI9djo19I61vVNe5c1B9mZ5h5zQ== From: Frieder Schrempf To: Andrzej Hajda , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, Frieder Schrempf , Linus Walleij , linux-kernel@vger.kernel.org, Marek Vasut , Neil Armstrong , Robert Foss Cc: Alexander Stein , Christophe JAILLET , Jernej Skrabec , Jonas Karlman , =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= , Laurent Pinchart , Sam Ravnborg , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= Subject: [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec Date: Tue, 22 Nov 2022 09:12:18 +0100 Message-Id: <20221122081219.20143-1-frieder@fris.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frieder Schrempf The datasheet specifies a delay of 10 milliseconds, but the current driver only waits for 1 ms. Fix this to make sure the initialization sequence meets the spec. Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver") Signed-off-by: Frieder Schrempf --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 7ba9467fff12..047c14ddbbf1 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c @@ -346,7 +346,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge *bridge, /* Deassert reset */ gpiod_set_value_cansleep(ctx->enable_gpio, 1); - usleep_range(1000, 1100); + usleep_range(10000, 11000); /* Get the LVDS format from the bridge state. */ bridge_state = drm_atomic_get_new_bridge_state(state, bridge); -- 2.38.1